Cover Letter Detail
Show a cover letter.
GET /api/covers/2013886/?format=api
{ "id": 2013886, "url": "http://patchwork.ozlabs.org/api/covers/2013886/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20241121154218.1423005-1-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20241121154218.1423005-1-berrange@redhat.com>", "list_archive_url": null, "date": "2024-11-21T15:42:00", "name": "[v2,00/18] test/functional: improve functional test debugging & fix tuxrun", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20241121154218.1423005-1-berrange@redhat.com/mbox/", "series": [ { "id": 433720, "url": "http://patchwork.ozlabs.org/api/series/433720/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=433720", "date": "2024-11-21T15:42:05", "name": "test/functional: improve functional test debugging & fix tuxrun", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/433720/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2013886/comments/", "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QcrlFk5M;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XvMvs1BpTz1xyG\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 22 Nov 2024 02:43:34 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1tE9KK-0008Ko-B0; Thu, 21 Nov 2024 10:42:41 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1tE9KF-0008Ka-Lu\n for qemu-devel@nongnu.org; Thu, 21 Nov 2024 10:42:35 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1tE9KD-0000gb-OW\n for qemu-devel@nongnu.org; Thu, 21 Nov 2024 10:42:35 -0500", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-354-Yy6L9MsOOui5tPWwsGcs4g-1; Thu,\n 21 Nov 2024 10:42:30 -0500", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 24A3219560BA; Thu, 21 Nov 2024 15:42:29 +0000 (UTC)", "from toolbox.redhat.com (unknown [10.42.28.5])\n by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 9C7181956086; Thu, 21 Nov 2024 15:42:24 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1732203752;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=1kzY05YIyisaEtoHgIBuwAW769ac3YNgNHC2v90si6w=;\n b=QcrlFk5M5A48DcQFFRL2xjTE8GayAmVvx3QND9dokwlibysx0l+KgCuqrFh7Wv01GomoyZ\n dIWXItWnEI0LVyyX6nCrPAiBrcVeQF9i7ndsi+XfQD6NmdoO+S1ovKZcWEDRmhU9poZoPl\n mCwzi3BnAajEU6PLzuQSI8AQBaM++CU=", "X-MC-Unique": "Yy6L9MsOOui5tPWwsGcs4g-1", "X-Mimecast-MFC-AGG-ID": "Yy6L9MsOOui5tPWwsGcs4g", "From": "=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Thomas Huth <thuth@redhat.com>, Ani Sinha <anisinha@redhat.com>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "Subject": "[PATCH v2 00/18] test/functional: improve functional test debugging &\n fix tuxrun", "Date": "Thu, 21 Nov 2024 15:42:00 +0000", "Message-ID": "<20241121154218.1423005-1-berrange@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-21", "X-Spam_score": "-2.2", "X-Spam_bar": "--", "X-Spam_report": "(-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.14,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This started out as a series to get rid of the many GBs of temp\nfiles the functional tests leave behind. Then it expanded into\nimproving the functional test debugging by ensuring we preserve\nthe QEMU stdout/stderr log file created by the QEMUMachine class.\nIn the course of doing that I encountered some other minor points\nworth fixing, and then got side tracked into looking at the tuxrun\nhangs with aarch64be. Investigating the latter exposed some further\nholes in the debugging story prompting yet more patches, as well as\na final solution for tuxrun. So this series does:\n\n * Purge all scratch files created by tests\n * Preserve the stdout/stderr log file\n * Capture debug log messages on QEMUMachine\n * Provide a QMP backdoor for debugging stuck QEMUs\n * Enhance console handling for partial line matches\n * Fix the tuxrun tests by eliminating sleeps\n\nThere's quite alot of code here, but at the same time it feels like\nthe kind of stuff that'll be valuable either in the 9.2 release, or\nin the soon to exist 9.2 stable branch.\n\nNB, with this series applied Thomas' tuxrun conversion to functional\ntesting survives 200 iterations on my machine, whereas it would\nreliably hang in < 20, and often in < 10, before.\n\nChanged in v2:\n\n - Changed console interaction to forbid 'failure_message'\n without 'success_message'\n - Reword console interaction log messages\n - Avoid stack trace when seeing early failure\n - Rewrote comment in acpi bits test\n - Avoid duplicate os.environ access\n\nDaniel P. Berrangé (18):\n tests/functional: fix mips64el test to honour workdir\n tests/functional: automatically clean up scratch files after tests\n tests/functional: remove \"AVOCADO\" from env variable name\n tests/functional: remove todo wrt avocado.utils.wait_for\n tests/functional: remove leftover :avocado: tags\n tests/functional: remove obsolete reference to avocado bug\n tests/functional: remove comments talking about avocado\n tests/functional: honour self.workdir in ACPI bits tests\n tests/functional: put QEMUMachine logs in testcase log directory\n tests/functional: honour requested test VM name in QEMUMachine\n tests/functional: enable debug logging for QEMUMachine\n tests/functional: logs details of console interaction operations\n tests/functional: don't try to wait for the empty string\n tests/functional: require non-NULL success_message for console wait\n tests/functional: rewrite console handling to be bytewise\n tests/functional: remove time.sleep usage from tuxrun tests\n tests/functional: add a QMP backdoor for debugging stalled tests\n tests/functional: avoid accessing log_filename on earlier failures\n\n docs/devel/testing/functional.rst | 16 +++++\n tests/functional/qemu_test/cmd.py | 89 +++++++++++++++++++-----\n tests/functional/qemu_test/testcase.py | 43 +++++++++---\n tests/functional/qemu_test/tuxruntest.py | 17 ++---\n tests/functional/test_acpi_bits.py | 57 +++++----------\n tests/functional/test_arm_bpim2u.py | 20 ------\n tests/functional/test_arm_orangepi.py | 27 -------\n tests/functional/test_m68k_nextcube.py | 3 +-\n tests/functional/test_mips64el_malta.py | 4 +-\n tests/functional/test_virtio_gpu.py | 3 +-\n 10 files changed, 150 insertions(+), 129 deletions(-)" }