Cover Letter Detail
Show a cover letter.
GET /api/covers/1658281/?format=api
{ "id": 1658281, "url": "http://patchwork.ozlabs.org/api/covers/1658281/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/cover/20220720030436.79520-1-xuanzhuo@linux.alibaba.com/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>", "list_archive_url": null, "date": "2022-07-20T03:03:56", "name": "[v12,00/40] virtio pci support VIRTIO_F_RING_RESET", "submitter": { "id": 80519, "url": "http://patchwork.ozlabs.org/api/people/80519/?format=api", "name": "Xuan Zhuo", "email": "xuanzhuo@linux.alibaba.com" }, "mbox": "http://patchwork.ozlabs.org/project/linux-um/cover/20220720030436.79520-1-xuanzhuo@linux.alibaba.com/mbox/", "series": [ { "id": 310331, "url": "http://patchwork.ozlabs.org/api/series/310331/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=310331", "date": "2022-07-20T03:03:59", "name": "virtio pci support VIRTIO_F_RING_RESET", "version": 12, "mbox": "http://patchwork.ozlabs.org/series/310331/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/1658281/comments/", "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=fJV9S1Jw;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LngYF3jbvz9s2R\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 20 Jul 2022 13:05:05 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE016-00HE3v-Jn; Wed, 20 Jul 2022 03:04:52 +0000", "from out30-130.freemail.mail.aliyun.com ([115.124.30.130])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE012-00HDuy-Ep\n\tfor linux-um@lists.infradead.org; Wed, 20 Jul 2022 03:04:51 +0000", "from localhost(mailfrom:xuanzhuo@linux.alibaba.com\n fp:SMTPD_---0VJuvIOR_1658286276)\n by smtp.aliyun-inc.com;\n Wed, 20 Jul 2022 11:04:37 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc\n\t:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=oeztTL9LDupvQRO9LBRn20+g7EHRdMSYnu47SA8Z/bg=; b=fJV9S1JwURccea\n\t3FfQTXFXAXIMDdJI+3llt7g9N1/vhgZZu7HfuT1NUi21AO+EofyrNfJOz97LLz9HkIkbbLF+/nK1l\n\t/lkgHyHPgANAD45lJWglq+kFb/lSKcFK6N6PbZ2dp9Y5GmNtTabRNld2LQ/ls49k+1hsSqkmlToQh\n\tMTi3j2XbrP3SdCQ55HN3Pz5uyFTzVWD+H8Qz0oRaVHvlWTF28JuPwXw/LmqYJnRAsDQ2o+KiAfBEE\n\tHto9QEhg2sGpxZYq4mJAT4++rwtGKn0X9s2GSWL5r6CesZRYr4RdK5yZeY40mFzJkVQQVMWbSrm86\n\tXNVlihoqejbI6z6AD36w==;", "X-Alimail-AntiSpam": "\n AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=37;SR=0;TI=SMTPD_---0VJuvIOR_1658286276;", "From": "Xuan Zhuo <xuanzhuo@linux.alibaba.com>", "To": "virtualization@lists.linux-foundation.org", "Cc": "Richard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>,\n\tJason Wang <jasowang@redhat.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tEric Dumazet <edumazet@google.com>,\n\tJakub Kicinski <kuba@kernel.org>,\n\tPaolo Abeni <pabeni@redhat.com>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tMark Gross <markgross@kernel.org>,\n\tVadim Pasternak <vadimp@nvidia.com>,\n\tBjorn Andersson <bjorn.andersson@linaro.org>,\n\tMathieu Poirier <mathieu.poirier@linaro.org>,\n\tCornelia Huck <cohuck@redhat.com>,\n\tHalil Pasic <pasic@linux.ibm.com>,\n\tEric Farman <farman@linux.ibm.com>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\tAlexei Starovoitov <ast@kernel.org>,\n\tDaniel Borkmann <daniel@iogearbox.net>,\n\tJesper Dangaard Brouer <hawk@kernel.org>,\n\tJohn Fastabend <john.fastabend@gmail.com>,\n\tXuan Zhuo <xuanzhuo@linux.alibaba.com>,\n\tVincent Whitchurch <vincent.whitchurch@axis.com>,\n\tlinux-um@lists.infradead.org,\n\tnetdev@vger.kernel.org,\n\tplatform-driver-x86@vger.kernel.org,\n\tlinux-remoteproc@vger.kernel.org,\n\tlinux-s390@vger.kernel.org,\n\tkvm@vger.kernel.org,\n\tbpf@vger.kernel.org,\n\tkangjie.xu@linux.alibaba.com", "Subject": "[PATCH v12 00/40] virtio pci support VIRTIO_F_RING_RESET", "Date": "Wed, 20 Jul 2022 11:03:56 +0800", "Message-Id": "<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>", "X-Mailer": "git-send-email 2.31.0", "MIME-Version": "1.0", "X-Git-Hash": "366032b2ffac", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20220719_200448_702944_993446E6 ", "X-CRM114-Status": "GOOD ( 14.16 )", "X-Spam-Score": "-8.0 (--------)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: The virtio spec already supports the virtio queue reset\n function.\n This patch set is to add this function to the kernel. The relevant virtio\n spec information is here:\n https://github.com/oasis-tcs/virtio-spec/issues/124\n https://github.com/oasis-tcs/virtio-spec/issues/139\n Content analysis details: (-8.0 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,\n no trust\n [115.124.30.130 listed in list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -7.5 USER_IN_DEF_SPF_WL From: address is in the default SPF\n white-list\n -0.5 ENV_AND_HDR_SPF_MATCH Env and Hdr From used in default SPF WL\n Match\n 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n lines", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "The virtio spec already supports the virtio queue reset function. This patch set\nis to add this function to the kernel. The relevant virtio spec information is\nhere:\n\n https://github.com/oasis-tcs/virtio-spec/issues/124\n https://github.com/oasis-tcs/virtio-spec/issues/139\n\nAlso regarding MMIO support for queue reset, I plan to support it after this\npatch is passed.\n\nThis patch set implements the refactoring of vring. Finally, the\nvirtuque_resize() interface is provided based on the reset function of the\ntransport layer.\n\nTest environment:\n Host: 4.19.91\n Qemu: QEMU emulator version 6.2.50 (with vq reset support)\n Test Cmd: ethtool -G eth1 rx $1 tx $2; ethtool -g eth1\n\n The default is split mode, modify Qemu virtio-net to add PACKED feature to test\n packed mode.\n\nQemu code:\n https://github.com/fengidri/qemu/compare/89f3bfa3265554d1d591ee4d7f1197b6e3397e84...master\n\nIn order to simplify the review of this patch set, the function of reusing\nthe old buffers after resize will be introduced in subsequent patch sets.\n\nPlease review. Thanks.\n\nv12:\n 1. access vq->num_max directly without helper\n 2. rename the vq reset callbacks:\n \t int (*disable_vq_and_reset)(struct virtqueue *vq);\n \t int (*enable_vq_after_reset)(struct virtqueue *vq);\n\n 3. rename vring to vring_split, vring_packed\n 4. protect sq->reset by tx lock\n\nv11:\n 1. struct virtio_pci_common_cfg to virtio_pci_modern.h\n 2. conflict resolution\n\nv10:\n 1. on top of the harden vring IRQ\n 2. factor out split and packed from struct vring_virtqueue\n 3. some suggest from @Jason Wang\n\nv9:\n 1. Provide a virtqueue_resize() interface directly\n 2. A patch set including vring resize, virtio pci reset, virtio-net resize\n 3. No more separate structs\n\nv8:\n 1. Provide a virtqueue_reset() interface directly\n 2. Split the two patch sets, this is the first part\n 3. Add independent allocation helper for allocating state, extra\n\nv7:\n 1. fix #6 subject typo\n 2. fix #6 ring_size_in_bytes is uninitialized\n 3. check by: make W=12\n\nv6:\n 1. virtio_pci: use synchronize_irq(irq) to sync the irq callbacks\n 2. Introduce virtqueue_reset_vring() to implement the reset of vring during\n the reset process. May use the old vring if num of the vq not change.\n 3. find_vqs() support sizes to special the max size of each vq\n\nv5:\n 1. add virtio-net support set_ringparam\n\nv4:\n 1. just the code of virtio, without virtio-net\n 2. Performing reset on a queue is divided into these steps:\n 1. reset_vq: reset one vq\n 2. recycle the buffer from vq by virtqueue_detach_unused_buf()\n 3. release the ring of the vq by vring_release_virtqueue()\n 4. enable_reset_vq: re-enable the reset queue\n 3. Simplify the parameters of enable_reset_vq()\n 4. add container structures for virtio_pci_common_cfg\n\nv3:\n 1. keep vq, irq unreleased\n\nXuan Zhuo (40):\n virtio: record the maximum queue num supported by the device.\n virtio: struct virtio_config_ops add callbacks for queue_reset\n virtio_ring: update the document of the virtqueue_detach_unused_buf\n for queue reset\n virtio_ring: extract the logic of freeing vring\n virtio_ring: split vring_virtqueue\n virtio_ring: introduce virtqueue_init()\n virtio_ring: split: introduce vring_free_split()\n virtio_ring: split: extract the logic of alloc queue\n virtio_ring: split: extract the logic of alloc state and extra\n virtio_ring: split: extract the logic of attach vring\n virtio_ring: split: extract the logic of vring init\n virtio_ring: split: introduce virtqueue_reinit_split()\n virtio_ring: split: reserve vring_align, may_reduce_num\n virtio_ring: split: introduce virtqueue_resize_split()\n virtio_ring: packed: introduce vring_free_packed\n virtio_ring: packed: extract the logic of alloc queue\n virtio_ring: packed: extract the logic of alloc state and extra\n virtio_ring: packed: extract the logic of attach vring\n virtio_ring: packed: extract the logic of vring init\n virtio_ring: packed: introduce virtqueue_reinit_packed()\n virtio_ring: packed: introduce virtqueue_resize_packed()\n virtio_ring: introduce virtqueue_resize()\n virtio_pci: struct virtio_pci_common_cfg add queue_notify_data\n virtio: allow to unbreak/break virtqueue individually\n virtio: queue_reset: add VIRTIO_F_RING_RESET\n virtio_ring: struct virtqueue introduce reset\n virtio_pci: struct virtio_pci_common_cfg add queue_reset\n virtio_pci: introduce helper to get/set queue reset\n virtio_pci: extract the logic of active vq for modern pci\n virtio_pci: support VIRTIO_F_RING_RESET\n virtio: find_vqs() add arg sizes\n virtio_pci: support the arg sizes of find_vqs()\n virtio_mmio: support the arg sizes of find_vqs()\n virtio: add helper virtio_find_vqs_ctx_size()\n virtio_net: set the default max ring size by find_vqs()\n virtio_net: get ringparam by virtqueue_get_vring_max_size()\n virtio_net: split free_unused_bufs()\n virtio_net: support rx queue resize\n virtio_net: support tx queue resize\n virtio_net: support set_ringparam\n\n arch/um/drivers/virtio_uml.c | 3 +-\n drivers/net/virtio_net.c | 208 +++++-\n drivers/platform/mellanox/mlxbf-tmfifo.c | 3 +\n drivers/remoteproc/remoteproc_virtio.c | 3 +\n drivers/s390/virtio/virtio_ccw.c | 4 +\n drivers/virtio/virtio_mmio.c | 11 +-\n drivers/virtio/virtio_pci_common.c | 32 +-\n drivers/virtio/virtio_pci_common.h | 3 +-\n drivers/virtio/virtio_pci_legacy.c | 8 +-\n drivers/virtio/virtio_pci_modern.c | 161 ++++-\n drivers/virtio/virtio_pci_modern_dev.c | 39 ++\n drivers/virtio/virtio_ring.c | 769 +++++++++++++++++------\n drivers/virtio/virtio_vdpa.c | 3 +\n include/linux/virtio.h | 10 +\n include/linux/virtio_config.h | 40 +-\n include/linux/virtio_pci_modern.h | 9 +\n include/uapi/linux/virtio_config.h | 7 +-\n include/uapi/linux/virtio_pci.h | 2 +\n 18 files changed, 1038 insertions(+), 277 deletions(-)\n\n--\n2.31.0" }