Cover Letter Detail
Show a cover letter.
GET /api/covers/1555096/?format=api
{ "id": 1555096, "url": "http://patchwork.ozlabs.org/api/covers/1555096/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/cover/20211115025312.786953-1-cmi@nvidia.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211115025312.786953-1-cmi@nvidia.com>", "list_archive_url": null, "date": "2021-11-15T02:53:04", "name": "[ovs-dev,v18,0/8] Add offload support for sFlow", "submitter": { "id": 80086, "url": "http://patchwork.ozlabs.org/api/people/80086/?format=api", "name": "Chris Mi", "email": "cmi@nvidia.com" }, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/cover/20211115025312.786953-1-cmi@nvidia.com/mbox/", "series": [ { "id": 271987, "url": "http://patchwork.ozlabs.org/api/series/271987/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=271987", "date": "2021-11-15T02:53:04", "name": "Add offload support for sFlow", "version": 18, "mbox": "http://patchwork.ozlabs.org/series/271987/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/1555096/comments/", "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=gOc2Ug/R;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4Hstzq326sz9s5P\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 15 Nov 2021 13:53:27 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 9389980D9B;\n\tMon, 15 Nov 2021 02:53:24 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n\tby localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id d0HG33HIkVW7; Mon, 15 Nov 2021 02:53:23 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id C7B5A80D5D;\n\tMon, 15 Nov 2021 02:53:22 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id A3F18C002E;\n\tMon, 15 Nov 2021 02:53:22 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 0C948C0012\n for <dev@openvswitch.org>; Mon, 15 Nov 2021 02:53:22 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 02ABC80D80\n for <dev@openvswitch.org>; Mon, 15 Nov 2021 02:53:22 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id pJocUo5kYYev for <dev@openvswitch.org>;\n Mon, 15 Nov 2021 02:53:21 +0000 (UTC)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2043.outbound.protection.outlook.com [40.107.237.43])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 263E280D5D\n for <dev@openvswitch.org>; Mon, 15 Nov 2021 02:53:21 +0000 (UTC)", "from BN9PR03CA0491.namprd03.prod.outlook.com (2603:10b6:408:130::16)\n by DM6PR12MB3369.namprd12.prod.outlook.com (2603:10b6:5:117::16) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.17; Mon, 15 Nov\n 2021 02:53:18 +0000", "from BN8NAM11FT059.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:130:cafe::9e) by BN9PR03CA0491.outlook.office365.com\n (2603:10b6:408:130::16) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26 via Frontend\n Transport; Mon, 15 Nov 2021 02:53:17 +0000", "from mail.nvidia.com (216.228.112.36) by\n BN8NAM11FT059.mail.protection.outlook.com (10.13.177.120) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4690.15 via Frontend Transport; Mon, 15 Nov 2021 02:53:17 +0000", "from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL101.nvidia.com\n (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 15 Nov\n 2021 02:53:16 +0000", "from dev-r630-03.lab.mtl.com (172.20.187.5) by mail.nvidia.com\n (172.20.187.10) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 15 Nov 2021 02:53:14 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "whitelisted by SQLgrey-1.8.0", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=bXKy2zHYna51ON1yhC5qaMU3RyTNZyZ5VoRTXwFl9xDa+aTJcdtxvBsXXxVhkS2zgSVKhSB+SQ57r1Ih2XgZZa6uYwswRGxNw21fwBFMwvyPeRy9QADkSvDxNZsPbMMkOSzCpzQZaRbHWUrstBeReYQxLhq/tLer+ZIo8ZCL2Y9tXUNzlHP4NIEAxYje++UafTvG972zaFdb5zNU5nn84Z6YkFH3ZgAZfYxr05wyXF9409g74j9EG4PpHXUwqqR3vkznoewHjcYkJsvJkHm1lMV2lD5s1pBLx7ibd4BKlh4FKByD4eeuBfNsbkb1RneCjP4q8t90pVHBFpCf7FtKtQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=t/4IBH4iEoPTPGnuH8hPRKJPlyZC4VQgYPDQvWzSkcE=;\n b=N1doJaEZbWhm0dYHvoiAoB+R6nsKsB/W6u80lugiT6YpeUVqshZeB1MjaAI4CKA7jELZFgD9M7NCTlO4k0s4w198mYCsa9sGwYsuok+kdC7PZStTmcJNxZwkPf5FnDPycDdRaFEbFDCD1Qhsm4yv1sD3/5OsC5P0WwOHCvQg0DFbeg0U09saC5lTzZ3adchUH0gZajHti2FUaksjD0jkbvvBrBz5vjI6N4rHRA+7Xw8lVecf6BlGtumu97qGcgc/oSBI161S5FZQ+EBBOIYghn/MoNoRSpQPEcNtmYsx5TP3Gx9XimBMWEj+UK17n50bN2kUOCImIpqk1UvYJwmc5Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.36) smtp.rcpttodomain=ovn.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=t/4IBH4iEoPTPGnuH8hPRKJPlyZC4VQgYPDQvWzSkcE=;\n b=gOc2Ug/RfdS+iaop84dNk0uhAy5IYyxN+1dgQom8VuzwGFVLLi8wbSyRZYEufZXPgnLAMKmDLo4buGikE0OLkVbEQ+ZiRPeuBD52QRy70nXxy4M66GkmxW5KykmDcAUh/sp40TLt+2ne/d+9CUwd0WBPO7B+4AAhc1+++qUXA/V51OzH+0I2b9wZXfqW6SvK8nGd9JzHAeXJu4ZsqpLm3FIRYlX92uXZwD/uKVWzlWsbWuMIwUCTLN9J38xjo0kmf+ymN4AJ8ZcdTWTkIla+E4FZZc1QSCKzL3vhMtHG6c6b3Vhzvbqp1UwlRp+B5WguTaEDDuFR/gmq2ULJaZXt6g==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.36)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.36 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.36; helo=mail.nvidia.com;", "To": "<dev@openvswitch.org>", "Date": "Mon, 15 Nov 2021 10:53:04 +0800", "Message-ID": "<20211115025312.786953-1-cmi@nvidia.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "15dd0550-577a-4157-9b5c-08d9a7e31354", "X-MS-TrafficTypeDiagnostic": "DM6PR12MB3369:", "X-Microsoft-Antispam-PRVS": "\n <DM6PR12MB336967DF641D18B497510BBECF989@DM6PR12MB3369.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:6430;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 50BuHgHWYos0lSE9dpFofUb/VNiUs8Uc6anxqeZvs3ct9Q6lt2RXloktMqf6aTiy58kZsyjg58Dm6m/t+sskKCJXsTDKg7M50BeAW1L3qRFbEJuCwjPpofvH4HvNKDJS6u5t7Wr6RPXl2eaXIiEEJ3bUMGkDgQqpeAG3gw7lmyEInJLcT6O+oNbcxVbcSIeQVB+igQk7AK8lX6+SaMHC27t8GAlqSrMWh+8A4IKvMMRgxmB+MgnX/BIoJtNGj3YPYBhdC4HwrUiMxKBDt6mr/Er/dmpdtGsBAQ0Ptdw5UqWk0yWwa/08OwwtLwVplaRcv+9rxWiz3hHSe2AGYD8wSeZGi2KiUlgPlWkAsY8g920Bf1NM++JMTYmkzdi2UmglSJwf4fua35NQg+5M4XyeKFbQR0uBk8CLBqHWNiuADKI8k7kV/QjzRL1uqDMOzOcYeyriuxdbbeXFCfQ2Enb0M9sjsaLBTsPgU6qTJ950QKSIaA2uRUYOAZT035akSoLExHAlj1zvMcnkZPNJDdluz1P+nVx2EtNXuEL5+gfpbeJFRVPMv6EXJAAe/V2VueMCde3BmQrirWH3IgkMgB+e+IDmTMCx5q6f1wXM36iELcujNcpBcVo6Y+fPGycLisiS/O66cNR77136VXrkdERvAg+uHxTZQfPNoGx/l28zH6C2ukYDuXlBwu/q5hRkq1b/g/cPnMv/XH0Zpf/2NmeuNw==", "X-Forefront-Antispam-Report": "CIP:216.228.112.36; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid05.nvidia.com; CAT:NONE;\n SFS:(4636009)(46966006)(36840700001)(426003)(316002)(2616005)(36756003)(356005)(70206006)(70586007)(54906003)(47076005)(6666004)(336012)(86362001)(8936002)(6916009)(36860700001)(4326008)(107886003)(508600001)(5660300002)(186003)(1076003)(7636003)(2906002)(83380400001)(26005)(82310400003)(8676002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "15 Nov 2021 02:53:17.1843 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 15dd0550-577a-4157-9b5c-08d9a7e31354", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.36];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT059.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB3369", "Cc": "elibr@nvidia.com, simon.horman@netronome.com, roniba@nvidia.com,\n i.maximets@ovn.org", "Subject": "[ovs-dev] [PATCH v18 0/8] Add offload support for sFlow", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "From": "Chris Mi via dev <ovs-dev@openvswitch.org>", "Reply-To": "Chris Mi <cmi@nvidia.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "This patch set adds offload support for sFlow.\n\nPsample is a genetlink channel for packet sampling. TC action act_sample\nuses psample to send sampled packets to userspace.\n\nWhen offloading sample action to TC, userspace creates a unique ID to\nmap sFlow action and tunnel info and passes this ID to kernel instead\nof the sFlow info. psample will send this ID and sampled packet to\nuserspace. Using the ID, userspace can recover the sFlow info and send\nsampled packet to the right sFlow monitoring host.\n\nv2-v1:\n- Fix robot errors.\nv3-v2:\n- Remove Gerrit Change-Id.\n- Add patch #9 to fix older kernels build issue.\n- Add travis test result.\nv4-v3:\n- Fix offload issue when sampling rate is 1.\nv5-v4:\n- Move polling thread from ofproto to netdev-offload-tc.\nv6-v5:\n- Rebase.\n- Add GitHub Actions test result.\nv7-v6:\n- Remove Gerrit Change-Id.\n- Fix \"ERROR: Inappropriate spacing around cast\"\nv8-v7\n- Address Eelco Chaudron's comment for patch #11.\nv9-v8\n- Remove sflow_len from struct dpif_sflow_attr.\n- Log a debug message for other userspace actions.\nv10-v9\n- Address Eelco Chaudron's comments on v9.\nv11-v10\n- Fix a bracing error.\nv12-v11\n- Add duplicate sample group id check.\nv13-v12\n- Remove the psample poll thread from netdev-offload-tc and reuse\n ofproto handler thread according to Ilya's new desgin.\n- Add dpif-offload-provider layer according to Eli's suggestion.\nv14-v13\n- Fix a robot error.\nv15-v14\n- Address Eelco Chaudron's comments on v14.\nv16-v15\n- Address Eelco Chaudron's comments on v15.\n- Add two test cases.\nv17-v16\n- Address Eelco Chaudron's comments on v16.\n- Move struct dpif_offload_api from struct dpif_class to struct dpif.\nv18-v17\n- Rename dpif_offload_api to dpif_offload_class.\n- Add init and destroy callbacks in dpif_offload_class. They are called\n when registering dpif_offload_class.\n\nChris Mi (8):\n compat: Add psample and tc sample action defines for older kernels\n ovs-kmod-ctl: Load kernel module psample\n dpif-offload-provider: Introduce dpif-offload-provider layer\n netdev-offload-tc: Introduce group ID management API\n dpif-offload-netlink: Implement dpif-offload-provider API\n ofproto: Introduce API to process sFlow offload packet\n netdev-offload-tc: Add offload support for sFlow\n system-offloads-traffic.at: Add sFlow offload test cases\n\n NEWS | 1 +\n include/linux/automake.mk | 4 +-\n include/linux/psample.h | 62 ++++\n include/linux/tc_act/tc_sample.h | 25 ++\n lib/automake.mk | 4 +\n lib/dpif-netdev.c | 8 +-\n lib/dpif-netlink.c | 4 +-\n lib/dpif-offload-netdev.c | 43 +++\n lib/dpif-offload-netlink.c | 228 +++++++++++++++\n lib/dpif-offload-provider.h | 94 +++++++\n lib/dpif-offload.c | 206 ++++++++++++++\n lib/dpif-provider.h | 10 +-\n lib/dpif.c | 20 +-\n lib/netdev-offload-tc.c | 466 +++++++++++++++++++++++++++++--\n lib/netdev-offload.h | 2 +\n lib/tc.c | 61 +++-\n lib/tc.h | 16 +-\n ofproto/ofproto-dpif-upcall.c | 73 +++++\n tests/system-offloads-traffic.at | 101 +++++++\n utilities/ovs-kmod-ctl.in | 14 +\n 20 files changed, 1410 insertions(+), 32 deletions(-)\n create mode 100644 include/linux/psample.h\n create mode 100644 include/linux/tc_act/tc_sample.h\n create mode 100644 lib/dpif-offload-netdev.c\n create mode 100644 lib/dpif-offload-netlink.c\n create mode 100644 lib/dpif-offload-provider.h\n create mode 100644 lib/dpif-offload.c" }