Cover Letter Detail
Show a cover letter.
GET /api/covers/1549529/?format=api
{ "id": 1549529, "url": "http://patchwork.ozlabs.org/api/covers/1549529/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pwm/cover/20211102092804.296089-1-u.kleine-koenig@pengutronix.de/", "project": { "id": 38, "url": "http://patchwork.ozlabs.org/api/projects/38/?format=api", "name": "Linux PWM development", "link_name": "linux-pwm", "list_id": "linux-pwm.vger.kernel.org", "list_email": "linux-pwm@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211102092804.296089-1-u.kleine-koenig@pengutronix.de>", "list_archive_url": null, "date": "2021-11-02T09:28:02", "name": "[0/2] pwm: vt8500: Implement .apply() callback", "submitter": { "id": 1476, "url": "http://patchwork.ozlabs.org/api/people/1476/?format=api", "name": "Uwe Kleine-König", "email": "u.kleine-koenig@pengutronix.de" }, "mbox": "http://patchwork.ozlabs.org/project/linux-pwm/cover/20211102092804.296089-1-u.kleine-koenig@pengutronix.de/mbox/", "series": [ { "id": 269946, "url": "http://patchwork.ozlabs.org/api/series/269946/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pwm/list/?series=269946", "date": "2021-11-02T09:28:02", "name": "pwm: vt8500: Implement .apply() callback", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/269946/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/1549529/comments/", "headers": { "Return-Path": "<linux-pwm-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=linux-pwm-owner@vger.kernel.org; receiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby bilbo.ozlabs.org (Postfix) with ESMTP id 4Hk4MM5f9vz9sXN\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 2 Nov 2021 20:28:15 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S229869AbhKBJas (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n Tue, 2 Nov 2021 05:30:48 -0400", "from lindbergh.monkeyblade.net ([23.128.96.19]:58020 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S229800AbhKBJas (ORCPT\n <rfc822;linux-pwm@vger.kernel.org>); Tue, 2 Nov 2021 05:30:48 -0400", "from metis.ext.pengutronix.de (metis.ext.pengutronix.de\n [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D605C061714\n for <linux-pwm@vger.kernel.org>; Tue, 2 Nov 2021 02:28:13 -0700 (PDT)", "from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])\n by metis.ext.pengutronix.de with esmtps\n (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.92)\n (envelope-from <ukl@pengutronix.de>)\n id 1mhq5T-00034z-GW; Tue, 02 Nov 2021 10:28:11 +0100", "from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de)\n by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92)\n (envelope-from <ukl@pengutronix.de>)\n id 1mhq5O-0008TI-76; Tue, 02 Nov 2021 10:28:06 +0100", "from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92)\n (envelope-from <ukl@pengutronix.de>)\n id 1mhq5O-0005HR-65; Tue, 02 Nov 2021 10:28:06 +0100" ], "From": "=?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>", "To": "Thierry Reding <thierry.reding@gmail.com>,\n Lee Jones <lee.jones@linaro.org>", "Cc": "linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,\n Tony Prisk <linux@prisktech.co.nz>", "Subject": "[PATCH 0/2] pwm: vt8500: Implement .apply() callback", "Date": "Tue, 2 Nov 2021 10:28:02 +0100", "Message-Id": "<20211102092804.296089-1-u.kleine-koenig@pengutronix.de>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-SA-Exim-Connect-IP": "2a0a:edc0:0:c01:1d::a2", "X-SA-Exim-Mail-From": "ukl@pengutronix.de", "X-SA-Exim-Scanned": "No (on metis.ext.pengutronix.de);\n SAEximRunCond expanded to false", "X-PTX-Original-Recipient": "linux-pwm@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pwm.vger.kernel.org>", "X-Mailing-List": "linux-pwm@vger.kernel.org" }, "content": "Hello,\n\nthis series implements .apply for the vt8500 pwm driver and fixes a\nfunction name that I stumbled over while doing that.\n\nOne thing that could be improved (but probably only with hardware\navailable which I don't have) is:\n\n - vt8500_pwm_apply() calls the old callbacks now, it might be possible\n to improve clk handling such that the clk is at most once enabled and\n once disabled.\n\n - .probe() doesn't handle the PWM already being on.\n\n - There is no .get_state() callback.\n\nBest regards\nUwe\n\nUwe Kleine-König (2):\n pwm: vt8500: Implement .apply() callback\n pwm: vt8500: Rename pwm_busy_wait() to make it obviously\n driver-specific\n\n drivers/pwm/pwm-vt8500.c | 73 +++++++++++++++++++++++++++++++---------\n 1 file changed, 58 insertions(+), 15 deletions(-)\n\n\nbase-commit: 8bb7eca972ad531c9b149c0a51ab43a417385813" }