Cover Letter Detail
Show a cover letter.
GET /api/covers/1526136/?format=api
{ "id": 1526136, "url": "http://patchwork.ozlabs.org/api/covers/1526136/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pwm/cover/20210909094849.313936-1-u.kleine-koenig@pengutronix.de/", "project": { "id": 38, "url": "http://patchwork.ozlabs.org/api/projects/38/?format=api", "name": "Linux PWM development", "link_name": "linux-pwm", "list_id": "linux-pwm.vger.kernel.org", "list_email": "linux-pwm@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210909094849.313936-1-u.kleine-koenig@pengutronix.de>", "list_archive_url": null, "date": "2021-09-09T09:48:47", "name": "[0/2] pwm: add might_sleep annotations", "submitter": { "id": 1476, "url": "http://patchwork.ozlabs.org/api/people/1476/?format=api", "name": "Uwe Kleine-König", "email": "u.kleine-koenig@pengutronix.de" }, "mbox": "http://patchwork.ozlabs.org/project/linux-pwm/cover/20210909094849.313936-1-u.kleine-koenig@pengutronix.de/mbox/", "series": [ { "id": 261585, "url": "http://patchwork.ozlabs.org/api/series/261585/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pwm/list/?series=261585", "date": "2021-09-09T09:48:47", "name": "pwm: add might_sleep annotations", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/261585/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/1526136/comments/", "headers": { "Return-Path": "<linux-pwm-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=linux-pwm-owner@vger.kernel.org; receiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 4H4vND0jzjz9sXk\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 9 Sep 2021 19:49:00 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S233242AbhIIJuI (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n Thu, 9 Sep 2021 05:50:08 -0400", "from lindbergh.monkeyblade.net ([23.128.96.19]:38482 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S231793AbhIIJuG (ORCPT\n <rfc822;linux-pwm@vger.kernel.org>); Thu, 9 Sep 2021 05:50:06 -0400", "from metis.ext.pengutronix.de (metis.ext.pengutronix.de\n [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7844BC061575\n for <linux-pwm@vger.kernel.org>; Thu, 9 Sep 2021 02:48:57 -0700 (PDT)", "from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])\n by metis.ext.pengutronix.de with esmtps\n (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.92)\n (envelope-from <ukl@pengutronix.de>)\n id 1mOGfv-0000GQ-DX; Thu, 09 Sep 2021 11:48:55 +0200", "from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de)\n by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92)\n (envelope-from <ukl@pengutronix.de>)\n id 1mOGft-0007fP-K6; Thu, 09 Sep 2021 11:48:53 +0200", "from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92)\n (envelope-from <ukl@pengutronix.de>)\n id 1mOGft-0005mw-It; Thu, 09 Sep 2021 11:48:53 +0200" ], "From": "=?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>", "To": "Thierry Reding <thierry.reding@gmail.com>,\n Lee Jones <lee.jones@linaro.org>", "Cc": "linux-pwm@vger.kernel.org, kernel@pengutronix.de, =?utf-8?q?M=C3=A5rten_?=\n\t=?utf-8?q?Lindahl?= <marten.lindahl@axis.com>", "Subject": "[PATCH 0/2] pwm: add might_sleep annotations", "Date": "Thu, 9 Sep 2021 11:48:47 +0200", "Message-Id": "<20210909094849.313936-1-u.kleine-koenig@pengutronix.de>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-SA-Exim-Connect-IP": "2a0a:edc0:0:c01:1d::a2", "X-SA-Exim-Mail-From": "ukl@pengutronix.de", "X-SA-Exim-Scanned": "No (on metis.ext.pengutronix.de);\n SAEximRunCond expanded to false", "X-PTX-Original-Recipient": "linux-pwm@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pwm.vger.kernel.org>", "X-Mailing-List": "linux-pwm@vger.kernel.org" }, "content": "Hello,\n\nearlier today I noticed that the samsung PWM driver uses\nspin_lock_irqsave() which made me wonder if the PWM functions are used\nin atomic context at all. To find out I suggest adding a might_sleep()\nand look if anyone complains.\n\nThe first patch should be indisputable, if you know a valid atomic use\ncase for pwm_apply_state, please speak up (which would make the second\npatch wrong).\n\nBest regards\nUwe\n\nUwe Kleine-König (2):\n pwm: Add might_sleep() annotations for !CONFIG_PWM API functions\n pwm: Make it explicit that pwm_apply_state() might sleep\n\n drivers/pwm/core.c | 9 +++++++++\n include/linux/pwm.h | 13 +++++++++++++\n 2 files changed, 22 insertions(+)\n\n\nbase-commit: 3f2b16734914fa7c53ef7f8a10a63828890dbd37" }