Cover Letter Detail
Show a cover letter.
GET /api/covers/1524285/?format=api
{ "id": 1524285, "url": "http://patchwork.ozlabs.org/api/covers/1524285/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/cover/20210903122148.826196-1-mark.d.gray@redhat.com/", "project": { "id": 68, "url": "http://patchwork.ozlabs.org/api/projects/68/?format=api", "name": "Open Virtual Network development", "link_name": "ovn", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210903122148.826196-1-mark.d.gray@redhat.com>", "list_archive_url": null, "date": "2021-09-03T12:21:41", "name": "[ovs-dev,v4,0/7] northd: Split northd and northd incremental processing framework", "submitter": { "id": 79963, "url": "http://patchwork.ozlabs.org/api/people/79963/?format=api", "name": "Mark Gray", "email": "mark.d.gray@redhat.com" }, "mbox": "http://patchwork.ozlabs.org/project/ovn/cover/20210903122148.826196-1-mark.d.gray@redhat.com/mbox/", "series": [ { "id": 260884, "url": "http://patchwork.ozlabs.org/api/series/260884/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/list/?series=260884", "date": "2021-09-03T12:21:41", "name": "northd: Split northd and northd incremental processing framework", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/260884/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/1524285/comments/", "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=J0O1mGiI;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.133; helo=smtp2.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "smtp3.osuosl.org (amavisd-new);\n dkim=pass (1024-bit key) header.d=redhat.com", "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mark.d.gray@redhat.com" ], "Received": [ "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4H1H3Y6J5yz9sf8\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 3 Sep 2021 22:22:01 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp2.osuosl.org (Postfix) with ESMTP id BE19A407CE;\n\tFri, 3 Sep 2021 12:21:59 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n\tby localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2dK1J_XZap9e; Fri, 3 Sep 2021 12:21:58 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp2.osuosl.org (Postfix) with ESMTPS id 72526407BA;\n\tFri, 3 Sep 2021 12:21:57 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 3B79BC0010;\n\tFri, 3 Sep 2021 12:21:57 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 6151AC000E\n for <dev@openvswitch.org>; Fri, 3 Sep 2021 12:21:55 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 3D6386074A\n for <dev@openvswitch.org>; Fri, 3 Sep 2021 12:21:55 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id LDFXMW47Pn5H for <dev@openvswitch.org>;\n Fri, 3 Sep 2021 12:21:54 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 69E8960625\n for <dev@openvswitch.org>; Fri, 3 Sep 2021 12:21:54 +0000 (UTC)", "from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-564-SpRTeobiMWSbpBNi4L9d8A-1; Fri, 03 Sep 2021 08:21:52 -0400", "by mail-wm1-f70.google.com with SMTP id\n n16-20020a1c7210000000b002ea2ed60dc6so1779121wmc.0\n for <dev@openvswitch.org>; Fri, 03 Sep 2021 05:21:52 -0700 (PDT)", "from wsfd-netdev91.ntdv.lab.eng.bos.redhat.com\n (nat-pool-bos-t.redhat.com. [66.187.233.206])\n by smtp.gmail.com with ESMTPSA id a6sm4836612wrh.97.2021.09.03.05.21.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 03 Sep 2021 05:21:50 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.8.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1630671713;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=BlqHpIGor9uBnWWx701Ootzs+oeDA938NCMXla9InbY=;\n b=J0O1mGiIGPHAcXcljH0VAoV+GJKpL8nrT7cBIH7ctVRzccu+f+5IaCQS/AUUyRzFFfajh3\n Wd4OIIh+BB447KV+rD48a1x0I3N6L6bq98QGKnnecANSzpJN6CiFX3OqmI0b/O4grrTsxI\n FcVpK1Gw7ZTepFNkTI5OvK5eLWBeQRw=", "X-MC-Unique": "SpRTeobiMWSbpBNi4L9d8A-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=BhQSqPw2piN27kzO8+Lb3buuzzxoGd1tGWp2G14Yp0g=;\n b=Grl1iZyH1FXcemmlYJssrOhSlJfzQOCrWdTLHNh7rVdHE0eFb/EWyfbhGvJD6Yocli\n N6+X9bruUKkym/y6KN+L6yqDonypHldISL7iBJN7XuB69NHRt/r1qVCAw87loSpeZ9+a\n onWb8tIDhenGh8haDzJtQlKw2l4kbd8Ku9uicUbDJwhNyCrlhpf7rCyB7wnm9EdBEoDj\n MkcEeATNriKRgOGMgq5sT84owPkrBeC8FimjpaQUyOB+4HsnKbqDEV6YFvZ+eeGZmh7x\n sooV2tUdUuxldQVYCha+er0i98SbHyM/OtgZ/yL9AsCRpmZi1KaFWhQvmDF82E/K/yzm\n YVow==", "X-Gm-Message-State": "AOAM531lHf2HlMp47UYb0QQ48fhI4OGGDza8w9r56qitKVW7oq5a6g2U\n kRIPVsx1qTr97DIJeoFtUZHe3ReE7AxqTVu52BkXwhhVX45FvlZcjYBHFPBlaL+3CCCnHuvrj7Z\n 9ujX+LXvpFAtcUGIZ3MM1dCZUBEPvFxNubI1nP9Nfxs2pm0eQhLswQBW+CrljLuHCbNPc", "X-Received": [ "by 2002:a05:600c:206:: with SMTP id\n 6mr8057108wmi.178.1630671711068;\n Fri, 03 Sep 2021 05:21:51 -0700 (PDT)", "by 2002:a05:600c:206:: with SMTP id\n 6mr8057084wmi.178.1630671710732;\n Fri, 03 Sep 2021 05:21:50 -0700 (PDT)" ], "X-Google-Smtp-Source": "\n ABdhPJx7kDE0DE+LZKoSF4kRt6dtEElfhO3fSxr8lqlZgfIUO7ZHMn/MHG2JRnv/r6TX+1fPHKEJgQ==", "From": "Mark Gray <mark.d.gray@redhat.com>", "To": "dev@openvswitch.org", "Date": "Fri, 3 Sep 2021 08:21:41 -0400", "Message-Id": "<20210903122148.826196-1-mark.d.gray@redhat.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Cc": "numans@redhat.com", "Subject": "[ovs-dev] [PATCH ovn v4 0/7] northd: Split northd and northd\n incremental processing framework", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "Part 1:\nThe first two comits deal with reorganising the northd code base a little.\nPlease note that this commit mainly involves moving code around with minimal\ncode changes. However, due to tight coupling between ovn-northd.c and northd.c,\nsome minor changes were needed. For reference, and to help reviews, please\nexamine the following at a minimum:\n\n* Configuration of the probe interval in northd.c (ovsdb_idl_set_probe_interval())\n* Passing of \"use_parallel_build\" and \"lflow_locks\" from ovn-northd.c and\n northd.c.\n* Update of \"struct northd_context\": additon of fields and move to h file.\n\nThe commits were (hopefully) structured in a way to make the review easier. As\nthis change touches all of ovn-northd, any change to \"master\" will make a rebase\nnecessary and probably difficult. Therefore, if the general ideas is OK, then\nit would be great if this series could be expedited to prevent many rebases!\n\nPart 2:\nThe remaining commits add the inc-proc-eng framework to northd. This does *not*\nadd any incremental processing of northd processing at this stage but provides the\nframework. Even in this base configuration, we see an advantage as northd no longer\nprocesses the databases if it has been woken up only to handle, for example, a\nunixctl command. This can be seen below:\n\n$ ovn-appctl -t ovn-northd stopwatch/reset\n$ for i in {1..10}; do ovn-appctl -t ovn-northd stopwatch/show >/dev/null; done\n$ ovn-appctl -t ovn-northd stopwatch/show ovnnb_db_run\nStatistics for 'ovnnb_db_run'\n Total samples: 0\n Maximum: 0 msec\n Minimum: 0 msec\n 95th percentile: 0.000000 msec\n Short term average: 0.000000 msec\n Long term average: 0.000000 msec\n\nHopefully this starting point will allow others to discuss or contribute changes to\nincrementally process some aspects of northd. We can also decide if it is worth\nprogressing with \"Part 2\" if we think there are potential benefits until we start\nseeing the benefits of DDlog.\n\nThanks\n\n---\nv2: Rebase\nv3: Rebase. Fixed compile-time error\nv4: Add additional commits which add framework for incremental processing in northd\n\nMark Gray (7):\n ovn-northd: Rename ovn-northd.c to northd.c\n northd: Split northd.c\n inc-proc-eng: Allow definition of engine_node with global scope\n northd: Introduce incremental processing for northd\n northd: Add n_nat_entries field to 'struct ovn_datapath'\n northd: Add runtime node\n northd: Add functionality to runtime node\n\n Documentation/tutorials/ovn-openstack.rst | 154 +-\n controller/ovn-controller.c | 2 +-\n lib/inc-proc-eng.h | 24 +-\n northd/automake.mk | 8 +\n northd/en-northd.c | 52 +\n northd/en-northd.h | 17 +\n northd/en-runtime.c | 66 +\n northd/en-runtime.h | 25 +\n northd/inc-proc-northd.c | 258 +\n northd/inc-proc-northd.h | 15 +\n northd/lrouter.dl | 2 +-\n northd/northd.c | 14568 +++++++++++++++++++\n northd/northd.h | 45 +\n northd/ovn-northd.c | 15084 +-------------------\n northd/ovn.rs | 2 +-\n northd/ovn_northd.dl | 2 +-\n tests/ovn-northd.at | 2 +-\n 17 files changed, 15454 insertions(+), 14872 deletions(-)\n create mode 100644 northd/en-northd.c\n create mode 100644 northd/en-northd.h\n create mode 100644 northd/en-runtime.c\n create mode 100644 northd/en-runtime.h\n create mode 100644 northd/inc-proc-northd.c\n create mode 100644 northd/inc-proc-northd.h\n create mode 100644 northd/northd.c\n create mode 100644 northd/northd.h" }