Cover Letter Detail
Show a cover letter.
GET /api/covers/1409791/?format=api
{ "id": 1409791, "url": "http://patchwork.ozlabs.org/api/covers/1409791/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20201202152611.677753-1-stefanha@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20201202152611.677753-1-stefanha@redhat.com>", "list_archive_url": null, "date": "2020-12-02T15:26:07", "name": "[v2,0/4] vhost-user: avoid g_return_val_if() in get/set_config()", "submitter": { "id": 17227, "url": "http://patchwork.ozlabs.org/api/people/17227/?format=api", "name": "Stefan Hajnoczi", "email": "stefanha@redhat.com" }, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20201202152611.677753-1-stefanha@redhat.com/mbox/", "series": [ { "id": 218104, "url": "http://patchwork.ozlabs.org/api/series/218104/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=218104", "date": "2020-12-02T15:26:07", "name": "vhost-user: avoid g_return_val_if() in get/set_config()", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/218104/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/1409791/comments/", "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=redhat.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KvYCE/YY;\n\tdkim-atps=neutral", "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4CmNBV3dbZz9sRK\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 3 Dec 2020 02:27:30 +1100 (AEDT)", "from localhost ([::1]:46664 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1kkU2R-0005RW-IL\n\tfor incoming@patchwork.ozlabs.org; Wed, 02 Dec 2020 10:27:27 -0500", "from eggs.gnu.org ([2001:470:142:3::10]:50764)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <stefanha@redhat.com>)\n id 1kkU1j-0005Ng-I5\n for qemu-devel@nongnu.org; Wed, 02 Dec 2020 10:26:47 -0500", "from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40979)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from <stefanha@redhat.com>)\n id 1kkU1d-0003rR-6J\n for qemu-devel@nongnu.org; Wed, 02 Dec 2020 10:26:43 -0500", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-449-a08YDVjLMhWAY9_GigSmMA-1; Wed, 02 Dec 2020 10:26:30 -0500", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com\n [10.5.11.15])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 79BB6184215E;\n Wed, 2 Dec 2020 15:26:28 +0000 (UTC)", "from localhost (ovpn-114-255.ams2.redhat.com [10.36.114.255])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 92C075D6BA;\n Wed, 2 Dec 2020 15:26:12 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1606922791;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=Fah5uFDQbyz4KSDKjNmz9PBQ5GHzfnym0PucUg5yQ2I=;\n b=KvYCE/YYp3+rFpA6BtKH80fBmunLLZA5gNzzzOV5m1OxdLIXWE5gjrs9YF0cGUJBncoHil\n vLmdc5GR0fHTvEm0Ht9lSWu6LnJV5iGUMbiTqA90f/Stz5QNzOWgtxnQigAcOW+AftpMk4\n /jxdvz0T2WnZgJqwe80dQSFepalvEmk=", "X-MC-Unique": "a08YDVjLMhWAY9_GigSmMA-1", "From": "Stefan Hajnoczi <stefanha@redhat.com>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH v2 0/4] vhost-user: avoid g_return_val_if() in\n get/set_config()", "Date": "Wed, 2 Dec 2020 15:26:07 +0000", "Message-Id": "<20201202152611.677753-1-stefanha@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Received-SPF": "pass client-ip=216.205.24.124;\n envelope-from=stefanha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-35", "X-Spam_score": "-3.6", "X-Spam_bar": "---", "X-Spam_report": "(-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org,\n \"Michael S. Tsirkin\" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>,\n Coiby Xu <Coiby.Xu@gmail.com>, Raphael Norwitz <raphael.norwitz@nutanix.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@gmail.com>,\n Gerd Hoffmann <kraxel@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Max Reitz <mreitz@redhat.com>, Stefano Garzarella <sgarzare@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "v2:\n * Print errors [Marc-André]\n\nMarkus Armbruster pointed out that g_return_val_if() is meant for programming\nerrors. It must not be used for input validation since it can be compiled out.\nUse explicit if statements instead.\n\nThis patch series converts vhost-user device backends that use\ng_return_val_if() in get/set_config().\n\nStefan Hajnoczi (4):\n contrib/vhost-user-blk: avoid g_return_val_if() input validation\n contrib/vhost-user-gpu: avoid g_return_val_if() input validation\n contrib/vhost-user-input: avoid g_return_val_if() input validation\n block/export: avoid g_return_val_if() input validation\n\n block/export/vhost-user-blk-server.c | 6 +++++-\n contrib/vhost-user-blk/vhost-user-blk.c | 6 +++++-\n contrib/vhost-user-gpu/vhost-user-gpu.c | 6 +++++-\n contrib/vhost-user-input/main.c | 6 +++++-\n 4 files changed, 20 insertions(+), 4 deletions(-)" }