Cover Letter Detail
Show a cover letter.
GET /api/covers/1314622/?format=api
{ "id": 1314622, "url": "http://patchwork.ozlabs.org/api/covers/1314622/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20200622100056.10151-1-brgl@bgdev.pl/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200622100056.10151-1-brgl@bgdev.pl>", "list_archive_url": null, "date": "2020-06-22T10:00:45", "name": "[00/11] net: improve devres helpers", "submitter": { "id": 71346, "url": "http://patchwork.ozlabs.org/api/people/71346/?format=api", "name": "Bartosz Golaszewski", "email": "brgl@bgdev.pl" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20200622100056.10151-1-brgl@bgdev.pl/mbox/", "series": [ { "id": 185056, "url": "http://patchwork.ozlabs.org/api/series/185056/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=185056", "date": "2020-06-22T10:00:52", "name": "net: improve devres helpers", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/185056/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/1314622/comments/", "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=none (p=none dis=none) header.from=bgdev.pl", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bgdev-pl.20150623.gappssmtp.com\n header.i=@bgdev-pl.20150623.gappssmtp.com header.a=rsa-sha256\n header.s=20150623 header.b=rxCKkG6S;\n\tdkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49rFh31Ypqz9sSS\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 23 Jun 2020 02:47:31 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5EB128647E;\n\tMon, 22 Jun 2020 16:47:29 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MCOZkTIblzvG; Mon, 22 Jun 2020 16:47:28 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 88DDE8634C;\n\tMon, 22 Jun 2020 16:47:27 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by ash.osuosl.org (Postfix) with ESMTP id 0EF2A1BF3C8\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:08:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by hemlock.osuosl.org (Postfix) with ESMTP id 07AB0891B8\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:08:20 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id 0L+wFjV0UCnh for <intel-wired-lan@lists.osuosl.org>;\n Mon, 22 Jun 2020 10:08:19 +0000 (UTC)", "from mail-wm1-f65.google.com (mail-wm1-f65.google.com\n [209.85.128.65])\n by hemlock.osuosl.org (Postfix) with ESMTPS id CEB2C891C1\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:08:18 +0000 (UTC)", "by mail-wm1-f65.google.com with SMTP id j18so738115wmi.3\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 03:08:18 -0700 (PDT)", "from localhost.localdomain (lfbn-nic-1-65-232.w2-15.abo.wanadoo.fr.\n [2.15.156.232])\n by smtp.gmail.com with ESMTPSA id x205sm16822187wmx.21.2020.06.22.03.01.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 22 Jun 2020 03:01:04 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bgdev-pl.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=0a5wnHY7CslRA6Iynsfhb3yG1izm8FY/pWdetFoi42c=;\n b=rxCKkG6SfwCZOTa1iL5Lojz3NDEQwyb2IxWpdYBFS7nvwaSmH3nUs6LKzmpIqO9fmz\n T0E4/NHNhWS1FxOj6Knq7vaDIfED18iz4zDTKFADfGdZ87o9VBNoHn9xKkFZ5ABiLuMo\n spikJGn8iabnLkYyJ4CKFueyLxhkCPXnn+tT0IIM62ri0cxtQBzPXWPE2OKAi+/WB4Hb\n Zm7iXcDn1Km9OIDru3YUscj0Ip3rFJhgBzUhsF68MWUFQB29eaTMLMdCy2o5sHrQdX4O\n +4gvt10n83RfLFmg67wO7WMqC6KCkbs7hPXvMxFl4ifmIlhRhWH6of7y0Q6ilwx8joXN\n aa9A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=0a5wnHY7CslRA6Iynsfhb3yG1izm8FY/pWdetFoi42c=;\n b=Ek3owpuLpDUDrjHnhvgzrLrQyz7MWC9RjjuxAB1S6fAuItbu24rt4J0ienycGFqCrD\n xUzok3FWrrFW/tLc2z5Vc6Zr8cIxQ62SfeOMH/1pXFUTYRAOvspyX9jIlAY1emcDiQgj\n +LPmEqkz3UDvr+gsmtGl8UeR1VfJteNyz2azccfsRrlrEmGyJyfgKjaa0xfVH0PqU8ok\n s6eDQIBam4U6gqgiVUMgLA3VjnZWbfZIZ159dp0vCDUGk+H056QFrDCmT9bOFU43ukqV\n 5k1URC23p2ywK8AXhaI3uEaDdE/buORX8/IIle1FYbu2j6cF+C0hDJj9kbUBD0Bm4TEF\n vUIg==", "X-Gm-Message-State": "AOAM531UA70E0EPTblrAJA9/tX/4zkticnwT5E4HzL+n+cvFnhoxnUTN\n v5t367YdC4nT6NVmmGVRnd5XsKOC+48=", "X-Google-Smtp-Source": "\n ABdhPJwltFZXM/3VYa9tIy2MbCHj//CBC2paauuUY5AwGyYeKiWa1AZvShK5hzeRuXlvCn791GVruA==", "X-Received": "by 2002:a1c:c1:: with SMTP id 184mr17443220wma.74.1592820065387;\n Mon, 22 Jun 2020 03:01:05 -0700 (PDT)", "From": "Bartosz Golaszewski <brgl@bgdev.pl>", "To": "Jonathan Corbet <corbet@lwn.net>,\n Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n \"David S . Miller\" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,\n John Crispin <john@phrozen.org>, Sean Wang <sean.wang@mediatek.com>,\n Mark Lee <Mark-MC.Lee@mediatek.com>,\n Matthias Brugger <matthias.bgg@gmail.com>,\n Realtek linux nic maintainers <nic_swsd@realtek.com>,\n Heiner Kallweit <hkallweit1@gmail.com>, Andrew Lunn <andrew@lunn.ch>,\n Florian Fainelli <f.fainelli@gmail.com>,\n Russell King <linux@armlinux.org.uk>, Rob Herring <robh+dt@kernel.org>,\n Frank Rowand <frowand.list@gmail.com>", "Date": "Mon, 22 Jun 2020 12:00:45 +0200", "Message-Id": "<20200622100056.10151-1-brgl@bgdev.pl>", "X-Mailer": "git-send-email 2.26.1", "MIME-Version": "1.0", "X-Mailman-Approved-At": "Mon, 22 Jun 2020 16:47:24 +0000", "Subject": "[Intel-wired-lan] [PATCH 00/11] net: improve devres helpers", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "devicetree@vger.kernel.org,\n Bartosz Golaszewski <bgolaszewski@baylibre.com>,\n Stephane Le Provost <stephane.leprovost@mediatek.com>,\n linux-doc@vger.kernel.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, Fabien Parent <fparent@baylibre.com>,\n linux-mediatek@lists.infradead.org,\n Andrew Perepech <andrew.perepech@mediatek.com>,\n Pedro Tsai <pedro.tsai@mediatek.com>, intel-wired-lan@lists.osuosl.org,\n linux-arm-kernel@lists.infradead.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Bartosz Golaszewski <bgolaszewski@baylibre.com>\n\nWhen I first submitted the series adding devm_register_netdev() I was\ntold during review that it should check if the underlying struct net_device\nis managed too before proceeding. I initially accepted this as the right\napproach but in the back of my head something seemed wrong about this.\nI started looking around and noticed how devm_mdiobus_register()\nis implemented.\n\nIt turned out that struct mii_bus contains information about whether it's\nmanaged or not and the release callback of devm_mdiobus_alloc() is responsible\nfor calling mdiobus_unregister(). This seems wrong to me as managed structures\nshouldn't care about who manages them. It's devres' code task to correctly undo\nwhatever it registers/allocates.\n\nWith this series I propose to make the release callbacks of mdiobus devm\nhelpers only release the resources they actually allocate themselves as it the\nstandard in devm routines. I also propose to not check whether the structures\npassed to devm_mdiobus_register() and devm_register_netdev() are already\nmanaged as they could have been allocated over devres as part of bigger\nmemory chunk. I see this as an unnecessary limitation.\n\nFirst two patches aim at removing the only use of devm_mdiobus_free(). It\nmodifies the ixgbe driver. I only compile tested it as I don't have the\nrelevant hw.\n\nNext two patches relax devm_register_netdev() - we stop checking whether\nstruct net_device was registered using devm_etherdev_alloc().\n\nWe then document the mdio devres helper that's missing in devres.rst list\nand un-inline the current implementation of devm_mdiobus_register().\n\nPatch 8 re-implements the devres helpers for mdio conforming to common\ndevres patterns.\n\nPatches 9 and 10 provide devm_of_mdiobus_register() and the last patch\nadds its first user.\n\nBartosz Golaszewski (11):\n net: ethernet: ixgbe: check the return value of ixgbe_mii_bus_init()\n net: ethernet: ixgbe: don't call devm_mdiobus_free()\n net: devres: relax devm_register_netdev()\n net: devres: rename the release callback of devm_register_netdev()\n Documentation: devres: add missing mdio helper\n phy: un-inline devm_mdiobus_register()\n phy: mdio: add kerneldoc for __devm_mdiobus_register()\n net: phy: don't abuse devres in devm_mdiobus_register()\n of: mdio: remove the 'extern' keyword from function declarations\n of: mdio: provide devm_of_mdiobus_register()\n net: ethernet: mtk-star-emac: use devm_of_mdiobus_register()\n\n .../driver-api/driver-model/devres.rst | 3 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 14 +---\n drivers/net/ethernet/mediatek/mtk_star_emac.c | 13 +--\n drivers/net/ethernet/realtek/r8169_main.c | 2 +-\n drivers/net/phy/Makefile | 2 +-\n drivers/net/phy/mdio_bus.c | 73 ----------------\n drivers/net/phy/mdio_devres.c | 83 +++++++++++++++++++\n drivers/of/of_mdio.c | 43 ++++++++++\n include/linux/of_mdio.h | 40 ++++-----\n include/linux/phy.h | 21 +----\n net/devres.c | 23 +----\n 12 files changed, 167 insertions(+), 156 deletions(-)\n create mode 100644 drivers/net/phy/mdio_devres.c" }