Cover Letter Detail
Show a cover letter.
GET /api/covers/1261079/?format=api
{ "id": 1261079, "url": "http://patchwork.ozlabs.org/api/covers/1261079/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20200325003824.5487-1-andre.guedes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200325003824.5487-1-andre.guedes@intel.com>", "list_archive_url": null, "date": "2020-03-25T00:38:14", "name": "[00/10] igc: Align log messages", "submitter": { "id": 72323, "url": "http://patchwork.ozlabs.org/api/people/72323/?format=api", "name": "Andre Guedes", "email": "andre.guedes@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20200325003824.5487-1-andre.guedes@intel.com/mbox/", "series": [ { "id": 166478, "url": "http://patchwork.ozlabs.org/api/series/166478/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=166478", "date": "2020-03-25T00:38:14", "name": "igc: Align log messages", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/166478/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/1261079/comments/", "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48n8PC5q4Vz9sR4\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 25 Mar 2020 11:38:39 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 595398855E;\n\tWed, 25 Mar 2020 00:38:38 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0ouFh8ZS+y69; Wed, 25 Mar 2020 00:38:37 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 17AD8884D9;\n\tWed, 25 Mar 2020 00:38:37 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id F31E01BF32A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:35 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 08F7F23B44\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:35 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id T5qySmkbosmE for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:34 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 0D6D8235B8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:34 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t24 Mar 2020 17:38:33 -0700", "from johnorte-mobl2.amr.corp.intel.com ([10.251.10.249])\n\tby fmsmga006.fm.intel.com with ESMTP; 24 Mar 2020 17:38:32 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "60MYFhrFcV/Uznnf4BwKDxfN1BcYKW3K7KJqJnx3pGG9RObkdps/N0gPCiQ/+tOqhitNGLSF4S\n\tF7T/g+WxmuCg==", "DgbsVYz1OLzRLyvOBrdCYbijYpUMyjG9SgkCttTuIotPBtG9hje6Yc2yxsyCfEx+Lyhgaug7k4\n\tFeFHYkvZvmpg==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,302,1580803200\"; d=\"scan'208\";a=\"448099329\"", "From": "Andre Guedes <andre.guedes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 24 Mar 2020 17:38:14 -0700", "Message-Id": "<20200325003824.5487-1-andre.guedes@intel.com>", "X-Mailer": "git-send-email 2.25.0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 00/10] igc: Align log messages", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Throughout IGC code we print log messages using different log helpers such as\ndev_*, pr_*, and netdev_*, generating inconsistent output.\n\nSince this is a network device driver, we should preferably use netdev_*\nhelpers because they append the interface name to the message, helping making\nsense out of the logs especially when we have more than one adapter in the\nsystem.\n\nThis patchset converts all dev_* and pr_* calls to netdev_*. There are just a\nfew exceptions that cannot be converted because we don't have the netdev\nallocated yet (e.g. when the module is loaded and on PCI probe). It also takes\nthe opportunity to improve some messages and remove the '\\n' character at the\nend of them since is it automatically added to by netdev_* log helpers.\n\nRegards,\n\nAndre\n\nAndre Guedes (10):\n igc: Use netdev log helpers in igc_main.c\n igc: Use netdev log helpers in igc_ethtool.c\n igc: Use netdev log helpers in igc_ptp.c\n igc: Use netdev log helpers in igc_dump.c\n igc: Use netdev log helpers in igc_base.c\n igc: Use netdev log helpers in igc_diag.c\n igc: Remove '\\n' from log strings in igc_i225.c\n igc: Remove '\\n' from log strings in igc_mac.c\n igc: Remove '\\n' from log messages in igc_nvm.c\n igc: Remove '\\n' from log strings in igc_phy.c\n\n drivers/net/ethernet/intel/igc/igc_base.c | 16 +--\n drivers/net/ethernet/intel/igc/igc_diag.c | 22 ++--\n drivers/net/ethernet/intel/igc/igc_dump.c | 109 ++++++++--------\n drivers/net/ethernet/intel/igc/igc_ethtool.c | 48 ++++---\n drivers/net/ethernet/intel/igc/igc_i225.c | 22 ++--\n drivers/net/ethernet/intel/igc/igc_mac.c | 42 +++---\n drivers/net/ethernet/intel/igc/igc_main.c | 129 +++++++++----------\n drivers/net/ethernet/intel/igc/igc_nvm.c | 12 +-\n drivers/net/ethernet/intel/igc/igc_phy.c | 52 ++++----\n drivers/net/ethernet/intel/igc/igc_ptp.c | 12 +-\n 10 files changed, 223 insertions(+), 241 deletions(-)" }