Cover Letter Detail
Show a cover letter.
GET /api/covers/1253345/?format=api
{ "id": 1253345, "url": "http://patchwork.ozlabs.org/api/covers/1253345/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20200312015818.1007882-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200312015818.1007882-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2020-03-12T01:58:09", "name": "[v3,0/9] ice devlink support", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20200312015818.1007882-1-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 163869, "url": "http://patchwork.ozlabs.org/api/series/163869/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=163869", "date": "2020-03-12T01:58:10", "name": "ice devlink support", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/163869/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/1253345/comments/", "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.137;\n\thelo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48dBnP0ngkz9sPK\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 12 Mar 2020 12:58:33 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id ACFF886193;\n\tThu, 12 Mar 2020 01:58:31 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UD6efRVdcsML; Thu, 12 Mar 2020 01:58:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C08EB86AC1;\n\tThu, 12 Mar 2020 01:58:30 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id F00711BF9B6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 Mar 2020 01:58:24 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E41B888541\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 Mar 2020 01:58:24 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id QpdRfV9buLmB for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 Mar 2020 01:58:22 +0000 (UTC)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id EEAD78852E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 Mar 2020 01:58:21 +0000 (UTC)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Mar 2020 18:58:21 -0700", "from jekeller-desk.amr.corp.intel.com ([10.166.241.33])\n\tby orsmga008.jf.intel.com with ESMTP; 11 Mar 2020 18:58:21 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,543,1574150400\"; d=\"scan'208\";a=\"236656302\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Wed, 11 Mar 2020 18:58:09 -0700", "Message-Id": "<20200312015818.1007882-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.24.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v3 0/9] ice devlink support", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Jakub Kicinski <kuba@kernel.org>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "(Sorry for the thrash, v3 should correct the warning)\n\nImplement basic support for the devlink interface in the ice driver.\nAdditionally pave some necessary changes for adding a devlink region that\nexposes the NVM contents.\n\nThis series first contains 5 patches for enabling and implementing full NVM\nread access via the ETHTOOL_GEEPROM interface. This includes some cleanup of\nendian-types, a new function for reading from the NVM and Shadow RAM as a\nflat addressable space, a function to calculate the available flash size\nduring load, and a change to how some of the NVM version fields are stored\nin the ice_nvm_info structure.\n\nFollowing this is 3 patches for implementing devlink support. First, one\npatch which implements the basic framework and introduces the ice_devlink.c\nfile. Second, a patch to implement basic .info_get support. Finally, a\npatch which reads the device PBA identifier and reports it as the `board.id`\nvalue in the .info_get response.\n\nThis series builds on previous reviews for patches sent as RFC and is\nintended to pave the way for the devlink region changes to support creating\nsnapshots from userspace and reading from a region without a snapshot.\n\nPrevious RFC series and discussion can be found at the following locations\n\n* v1 https://lore.kernel.org/netdev/20200130225913.1671982-2-jacob.e.keller@intel.com/\n* v2 https://lore.kernel.org/netdev/20200214232223.3442651-1-jacob.e.keller@intel.com/\n\nThis series only contains the ice driver changes for the basic devlink\ninterface. I am working on updating the devlink core proposals and will send\nthem to the netdev list after this has been merged.\n\nOnce again, thank you for your continued review and feedback.\n\n## Changes since v2 ##\n\n* create devlink_port before calling register_netdev, correctly fixing the\n issue pointed out by Jiri in the RFC review.\n\n## Changes since v1 ##\n\n* added a patch to promote ``fw.bundle_id`` to a generic version\n* used ``fw.bundle_id`` instead of ``fw.bundle``\n\n## Changes since the RFC ##\n\nRemoved patches:\n* remove \"ice: rename variables used for Option ROM version\", as this is\n superseded by the patch to change now NVM version data is stored.\n\nPatches without change:\n* \"ice: use __le16 types for explicitly Little Endian values\"\n* \"ice: create function to read a section of the NVM and Shadow RAM\"\n\nNew patches:\n* \"ice: store NVM version info in extracted format\"\n a patch which modifies how the NVM version information is stored\n* \"ice: discover and store size of available flash\"\n a patch to discover and save the available flash size during load\n\nChanges in \"ice: implement full NVM read from ETHTOOL_GEEPROM\"\n* use the new flash_size field in ice_get_eeprom_len, enabling a complete\n dump of flash contents, instead of only the initial 64Kb\n* remove the unnecessary EINVAL check on return value from\n ice_read_flat_nvm. Now that we report the proper flash size, this error\n code is unexpected, and should be treated as an error.\n* Use a \"goto release\" to ensure that the ice_release_nvm() function is\n called.\n\nChanges in \"ice: enable initial devlink support\"\n* Update copyright year on ice_devlink.c to 2020\n* make ice_devlink_ops static\n* Use \"Return:\" instead of \"@returns\" in kernel-doc comments\n* Move the call to devlink_port_type_eth_set into ice_cfg_netdev, after the\n call to register_netdev().\n\nChanges in \"ice: add basic handler for devlink .info_get\"\n* convert to a loop over structured data, similar to the nfp driver\n* change ``fw.mgmt.bundle`` to ``fw.mgmt.build``\n* change ``fw.undi.orom`` to just ``fw.undi``\n* change ``nvm.psid`` to ``fw.psid.api``\n* change ``nvm.bundle`` to ``fw.bundle``\n* add ``fw.app.name`` and ``fw.app`` representing the name and version of\n the active DDP package\n* use lowercase %08x instead of %08X for ``fw.bundle``\n\nChanges in \"ice: add board identifier info to devlink .info_get\"\n* modified to use the new structured format for adding new versions\n\nJacob Keller (8):\n ice: use __le16 types for explicitly Little Endian values\n ice: create function to read a section of the NVM and Shadow RAM\n ice: store NVM version info in extracted format\n ice: discover and store size of available flash\n ice: enable initial devlink support\n devlink: promote \"fw.bundle_id\" to a generic info version\n ice: add basic handler for devlink .info_get\n ice: add board identifier info to devlink .info_get\n\nJesse Brandeburg (1):\n ice: implement full NVM read from ETHTOOL_GEEPROM\n\n .../networking/devlink/devlink-info.rst | 5 +\n Documentation/networking/devlink/ice.rst | 71 +++\n Documentation/networking/devlink/index.rst | 1 +\n drivers/net/ethernet/intel/Kconfig | 1 +\n drivers/net/ethernet/intel/ice/Makefile | 1 +\n drivers/net/ethernet/intel/ice/ice.h | 4 +\n .../net/ethernet/intel/ice/ice_adminq_cmd.h | 4 +\n drivers/net/ethernet/intel/ice/ice_common.c | 89 ----\n drivers/net/ethernet/intel/ice/ice_common.h | 9 -\n drivers/net/ethernet/intel/ice/ice_devlink.c | 320 ++++++++++++\n drivers/net/ethernet/intel/ice/ice_devlink.h | 14 +\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 46 +-\n drivers/net/ethernet/intel/ice/ice_main.c | 33 +-\n drivers/net/ethernet/intel/ice/ice_nvm.c | 484 +++++++++++-------\n drivers/net/ethernet/intel/ice/ice_nvm.h | 12 +\n drivers/net/ethernet/intel/ice/ice_type.h | 32 +-\n .../net/ethernet/netronome/nfp/nfp_devlink.c | 2 +-\n include/net/devlink.h | 2 +\n 18 files changed, 826 insertions(+), 304 deletions(-)\n create mode 100644 Documentation/networking/devlink/ice.rst\n create mode 100644 drivers/net/ethernet/intel/ice/ice_devlink.c\n create mode 100644 drivers/net/ethernet/intel/ice/ice_devlink.h" }