Cover Letter Detail
Show a cover letter.
GET /api/covers/1175299/?format=api
{ "id": 1175299, "url": "http://patchwork.ozlabs.org/api/covers/1175299/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20191011153219.22313.60179.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191011153219.22313.60179.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2019-10-11T15:34:44", "name": "[next-queue,v2,0/2] Address IRQ related crash seen due to io_perm_failure", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20191011153219.22313.60179.stgit@localhost.localdomain/mbox/", "series": [ { "id": 135628, "url": "http://patchwork.ozlabs.org/api/series/135628/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=135628", "date": "2019-10-11T15:34:44", "name": "Address IRQ related crash seen due to io_perm_failure", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/135628/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/1175299/comments/", "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Cf3OVwn2\"; dkim-atps=neutral" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46qX8101dSz9sNx\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 12 Oct 2019 02:34:54 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0D9A52039E;\n\tFri, 11 Oct 2019 15:34:53 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id c02wOqSpUmO4; Fri, 11 Oct 2019 15:34:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id AE1BA20358;\n\tFri, 11 Oct 2019 15:34:50 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id D8DCD1BF2AB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Oct 2019 15:34:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D0BC220358\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Oct 2019 15:34:49 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id D-1vPqSmgMVU for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Oct 2019 15:34:48 +0000 (UTC)", "from mail-qt1-f194.google.com (mail-qt1-f194.google.com\n\t[209.85.160.194])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 52CF82033E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Oct 2019 15:34:48 +0000 (UTC)", "by mail-qt1-f194.google.com with SMTP id u22so14403905qtq.13\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 11 Oct 2019 08:34:48 -0700 (PDT)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\tz72sm4964437qka.115.2019.10.11.08.34.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 11 Oct 2019 08:34:46 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:cc:date:message-id:user-agent:mime-version\n\t:content-transfer-encoding;\n\tbh=ku8mWhse7myNTSgXVtERvtlltFxzJS4viFwKBsP2Kto=;\n\tb=Cf3OVwn2GB9W+6JglhZoy9ftTzFsDTWIdhXgdup7BnPpRIyhP3OrWMkPzuoTjNJXAz\n\tF1cwiqlbmuEEUmjfbVK4Mtiappiy5JXta5lo5rO7STGevmKQEFGFKu3tCM4bs+KE+22A\n\t3rEBtX/jn0KTJ2H+NAb3qREQkEA9Ifpz61tvxufBcThzKg/O/W3T1YmVwqPoFeppd7f+\n\tV6FcqdlbKQzk/a2cNPTZwCll1EjRRvgHgpz+JnBMuZ/Mhl18Gvx4UNlAgZs2vC5Xy+Ud\n\tdC55fC+nJRpXpO3s7MBr+3rHb+DAivTtepUa8k7ML0YXdSpUdvonmMfjQ6hJEfiDjM+E\n\terdA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=ku8mWhse7myNTSgXVtERvtlltFxzJS4viFwKBsP2Kto=;\n\tb=LcSqInBGyOlfJx6PPUaKQheVnTUYaKYJG2pJ6J/XwQOyOaW8ZfRvJmEvIdwmQrmR/s\n\tBIZs4H3pG+qSKgf7/S3csY84lnkwjyCPg+kjIBuqqatrx0FempfnVutz2jS/Sydd21ya\n\taAXS31BCm81GnjA/q13AtkgVC31QP6ePturQKSE794T96jABcjdTMsYFlBaenxcGKF4O\n\tYpNFPRcWn5her9cH7cYkR4290qL7692VwYUulGZ+uV4Mvh3HTJTN84SX99Wh3JGO/dBi\n\tmrH9ro4i6b/cDv8euolKNdkWWy+nLNuofD9tOht9TFZ+H3awHEnQTGKEkEN18tURkQ4C\n\tv+HQ==", "X-Gm-Message-State": "APjAAAWKnJdazKpZAK3gp3TEsgCqufVLTrASJGnHXJ/RKHDs1CE5040N\n\tfC3Pbjd6bWiZfRWEIwz3g+E=", "X-Google-Smtp-Source": "APXvYqzEzjydg6QBuYj8zOq8a8Ah58ATsyNuijjtyXfebaBjZuavmVFZ5peOiGgYTxQurgIDAPuwiw==", "X-Received": "by 2002:ac8:4915:: with SMTP id\n\te21mr17846920qtq.69.1570808087106; \n\tFri, 11 Oct 2019 08:34:47 -0700 (PDT)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "alexander.h.duyck@linux.intel.com, intel-wired-lan@lists.osuosl.org,\n\tjeffrey.t.kirsher@intel.com", "Date": "Fri, 11 Oct 2019 08:34:44 -0700", "Message-ID": "<20191011153219.22313.60179.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next-queue PATCH v2 0/2] Address IRQ related\n\tcrash seen due to io_perm_failure", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, zdai@us.ibm.com, zdai@linux.vnet.ibm.com", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "David Dai had submitted a patch[1] to address a reported issue with e1000e\ncalling pci_disable_msi without first freeing the interrupts. Looking over\nthe issue it seems the problem was the fact that e1000e_down was being\ncalled in e1000_io_error_detected without calling e1000_free_irq, and this\nwas resulting in e1000e_close skipping over the call to e1000e_down and\ne1000_free_irq.\n\nThe use of the __E1000_DOWN flag for the close test seems to have come from\nthe runtime power management changes that were made some time ago. From\nwhat I can tell in the close path we should be disabling runtime power\nmanagement via a call to pm_runtime_get_sync. As such we can remove the\ntest for the __E1000_DOWN bit. However in comparing this with other drivers\nwe do need to avoid freeing the IRQs more than once. So in order to address\nthat I have copied the approach taken in igb and taken it a bit further so\nthat we will always detach the interface and if the interface is up we will\nbring it down and free the IRQs. In addition we are able to reuse some of\nthe power management code so I have taken the opportunity to merge those\nbits.\n\n[1]: https://lore.kernel.org/lkml/1570121672-12172-1-git-send-email-zdai@linux.vnet.ibm.com/\n\nv2: Move e1000e_pm_thaw out of CONFIG_PM region to fix build issue on Sparc64\n\n---\n\nAlexander Duyck (2):\n e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm\n e1000e: Drop unnecessary __E1000_DOWN bit twiddling\n\n\n drivers/net/ethernet/intel/e1000e/netdev.c | 75 +++++++++++++---------------\n 1 file changed, 36 insertions(+), 39 deletions(-)\n\n--" }