Cover Letter Detail
Show a cover letter.
GET /api/covers/1129409/?format=api
{ "id": 1129409, "url": "http://patchwork.ozlabs.org/api/covers/1129409/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20190708231236.20516-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190708231236.20516-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2019-07-08T23:12:17", "name": "[00/19] cleanup cppcheck warnings for fm10k driver", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20190708231236.20516-1-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 118423, "url": "http://patchwork.ozlabs.org/api/series/118423/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=118423", "date": "2019-07-08T23:12:19", "name": "cleanup cppcheck warnings for fm10k driver", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/118423/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/1129409/comments/", "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45jLp94JWBz9sNT\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 9 Jul 2019 09:12:46 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4262985A57;\n\tMon, 8 Jul 2019 23:12:44 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id C6QZsnj2mO9s; Mon, 8 Jul 2019 23:12:42 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E05F685A72;\n\tMon, 8 Jul 2019 23:12:42 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8FFC41BF46A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8D733214EB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:41 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id l-pcYuA0whQM for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:39 +0000 (UTC)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby silver.osuosl.org (Postfix) with ESMTPS id CED0E20356\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:39 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Jul 2019 16:12:39 -0700", "from jekeller-desk.amr.corp.intel.com ([10.166.244.172])\n\tby fmsmga002.fm.intel.com with ESMTP; 08 Jul 2019 16:12:39 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,468,1557212400\"; d=\"scan'208\";a=\"192484769\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Mon, 8 Jul 2019 16:12:17 -0700", "Message-Id": "<20190708231236.20516-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.22.0.214.g8dca754b1e87", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 00/19] cleanup cppcheck warnings for fm10k\n\tdriver", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This series contains several patches which resolve various warnings\ngenerated by using the cppcheck tool on the fm10k driver source code.\n\nThe most comment fix is to reduce the scope of local variables where\npossible, and the first 10 patches fix issues like this.\n\nThe remaining 9 patches fix other issues found by the tool. Only one of the\npatches contains what is likely a bug fix. Specifically, the last patch in\nthe series fixes a 64-bit register read issue where we failed to bitwise or\nthe high and low registers together. As this is only in the reporting flow\nfor fault detection, it is relatively minor.\n\nThis series does not fix all of the cppcheck warnings:\n\n[fm10k_ethtool.c:332]: (style) Argument 'idx!=29' to function BUG_ON is always 0\n\nThis warning is due to the fact that we can't use BUILD_BUG_ON. cppcheck is\nsmart enough to realize that the index will always be 29, and thus that\nBUG_ON will never be triggered.\n\n[fm10k_mbx.c:335] -> [fm10k_mbx.c:356]: (style) Variable 'head' is reassigned a value before the old one has been used.\n[fm10k_mbx.c:350] -> [fm10k_mbx.c:356]: (style) Variable 'head' is reassigned a value before the old one has been used.\n[fm10k_mbx.c:428] -> [fm10k_mbx.c:442]: (style) Variable 'tail' is reassigned a value before the old one has been used.\n[fm10k_mbx.c:439] -> [fm10k_mbx.c:442]: (style) Variable 'tail' is reassigned a value before the old one has been used.\n\nThese are almost certainly due to a bug in cppcheck analysis. The head and\ntail values are assigned initially outside the loop. Then, they're updated\nin the for loop. However, they aren't updated until the end of the *first*\nfor-loop iteration. I think cppcheck doesn't understand this and thus\nassumes that the value will be overwritten before its first use.\n\nJacob Keller (19):\n fm10k: reduce scope of the err variable\n fm10k: reduce scope of *p local variable\n fm10k: reduce the scope of qv local variable\n fm10k: reduce the scope of local err variable\n fm10k: reduce the scope of the q_idx local variable\n fm10k: reduce the scope of the tx_buffer variable\n fm10k: reduce the scope of the err variable\n fm10k: reduce the scope of the local i variable\n fm10k: reduce the scope of the local msg variable\n fm10k: reduce the scope of the result local variable\n fm10k: reduce scope of the ring variable\n fm10k: remove unnecessary variable initializer\n fm10k: remove needless assignment of err local variable\n fm10k: remove needless initialization of size local variable\n fm10k: explicitly return 0 on success path in function\n fm10k: cast page_addr to u8 * when incrementing it\n fm10k: mark unused parameters with __always_unused\n fm10k: convert NON_Q_VECTORS(hw) into NON_Q_VECTORS\n fm10k: fix fm10k_get_fault_pf to read correct address\n\n drivers/net/ethernet/intel/fm10k/fm10k.h | 10 +++-----\n .../net/ethernet/intel/fm10k/fm10k_dcbnl.c | 6 ++---\n .../net/ethernet/intel/fm10k/fm10k_ethtool.c | 15 +++++------\n drivers/net/ethernet/intel/fm10k/fm10k_iov.c | 5 ++--\n drivers/net/ethernet/intel/fm10k/fm10k_main.c | 15 +++++------\n drivers/net/ethernet/intel/fm10k/fm10k_mbx.c | 11 +++++---\n .../net/ethernet/intel/fm10k/fm10k_netdev.c | 20 +++++++--------\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 20 +++++++--------\n drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 15 ++++++-----\n drivers/net/ethernet/intel/fm10k/fm10k_tlv.c | 9 ++++---\n drivers/net/ethernet/intel/fm10k/fm10k_type.h | 2 +-\n drivers/net/ethernet/intel/fm10k/fm10k_vf.c | 25 +++++++++++--------\n 12 files changed, 78 insertions(+), 75 deletions(-)" }