Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/949200/?format=api
{ "id": 949200, "url": "http://patchwork.ozlabs.org/api/1.2/patches/949200/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20180725133152.30898-16-miquel.raynal@bootlin.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/1.2/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180725133152.30898-16-miquel.raynal@bootlin.com>", "list_archive_url": null, "date": "2018-07-25T13:31:50", "name": "[v5,15/17] mtd: rawnand: do not export nand_scan_[ident|tail]() anymore", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "71a7424751b5dd56edee1d5457ee2fdd6c24c9a1", "submitter": { "id": 73368, "url": "http://patchwork.ozlabs.org/api/1.2/people/73368/?format=api", "name": "Miquel Raynal", "email": "miquel.raynal@bootlin.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20180725133152.30898-16-miquel.raynal@bootlin.com/mbox/", "series": [ { "id": 57526, "url": "http://patchwork.ozlabs.org/api/1.2/series/57526/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=57526", "date": "2018-07-25T13:31:36", "name": "Allow dynamic allocations during NAND chip identification phase", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/57526/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/949200/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/949200/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=bootlin.com", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"GWc7qTH9\"; \n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41bGcP3D69z9s29\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 25 Jul 2018 23:42:13 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiK3J-0008JY-Mz; Wed, 25 Jul 2018 13:42:05 +0000", "from mail.bootlin.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiJu9-0000Kz-3x\n\tfor linux-mtd@lists.infradead.org; Wed, 25 Jul 2018 13:32:49 +0000", "by mail.bootlin.com (Postfix, from userid 110)\n\tid 229B8206A6; Wed, 25 Jul 2018 15:32:27 +0200 (CEST)", "from localhost.localdomain\n\t(AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr [90.88.20.122])\n\tby mail.bootlin.com (Postfix) with ESMTPSA id 6D6D52093C;\n\tWed, 25 Jul 2018 15:32:00 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=3TOai25AoF7/7beO4VjtqvDDrtuDdF3iYOy7mi2tN+E=;\n\tb=GWc7qTH9N1HGXINHHMlqhY33M0\n\tVhIJs1kFyw/LYCSXMGef+b3CuN3zLi6WTS6H+ssd3sGUC8/yjCbUO7eIxpTKl6eTYZ28xbnAblkve\n\tzrILmppAuTPJaz2FbPE20IhtFoD5FXGpa6MEXFiQNy2feokqy3rjRv1lgUPeu9cJKxmqioogQ5PD8\n\tPoEh7+gCFBISTkg96OAq75Uaq+Tj402fIheVQ+Vmf0N8qe527jEEsSYRV7n44JVOx/bmZtJe7rIOd\n\tshCrCLg8+GpUqSyUbmO9u4EcviqOumQgV1Pk3rsypyjJXhU9X+hjqv42iFjCNEUBb5UU36BdVG5TG\n\tciwuDa1A==;", "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0", "From": "Miquel Raynal <miquel.raynal@bootlin.com>", "To": "Boris Brezillon <boris.brezillon@bootlin.com>,\n\tRichard Weinberger <richard@nod.at>,\n\tDavid Woodhouse <dwmw2@infradead.org>, \n\tBrian Norris <computersforpeace@gmail.com>,\n\tMarek Vasut <marek.vasut@gmail.com>", "Subject": "[PATCH v5 15/17] mtd: rawnand: do not export\n\tnand_scan_[ident|tail]() anymore", "Date": "Wed, 25 Jul 2018 15:31:50 +0200", "Message-Id": "<20180725133152.30898-16-miquel.raynal@bootlin.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20180725133152.30898-1-miquel.raynal@bootlin.com>", "References": "<20180725133152.30898-1-miquel.raynal@bootlin.com>", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20180725_063238_053557_9B5AD288 ", "X-CRM114-Status": "GOOD ( 16.41 )", "X-Spam-Score": "-0.0 (/)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [62.4.15.54 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Cc": "Lucas Stach <dev@lynxeye.de>, Wenyou Yang <wenyou.yang@microchip.com>,\n\tJosh Wu <rainyfeeling@outlook.com>, Stefan Agner <stefan@agner.ch>,\n\tlinux-mtd@lists.infradead.org, Miquel Raynal <miquel.raynal@bootlin.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Both nand_scan_ident() and nand_scan_tail() helpers used to be called\ndirectly from controller drivers that needed to tweak some ECC-related\nparameters before nand_scan_tail(). This separation prevented dynamic\nallocations during the phase of NAND identification, which was\ninconvenient.\n\nAll controller drivers have been moved to use nand_scan(), in\nconjunction with the chip->ecc.[attach|detach]_chip() hooks that\nactually do the required tweaking sequence between both ident/tail\ncalls, allowing programmers to use dynamic allocation as they need all\nacross the scanning sequence.\n\nDeclare nand_scan_[ident|tail]() statically now.\n\nSigned-off-by: Miquel Raynal <miquel.raynal@bootlin.com>\n---\n drivers/mtd/nand/raw/nand_base.c | 16 +++++++++-------\n include/linux/mtd/rawnand.h | 18 ++++++------------\n 2 files changed, 15 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c\nindex 42a7a934a17b..34ea44f90fd8 100644\n--- a/drivers/mtd/nand/raw/nand_base.c\n+++ b/drivers/mtd/nand/raw/nand_base.c\n@@ -5924,7 +5924,7 @@ static int nand_dt_init(struct nand_chip *chip)\n }\n \n /**\n- * nand_scan_ident - [NAND Interface] Scan for the NAND device\n+ * nand_scan_ident - Scan for the NAND device\n * @mtd: MTD device structure\n * @maxchips: number of chips to scan for\n * @table: alternative NAND ID table\n@@ -5932,9 +5932,13 @@ static int nand_dt_init(struct nand_chip *chip)\n * This is the first phase of the normal nand_scan() function. It reads the\n * flash ID and sets up MTD fields accordingly.\n *\n+ * This helper used to be called directly from controller drivers that needed\n+ * to tweak some ECC-related parameters before nand_scan_tail(). This separation\n+ * prevented dynamic allocations during this phase which was unconvenient and\n+ * as been banned for the benefit of the ->init_ecc()/cleanup_ecc() hooks.\n */\n-int nand_scan_ident(struct mtd_info *mtd, int maxchips,\n-\t\t struct nand_flash_dev *table)\n+static int nand_scan_ident(struct mtd_info *mtd, int maxchips,\n+\t\t\t struct nand_flash_dev *table)\n {\n \tint i, nand_maf_id, nand_dev_id;\n \tstruct nand_chip *chip = mtd_to_nand(mtd);\n@@ -6008,7 +6012,6 @@ int nand_scan_ident(struct mtd_info *mtd, int maxchips,\n \n \treturn 0;\n }\n-EXPORT_SYMBOL(nand_scan_ident);\n \n static int nand_set_ecc_soft_ops(struct mtd_info *mtd)\n {\n@@ -6385,14 +6388,14 @@ static bool nand_ecc_strength_good(struct mtd_info *mtd)\n }\n \n /**\n- * nand_scan_tail - [NAND Interface] Scan for the NAND device\n+ * nand_scan_tail - Scan for the NAND device\n * @mtd: MTD device structure\n *\n * This is the second phase of the normal nand_scan() function. It fills out\n * all the uninitialized function pointers with the defaults and scans for a\n * bad block table if appropriate.\n */\n-int nand_scan_tail(struct mtd_info *mtd)\n+static int nand_scan_tail(struct mtd_info *mtd)\n {\n \tstruct nand_chip *chip = mtd_to_nand(mtd);\n \tstruct nand_ecc_ctrl *ecc = &chip->ecc;\n@@ -6716,7 +6719,6 @@ int nand_scan_tail(struct mtd_info *mtd)\n \n \treturn ret;\n }\n-EXPORT_SYMBOL(nand_scan_tail);\n \n static int nand_attach(struct nand_chip *chip)\n {\ndiff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h\nindex a20c78e25878..eaf000b09222 100644\n--- a/include/linux/mtd/rawnand.h\n+++ b/include/linux/mtd/rawnand.h\n@@ -35,17 +35,6 @@ static inline int nand_scan(struct mtd_info *mtd, int max_chips)\n \treturn nand_scan_with_ids(mtd, max_chips, NULL);\n }\n \n-/*\n- * Separate phases of nand_scan(), allowing board driver to intervene\n- * and override command or ECC setup according to flash type.\n- */\n-int nand_scan_ident(struct mtd_info *mtd, int max_chips,\n-\t\t\t struct nand_flash_dev *table);\n-int nand_scan_tail(struct mtd_info *mtd);\n-\n-/* Unregister the MTD device and free resources held by the NAND device */\n-void nand_release(struct mtd_info *mtd);\n-\n /* Internal helper for board drivers which need to override command function */\n void nand_wait_ready(struct mtd_info *mtd);\n \n@@ -1739,8 +1728,13 @@ int nand_read_data_op(struct nand_chip *chip, void *buf, unsigned int len,\n int nand_write_data_op(struct nand_chip *chip, const void *buf,\n \t\t unsigned int len, bool force_8bit);\n \n-/* Free resources held by the NAND device */\n+/*\n+ * Free resources held by the NAND device, must be called on error after a\n+ * sucessful nand_scan().\n+ */\n void nand_cleanup(struct nand_chip *chip);\n+/* Unregister the MTD device and calls nand_cleanup() */\n+void nand_release(struct mtd_info *mtd);\n \n /* Default extended ID decoding function */\n void nand_decode_ext_id(struct nand_chip *chip);\n", "prefixes": [ "v5", "15/17" ] }