Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/949197/?format=api
{ "id": 949197, "url": "http://patchwork.ozlabs.org/api/1.2/patches/949197/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20180725133152.30898-14-miquel.raynal@bootlin.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/1.2/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180725133152.30898-14-miquel.raynal@bootlin.com>", "list_archive_url": null, "date": "2018-07-25T13:31:48", "name": "[v5,13/17] mtd: rawnand: txx9ndfmc: clarify ECC parameters assignation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b56a160a0dd3616d3d87e48d5c0557531a5469fd", "submitter": { "id": 73368, "url": "http://patchwork.ozlabs.org/api/1.2/people/73368/?format=api", "name": "Miquel Raynal", "email": "miquel.raynal@bootlin.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20180725133152.30898-14-miquel.raynal@bootlin.com/mbox/", "series": [ { "id": 57526, "url": "http://patchwork.ozlabs.org/api/1.2/series/57526/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=57526", "date": "2018-07-25T13:31:36", "name": "Allow dynamic allocations during NAND chip identification phase", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/57526/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/949197/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/949197/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=bootlin.com", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"f1QYhRIK\"; \n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41bGc53cn6z9s4c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 25 Jul 2018 23:41:57 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiK31-0007r4-9c; Wed, 25 Jul 2018 13:41:47 +0000", "from mail.bootlin.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiJu4-0000LJ-UC\n\tfor linux-mtd@lists.infradead.org; Wed, 25 Jul 2018 13:32:43 +0000", "by mail.bootlin.com (Postfix, from userid 110)\n\tid 0BDEE209A2; Wed, 25 Jul 2018 15:32:18 +0200 (CEST)", "from localhost.localdomain\n\t(AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr [90.88.20.122])\n\tby mail.bootlin.com (Postfix) with ESMTPSA id E1F1320935;\n\tWed, 25 Jul 2018 15:31:59 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=JfyYCIUL4mQT+/HM+S4pwO6v12x1A7xvwfTXlPfO8dI=;\n\tb=f1QYhRIK/LId2iZYlPSBZ43d2q\n\tx51A7anug5XmIJGF3B3lmPT8hgYto6jDA3eC5YeVti3R/orWZKEBPOCLnXR13wbEFe8nceovJouvA\n\tyg7hcrLTeJOgLc2Qu41Uvh/e2tc2PaiHgKrYSmIFNaqdTmLeKDOGtxRhO9soXTuwb9in7QV+Z2IRT\n\tBeULnLI5bOBqBX7AzKiHBvKyAN6txTzmc5RN/QSXt0L7yvGcRoMHT+UCnt/azMvZUFNy8tc5EsD7D\n\tXgeROFsPRELosRYyBQtgpR96mtyHO5T1yFeNH5SHbV4tm+FXTDK29/qiPcDdN3ryEvlxr7u0+G34/\n\tr9DWV0Dg==;", "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0", "From": "Miquel Raynal <miquel.raynal@bootlin.com>", "To": "Boris Brezillon <boris.brezillon@bootlin.com>,\n\tRichard Weinberger <richard@nod.at>,\n\tDavid Woodhouse <dwmw2@infradead.org>, \n\tBrian Norris <computersforpeace@gmail.com>,\n\tMarek Vasut <marek.vasut@gmail.com>", "Subject": "[PATCH v5 13/17] mtd: rawnand: txx9ndfmc: clarify ECC parameters\n\tassignation", "Date": "Wed, 25 Jul 2018 15:31:48 +0200", "Message-Id": "<20180725133152.30898-14-miquel.raynal@bootlin.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20180725133152.30898-1-miquel.raynal@bootlin.com>", "References": "<20180725133152.30898-1-miquel.raynal@bootlin.com>", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20180725_063233_523988_B274D8E7 ", "X-CRM114-Status": "GOOD ( 12.70 )", "X-Spam-Score": "-0.0 (/)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [62.4.15.54 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Cc": "Lucas Stach <dev@lynxeye.de>, Wenyou Yang <wenyou.yang@microchip.com>,\n\tJosh Wu <rainyfeeling@outlook.com>, Stefan Agner <stefan@agner.ch>,\n\tlinux-mtd@lists.infradead.org, Miquel Raynal <miquel.raynal@bootlin.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "A comment in the probe declares that values are assigned to ecc.size\nand ecc.bytes, but these values will be overwritten. This is not\nentirely right as they are overwritten only if\nmtd->writesize >= 512. Let's clarify this by moving these assignations\nto txx9ndfmc_nand_scan().\n\nSigned-off-by: Miquel Raynal <miquel.raynal@bootlin.com>\n---\n drivers/mtd/nand/raw/txx9ndfmc.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/mtd/nand/raw/txx9ndfmc.c b/drivers/mtd/nand/raw/txx9ndfmc.c\nindex 9019022774f7..9808b18b15e2 100644\n--- a/drivers/mtd/nand/raw/txx9ndfmc.c\n+++ b/drivers/mtd/nand/raw/txx9ndfmc.c\n@@ -262,10 +262,13 @@ static int txx9ndfmc_nand_scan(struct mtd_info *mtd)\n \tret = nand_scan_ident(mtd, 1, NULL);\n \tif (!ret) {\n \t\tif (mtd->writesize >= 512) {\n-\t\t\t/* Hardware ECC 6 byte ECC per 512 Byte data */\n \t\t\tchip->ecc.size = 512;\n \t\t\tchip->ecc.bytes = 6;\n+\t\t} else {\n+\t\t\tchip->ecc.size = 256;\n+\t\t\tchip->ecc.bytes = 3;\n \t\t}\n+\n \t\tret = nand_scan_tail(mtd);\n \t}\n \treturn ret;\n@@ -332,9 +335,6 @@ static int __init txx9ndfmc_probe(struct platform_device *dev)\n \t\tchip->ecc.correct = txx9ndfmc_correct_data;\n \t\tchip->ecc.hwctl = txx9ndfmc_enable_hwecc;\n \t\tchip->ecc.mode = NAND_ECC_HW;\n-\t\t/* txx9ndfmc_nand_scan will overwrite ecc.size and ecc.bytes */\n-\t\tchip->ecc.size = 256;\n-\t\tchip->ecc.bytes = 3;\n \t\tchip->ecc.strength = 1;\n \t\tchip->chip_delay = 100;\n \t\tchip->controller = &drvdata->controller;\n", "prefixes": [ "v5", "13/17" ] }