Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/949187/?format=api
{ "id": 949187, "url": "http://patchwork.ozlabs.org/api/1.2/patches/949187/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20180725133152.30898-10-miquel.raynal@bootlin.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/1.2/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180725133152.30898-10-miquel.raynal@bootlin.com>", "list_archive_url": null, "date": "2018-07-25T13:31:44", "name": "[v5,09/17] mtd: rawnand: jz4740: fix probe function error path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cc1e34194c6b946d8c0ae6e029b84e35853b1016", "submitter": { "id": 73368, "url": "http://patchwork.ozlabs.org/api/1.2/people/73368/?format=api", "name": "Miquel Raynal", "email": "miquel.raynal@bootlin.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20180725133152.30898-10-miquel.raynal@bootlin.com/mbox/", "series": [ { "id": 57526, "url": "http://patchwork.ozlabs.org/api/1.2/series/57526/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=57526", "date": "2018-07-25T13:31:36", "name": "Allow dynamic allocations during NAND chip identification phase", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/57526/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/949187/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/949187/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=bootlin.com", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"ooM2gnT1\"; \n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41bGQV31Wgz9s2M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 25 Jul 2018 23:33:38 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiJv3-0001wf-IT; Wed, 25 Jul 2018 13:33:33 +0000", "from mail.bootlin.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiJu4-0000Kx-Tm\n\tfor linux-mtd@lists.infradead.org; Wed, 25 Jul 2018 13:32:40 +0000", "by mail.bootlin.com (Postfix, from userid 110)\n\tid 7B42320893; Wed, 25 Jul 2018 15:32:17 +0200 (CEST)", "from localhost.localdomain\n\t(AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr [90.88.20.122])\n\tby mail.bootlin.com (Postfix) with ESMTPSA id DDBD3208FF;\n\tWed, 25 Jul 2018 15:31:58 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=0EcLANNDI16hMIUZQMROzKr5ShNrXuQBxiB5/gzkqR0=;\n\tb=ooM2gnT1jCnIB+k5F/0xAtpkeR\n\tvIEFCHiMLR5G1KQGk9LK/VabB4EW0qEo6JWxnbtIKig2Y0LLSiqgSsILq3cv3SbGgzwCP9/LdL4q4\n\t3Hl54D2y8dX9nAw1EA4dVrKFbVal5OWfIMsdPOeAx3oUwHmjPhIXBEUMXN/up867kXS1uD5roWe38\n\tatEHSzvQexptaLtmk47GCsZqm0LBehwpSDn4Jri86GdjzvMWij8MdwHVf34JPul8Xabk7tLeMbnry\n\tfDq1lU9s1p11Xu5xAey3Hkk117wALaD+m6JhkiGgCYhyIbjC1qF4GyHaXKx5smDhivZuwqlR+9CkY\n\tEJwK/cng==;", "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0", "From": "Miquel Raynal <miquel.raynal@bootlin.com>", "To": "Boris Brezillon <boris.brezillon@bootlin.com>,\n\tRichard Weinberger <richard@nod.at>,\n\tDavid Woodhouse <dwmw2@infradead.org>, \n\tBrian Norris <computersforpeace@gmail.com>,\n\tMarek Vasut <marek.vasut@gmail.com>", "Subject": "[PATCH v5 09/17] mtd: rawnand: jz4740: fix probe function error path", "Date": "Wed, 25 Jul 2018 15:31:44 +0200", "Message-Id": "<20180725133152.30898-10-miquel.raynal@bootlin.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20180725133152.30898-1-miquel.raynal@bootlin.com>", "References": "<20180725133152.30898-1-miquel.raynal@bootlin.com>", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20180725_063233_463395_00287749 ", "X-CRM114-Status": "GOOD ( 14.20 )", "X-Spam-Score": "-0.0 (/)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [62.4.15.54 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Cc": "Lucas Stach <dev@lynxeye.de>, Wenyou Yang <wenyou.yang@microchip.com>,\n\tJosh Wu <rainyfeeling@outlook.com>, Stefan Agner <stefan@agner.ch>,\n\tlinux-mtd@lists.infradead.org, Miquel Raynal <miquel.raynal@bootlin.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "An error after nand_scan_tail() should trigger a nand_cleanup(), not a\nnand_release() as mtd_device_register() (or one of its variants) has not\nbeen called and there is no need to deregister any MTD device yet.\n\nSigned-off-by: Miquel Raynal <miquel.raynal@bootlin.com>\n---\n drivers/mtd/nand/raw/jz4740_nand.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/mtd/nand/raw/jz4740_nand.c b/drivers/mtd/nand/raw/jz4740_nand.c\nindex a4052b03249c..3abf87420c10 100644\n--- a/drivers/mtd/nand/raw/jz4740_nand.c\n+++ b/drivers/mtd/nand/raw/jz4740_nand.c\n@@ -472,15 +472,15 @@ static int jz_nand_probe(struct platform_device *pdev)\n \n \tif (ret) {\n \t\tdev_err(&pdev->dev, \"Failed to add mtd device\\n\");\n-\t\tgoto err_nand_release;\n+\t\tgoto err_cleanup_nand;\n \t}\n \n \tdev_info(&pdev->dev, \"Successfully registered JZ4740 NAND driver\\n\");\n \n \treturn 0;\n \n-err_nand_release:\n-\tnand_release(mtd);\n+err_cleanup_nand:\n+\tnand_cleanup(chip);\n err_unclaim_banks:\n \twhile (chipnr--) {\n \t\tunsigned char bank = nand->banks[chipnr];\n", "prefixes": [ "v5", "09/17" ] }