Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/949181/?format=api
{ "id": 949181, "url": "http://patchwork.ozlabs.org/api/1.2/patches/949181/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20180725133152.30898-2-miquel.raynal@bootlin.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/1.2/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180725133152.30898-2-miquel.raynal@bootlin.com>", "list_archive_url": null, "date": "2018-07-25T13:31:36", "name": "[v5,01/17] mtd: rawnand: brcmnand: convert driver to nand_scan()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b09492b9cbe209f1a51fc7c5d466dad0dc3e713a", "submitter": { "id": 73368, "url": "http://patchwork.ozlabs.org/api/1.2/people/73368/?format=api", "name": "Miquel Raynal", "email": "miquel.raynal@bootlin.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20180725133152.30898-2-miquel.raynal@bootlin.com/mbox/", "series": [ { "id": 57526, "url": "http://patchwork.ozlabs.org/api/1.2/series/57526/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=57526", "date": "2018-07-25T13:31:36", "name": "Allow dynamic allocations during NAND chip identification phase", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/57526/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/949181/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/949181/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=bootlin.com", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"tx/CU8Po\"; \n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41bGPD4sH4z9s2M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 25 Jul 2018 23:32:32 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiJtw-0000L2-QN; Wed, 25 Jul 2018 13:32:24 +0000", "from mail.bootlin.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiJtr-0000Is-Dj\n\tfor linux-mtd@lists.infradead.org; Wed, 25 Jul 2018 13:32:22 +0000", "by mail.bootlin.com (Postfix, from userid 110)\n\tid 21CA32095C; Wed, 25 Jul 2018 15:32:07 +0200 (CEST)", "from localhost.localdomain\n\t(AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr [90.88.20.122])\n\tby mail.bootlin.com (Postfix) with ESMTPSA id C593E206A6;\n\tWed, 25 Jul 2018 15:31:56 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=fnJ6aAfvHb9EmqFnAQIXgNE/o2I9ZCMBJ3M8WB+7c6w=;\n\tb=tx/CU8PolSqP0q0TiGY+j31XTh\n\tM40D0j5k6erWuoiGfcDdsX/nw8rvaRDr0tBnTlpFFy8NyTkCr881rFgF+DjAf9K/29bpWXWBwZKH7\n\t4Y7zfCnS2geCBPZcKXidf/yJRaPm0xd0Oqyjiz6AIUVNv7HLTJ6McZ796Dvbes6wRAsrQ/jMK3bS4\n\tooiYuesiRbs8m6qeZW3iL3auDPjUaBEOwLSd25iXH79L3VeA0TpxRrMHNUErV5FTp8Sv0qleyWm8G\n\tOMqEZWwdEbIyc//zT871tyjbsI5fmOmgUdZrnc0UBWmvdoJ1Glu5XxJ+XA6yW4YNaDGaSnESi7V3B\n\t44gAh1Ug==;", "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0", "From": "Miquel Raynal <miquel.raynal@bootlin.com>", "To": "Boris Brezillon <boris.brezillon@bootlin.com>,\n\tRichard Weinberger <richard@nod.at>,\n\tDavid Woodhouse <dwmw2@infradead.org>, \n\tBrian Norris <computersforpeace@gmail.com>,\n\tMarek Vasut <marek.vasut@gmail.com>", "Subject": "[PATCH v5 01/17] mtd: rawnand: brcmnand: convert driver to\n\tnand_scan()", "Date": "Wed, 25 Jul 2018 15:31:36 +0200", "Message-Id": "<20180725133152.30898-2-miquel.raynal@bootlin.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20180725133152.30898-1-miquel.raynal@bootlin.com>", "References": "<20180725133152.30898-1-miquel.raynal@bootlin.com>", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20180725_063219_762870_B41C6E7F ", "X-CRM114-Status": "GOOD ( 14.89 )", "X-Spam-Score": "-0.0 (/)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [62.4.15.54 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Cc": "Lucas Stach <dev@lynxeye.de>, Wenyou Yang <wenyou.yang@microchip.com>,\n\tJosh Wu <rainyfeeling@outlook.com>, Stefan Agner <stefan@agner.ch>,\n\tlinux-mtd@lists.infradead.org, Miquel Raynal <miquel.raynal@bootlin.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Two helpers have been added to the core to do all kind of controller\nside configuration/initialization between the detection phase and the\nfinal NAND scan. Implement these hooks so that we can convert the driver\nto just use nand_scan() instead of the nand_scan_ident() +\nnand_scan_tail() pair.\n\nSigned-off-by: Miquel Raynal <miquel.raynal@bootlin.com>\n---\n drivers/mtd/nand/raw/brcmnand/brcmnand.c | 63 ++++++++++++++++++--------------\n 1 file changed, 36 insertions(+), 27 deletions(-)", "diff": "diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c\nindex 2e5efa0f9ea2..4b90d5b380c2 100644\n--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c\n+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c\n@@ -2208,6 +2208,40 @@ static int brcmnand_setup_dev(struct brcmnand_host *host)\n \treturn 0;\n }\n \n+static int brcmnand_attach_chip(struct nand_chip *chip)\n+{\n+\tstruct mtd_info *mtd = nand_to_mtd(chip);\n+\tstruct brcmnand_host *host = nand_get_controller_data(chip);\n+\tint ret;\n+\n+\tchip->options |= NAND_NO_SUBPAGE_WRITE;\n+\t/*\n+\t * Avoid (for instance) kmap()'d buffers from JFFS2, which we can't DMA\n+\t * to/from, and have nand_base pass us a bounce buffer instead, as\n+\t * needed.\n+\t */\n+\tchip->options |= NAND_USE_BOUNCE_BUFFER;\n+\n+\tif (chip->bbt_options & NAND_BBT_USE_FLASH)\n+\t\tchip->bbt_options |= NAND_BBT_NO_OOB;\n+\n+\tif (brcmnand_setup_dev(host))\n+\t\treturn -ENXIO;\n+\n+\tchip->ecc.size = host->hwcfg.sector_size_1k ? 1024 : 512;\n+\n+\t/* only use our internal HW threshold */\n+\tmtd->bitflip_threshold = 1;\n+\n+\tret = brcmstb_choose_ecc_layout(host);\n+\n+\treturn ret;\n+}\n+\n+static const struct nand_controller_ops brcmnand_controller_ops = {\n+\t.attach_chip = brcmnand_attach_chip,\n+};\n+\n static int brcmnand_init_cs(struct brcmnand_host *host, struct device_node *dn)\n {\n \tstruct brcmnand_controller *ctrl = host->ctrl;\n@@ -2267,33 +2301,7 @@ static int brcmnand_init_cs(struct brcmnand_host *host, struct device_node *dn)\n \tnand_writereg(ctrl, cfg_offs,\n \t\t nand_readreg(ctrl, cfg_offs) & ~CFG_BUS_WIDTH);\n \n-\tret = nand_scan_ident(mtd, 1, NULL);\n-\tif (ret)\n-\t\treturn ret;\n-\n-\tchip->options |= NAND_NO_SUBPAGE_WRITE;\n-\t/*\n-\t * Avoid (for instance) kmap()'d buffers from JFFS2, which we can't DMA\n-\t * to/from, and have nand_base pass us a bounce buffer instead, as\n-\t * needed.\n-\t */\n-\tchip->options |= NAND_USE_BOUNCE_BUFFER;\n-\n-\tif (chip->bbt_options & NAND_BBT_USE_FLASH)\n-\t\tchip->bbt_options |= NAND_BBT_NO_OOB;\n-\n-\tif (brcmnand_setup_dev(host))\n-\t\treturn -ENXIO;\n-\n-\tchip->ecc.size = host->hwcfg.sector_size_1k ? 1024 : 512;\n-\t/* only use our internal HW threshold */\n-\tmtd->bitflip_threshold = 1;\n-\n-\tret = brcmstb_choose_ecc_layout(host);\n-\tif (ret)\n-\t\treturn ret;\n-\n-\tret = nand_scan_tail(mtd);\n+\tret = nand_scan(mtd, 1);\n \tif (ret)\n \t\treturn ret;\n \n@@ -2434,6 +2442,7 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)\n \tinit_completion(&ctrl->done);\n \tinit_completion(&ctrl->dma_done);\n \tnand_controller_init(&ctrl->controller);\n+\tctrl->controller.ops = &brcmnand_controller_ops;\n \tINIT_LIST_HEAD(&ctrl->host_list);\n \n \t/* NAND register range */\n", "prefixes": [ "v5", "01/17" ] }