Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/833729/?format=api
{ "id": 833729, "url": "http://patchwork.ozlabs.org/api/1.2/patches/833729/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20171103090344.19444-12-jiri@resnulli.us/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171103090344.19444-12-jiri@resnulli.us>", "list_archive_url": null, "date": "2017-11-03T09:03:39", "name": "[net-next,11/16] mlxsw: spectrum_router: Fix saddr deduction in mlxsw_sp_ipip_entry_create()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "abe5167b23354bf161b4339c6be91c3e6bbdf857", "submitter": { "id": 15321, "url": "http://patchwork.ozlabs.org/api/1.2/people/15321/?format=api", "name": "Jiri Pirko", "email": "jiri@resnulli.us" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20171103090344.19444-12-jiri@resnulli.us/mbox/", "series": [ { "id": 11677, "url": "http://patchwork.ozlabs.org/api/1.2/series/11677/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=11677", "date": "2017-11-03T09:03:28", "name": "mlxsw: Handle changes in GRE configuration", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/11677/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/833729/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/833729/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"o5CRYSke\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySwxz3fFJz9sNV\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 3 Nov 2017 20:04:39 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755756AbdKCJEh (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 3 Nov 2017 05:04:37 -0400", "from mail-wr0-f196.google.com ([209.85.128.196]:43142 \"EHLO\n\tmail-wr0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932576AbdKCJDz (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 3 Nov 2017 05:03:55 -0400", "by mail-wr0-f196.google.com with SMTP id w105so1876641wrc.0\n\tfor <netdev@vger.kernel.org>; Fri, 03 Nov 2017 02:03:54 -0700 (PDT)", "from localhost (ip-94-113-127-32.net.upcbroadband.cz.\n\t[94.113.127.32]) by smtp.gmail.com with ESMTPSA id\n\tw4sm5274571wrc.17.2017.11.03.02.03.53\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 03 Nov 2017 02:03:53 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=30vjEFUIvs7ummskv1LO02/hPxlqvbW0ikx8wBfku4g=;\n\tb=o5CRYSkehbyAuyAid3pBQlRnpZHK4GgpQPBIxRjyKUASyChboxqoOTzbyWQnTFxGnO\n\tk6p5J2HaTJ6Kdjp5cqcqg2nKDkYpij518945RYgll9jkYkD++2NpXX5wckbTDfBe+Jvw\n\tUkJZ+qeXFev8MTE99uwnJyzxCPH/EIpT7KQnXrLNtno9CZHz3Xn4nZGwTYzKZD6QaRJH\n\txO5/Ym6LwGnYGo0sXJULe9zOArsGgd5/M2zd7gtxOlue65fLajEc7DY2tuyCkPAd9rTO\n\tX/SNEykd0XUT5wVZzUswfJDgi9TaE9jMS/xNt9eeiyj5o/Ja+m30kaxjC7oTjwukizkZ\n\t13sA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=30vjEFUIvs7ummskv1LO02/hPxlqvbW0ikx8wBfku4g=;\n\tb=joxVgY06gj5k9eo0aMOy+kC9V2FOTrKA7kSb76lxLCXSKnDZ2IV51hgzCaUQze5Afe\n\tN2ZvpW5/BIqXBtCP4L2oWjXlwQ31XQ2Q6VcPL2K6EXBGtv1hx70qEFBnW/p5ccShHjam\n\tWXqq2G+SIPAO2yp7DZYTsbzWkDNRcMOSM2S/NVqsbdw76gTPlfkq13KT9tC7mIRZdBBb\n\tVijG0NiY2Mik9PXyyaKwwsvCgRAhegEITtnFeGWbZTurQiRmnrMN5ynaY1uJuV55OTEd\n\tyPz7fwqB7OD2938x4gN3XPT4cjgHptXCC3CwaSs80hfUyPu2B5QZy+PFOq5J9fvIJhdc\n\topYQ==", "X-Gm-Message-State": "AMCzsaXrSmhOPEtjilGtYkvybE4xZ40tJj4hi+xPCZtHKm4FgKizMnJi\n\tXBPgGGLxvkqyL8OjxTIBtk+jFOSd", "X-Google-Smtp-Source": "ABhQp+RMyoUAAbBOTAccYxewkb6vbyDh7Wluu1j2L4dzvk/9EqdFB/xbfR9vbcZNkYiZqACPygmJhw==", "X-Received": "by 10.223.133.242 with SMTP id 47mr5538719wru.170.1509699834040; \n\tFri, 03 Nov 2017 02:03:54 -0700 (PDT)", "From": "Jiri Pirko <jiri@resnulli.us>", "To": "netdev@vger.kernel.org", "Cc": "davem@davemloft.net, petrm@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com", "Subject": "[patch net-next 11/16] mlxsw: spectrum_router: Fix saddr deduction\n\tin mlxsw_sp_ipip_entry_create()", "Date": "Fri, 3 Nov 2017 10:03:39 +0100", "Message-Id": "<20171103090344.19444-12-jiri@resnulli.us>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20171103090344.19444-1-jiri@resnulli.us>", "References": "<20171103090344.19444-1-jiri@resnulli.us>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Petr Machata <petrm@mellanox.com>\n\nWhen trying to determine whether there are other offloaded tunnels with\nthe same local address, mlxsw_sp_ipip_entry_create() should look for a\ntunnel with matching UL protocol, matching saddr, in the same VRF.\nHowever instead of taking into account the UL protocol of the tunnel\nnetdevice (which mlxsw_sp_ipip_entry_saddr_matches() then compares to\nthe UL protocol of inspected IPIP entry), it deduces the UL protocol\nfrom the inspected IPIP entry (and that's compared to itself).\n\nThis is currently immaterial, because only one tunnel type is offloaded,\nand therefore the UL protocol always matches, but introducing support\nfor a tunnel with IPv6 underlay would uncover this error.\n\nSigned-off-by: Petr Machata <petrm@mellanox.com>\nReviewed-by: Ido Schimmel <idosch@mellanox.com>\nSigned-off-by: Jiri Pirko <jiri@mellanox.com>\n---\n drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\nindex 1376a97..897a384 100644\n--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\n+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\n@@ -1169,10 +1169,10 @@ mlxsw_sp_ipip_entry_create(struct mlxsw_sp *mlxsw_sp,\n \t * in the same underlay table needs special treatment in the HW. That is\n \t * currently not implemented in the driver.\n \t */\n+\tul_proto = router->ipip_ops_arr[ipipt]->ul_proto;\n+\tsaddr = mlxsw_sp_ipip_netdev_saddr(ul_proto, ol_dev);\n \tlist_for_each_entry(ipip_entry, &mlxsw_sp->router->ipip_list,\n \t\t\t ipip_list_node) {\n-\t\tul_proto = router->ipip_ops_arr[ipip_entry->ipipt]->ul_proto;\n-\t\tsaddr = mlxsw_sp_ipip_netdev_saddr(ul_proto, ol_dev);\n \t\tif (mlxsw_sp_ipip_entry_saddr_matches(mlxsw_sp, ul_proto, saddr,\n \t\t\t\t\t\t ul_tb_id, ipip_entry))\n \t\t\treturn ERR_PTR(-EEXIST);\n", "prefixes": [ "net-next", "11/16" ] }