Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/833390/?format=api
{ "id": 833390, "url": "http://patchwork.ozlabs.org/api/1.2/patches/833390/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1509633855-24470-1-git-send-email-jon.maloy@ericsson.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1509633855-24470-1-git-send-email-jon.maloy@ericsson.com>", "list_archive_url": null, "date": "2017-11-02T14:44:15", "name": "[net-next,1/1] tipc: eliminate unnecessary probing", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ba286c8a6fb73546b8634b45eec198a6156aac7f", "submitter": { "id": 3953, "url": "http://patchwork.ozlabs.org/api/1.2/people/3953/?format=api", "name": "Jon Maloy", "email": "jon.maloy@ericsson.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1509633855-24470-1-git-send-email-jon.maloy@ericsson.com/mbox/", "series": [ { "id": 11522, "url": "http://patchwork.ozlabs.org/api/1.2/series/11522/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=11522", "date": "2017-11-02T14:44:15", "name": "[net-next,1/1] tipc: eliminate unnecessary probing", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/11522/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/833390/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/833390/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySSXW4YMCz9sNw\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 3 Nov 2017 01:44:27 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S933634AbdKBOoZ (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 2 Nov 2017 10:44:25 -0400", "from sessmg22.ericsson.net ([193.180.251.58]:56244 \"EHLO\n\tsessmg22.ericsson.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S933448AbdKBOoX (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 2 Nov 2017 10:44:23 -0400", "from ESESSHC011.ericsson.se (Unknown_Domain [153.88.183.51])\n\tby sessmg22.ericsson.net (Symantec Mail Security) with SMTP id\n\t8E.BF.26775.54F2BF95; Thu, 2 Nov 2017 15:44:21 +0100 (CET)", "from tipsy.lab.linux.ericsson.se (10.35.28.120) by\n\tESESSHC011.ericsson.se (153.88.183.51) with Microsoft SMTP Server\n\t(TLS) id 14.3.352.0; Thu, 2 Nov 2017 15:44:20 +0100" ], "X-AuditID": "c1b4fb3a-de7ff70000006897-01-59fb2f456a82", "From": "Jon Maloy <jon.maloy@ericsson.com>", "To": "<davem@davemloft.net>, <netdev@vger.kernel.org>", "CC": "<parthasarathy.bhuvaragan@ericsson.com>, <ying.xue@windriver.com>,\n\t<tipc-discussion@lists.sourceforge.net>", "Subject": "[net-next 1/1] tipc: eliminate unnecessary probing", "Date": "Thu, 2 Nov 2017 15:44:15 +0100", "Message-ID": "<1509633855-24470-1-git-send-email-jon.maloy@ericsson.com>", "X-Mailer": "git-send-email 2.1.4", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.35.28.120]", "X-Brightmail-Tracker": "H4sIAAAAAAAAA+NgFlrELMWRmVeSWpSXmKPExsUyM2K7sa6r/u9Ig9tb9SzmnG9hsTi2QMxi\n\ty/ksi8fXrzM7sHhsWXmTyWP3gs9MHp83yXms37KVKYAlissmJTUnsyy1SN8ugStjwf6X7AVf\n\tBCsaLi5nb2A8zNfFyMkhIWAi8fjeBfYuRi4OIYHDjBINTxezQjjbGCXOvb/EBFLFJqAh8XJa\n\tByOILSJgLPFqZSdYnFmgQOLpxH+sILawgLXE3N8zWEBsFgEVic/zfoPV8wq4SUzu2scGsU1O\n\t4vzxn8wQcUGJkzOfsEDMkZA4+OIFWFxIQFli7odpTBD1ChLfZnYzTWDkm4WkZRaSlgWMTKsY\n\tRYtTi4tz042M9FKLMpOLi/Pz9PJSSzYxAkPu4JbfVjsYDz53PMQowMGoxMPbK/I7Uog1say4\n\tMvcQowQHs5II73spoBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXFeh30XIoQE0hNLUrNTUwtSi2Cy\n\tTBycUg2MycYmbe4rr/f+V/zhILN26py/r2pmvd/y+M35yReWHpWOv7HF4O37R5OVmw/yu+w4\n\tfFHU35s3b88t768TD/y+Vydz9kH7vcV2+cLHzKe9qtkj81TjhrNs5sLg5srDx9c+Y+64Wzn/\n\t7NFnbJdaRRSULl8PuTdpUo9HXXujsPJiuaWK3UZnFQ85yCuxFGckGmoxFxUnAgC6S1TUNQIA\n\tAA==", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "The neighbor monitor employs a threshold, default set to 32 peer nodes,\nwhere it activates the \"Overlapping Neighbor Monitoring\" algorithm.\nBelow that threshold, monitoring is full-mesh, and no \"domain records\"\nare passed between the nodes.\n\nBecause of this, a node never received a peer's ack that it has received\nthe most recent update of the own domain. Hence, the field 'acked_gen'\nin struct tipc_monitor_state remains permamently at zero, whereas the\nown domain generation is incremented for each added or removed peer.\n\nThis has the effect that the function tipc_mon_get_state() always sets\nthe field 'probing' in struct tipc_monitor_state true, again leading the\ntipc_link_timeout() of the link in question to always send out a probe,\neven when link->silent_intv_count is zero.\n\nThis is functionally harmless, but leads to some unncessary probing,\nwhich can easily be eliminated by setting the 'probing' field of the\nsaid struct correctly in such cases.\n\nAt the same time, we explictly invalidate the sent domain records when\nthe algorithm is not activated. This will eliminate any risk that an\ninvalid domain record might be inadverently accepted by the peer.\n\nSigned-off-by: Jon Maloy <jon.maloy@ericsson.com>\n---\n net/tipc/monitor.c | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/net/tipc/monitor.c b/net/tipc/monitor.c\nindex b9c3255..8e884ed 100644\n--- a/net/tipc/monitor.c\n+++ b/net/tipc/monitor.c\n@@ -530,8 +530,11 @@ void tipc_mon_prep(struct net *net, void *data, int *dlen,\n \tu16 gen = mon->dom_gen;\n \tu16 len;\n \n-\tif (!tipc_mon_is_active(net, mon))\n+\t/* Send invalid record if not active */\n+\tif (!tipc_mon_is_active(net, mon)) {\n+\t\tdom->len = 0;\n \t\treturn;\n+\t}\n \n \t/* Send only a dummy record with ack if peer has acked our last sent */\n \tif (likely(state->acked_gen == gen)) {\n@@ -559,6 +562,12 @@ void tipc_mon_get_state(struct net *net, u32 addr,\n \tstruct tipc_monitor *mon = tipc_monitor(net, bearer_id);\n \tstruct tipc_peer *peer;\n \n+\tif (!tipc_mon_is_active(net, mon)) {\n+\t\tstate->probing = false;\n+\t\tstate->monitoring = true;\n+\t\treturn;\n+\t}\n+\n \t/* Used cached state if table has not changed */\n \tif (!state->probing &&\n \t (state->list_gen == mon->list_gen) &&\n", "prefixes": [ "net-next", "1/1" ] }