Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 833338,
    "url": "http://patchwork.ozlabs.org/api/1.2/patches/833338/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/linux-i2c/patch/20171102124731.10484-5-wsa+renesas@sang-engineering.com/",
    "project": {
        "id": 35,
        "url": "http://patchwork.ozlabs.org/api/1.2/projects/35/?format=api",
        "name": "Linux I2C development",
        "link_name": "linux-i2c",
        "list_id": "linux-i2c.vger.kernel.org",
        "list_email": "linux-i2c@vger.kernel.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": "",
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20171102124731.10484-5-wsa+renesas@sang-engineering.com>",
    "list_archive_url": null,
    "date": "2017-11-02T12:47:30",
    "name": "[RFT,4/5] i2c: sh_mobile: use direct writes when accessing ICE bit",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "35fdae8178defdb70c1dfedf9695b52df95dc5ba",
    "submitter": {
        "id": 69646,
        "url": "http://patchwork.ozlabs.org/api/1.2/people/69646/?format=api",
        "name": "Wolfram Sang",
        "email": "wsa+renesas@sang-engineering.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/linux-i2c/patch/20171102124731.10484-5-wsa+renesas@sang-engineering.com/mbox/",
    "series": [
        {
            "id": 11496,
            "url": "http://patchwork.ozlabs.org/api/1.2/series/11496/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/linux-i2c/list/?series=11496",
            "date": "2017-11-02T12:47:26",
            "name": "i2c: sh_mobile: refactor HW init/deinit",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/11496/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/833338/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/833338/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<linux-i2c-owner@vger.kernel.org>",
        "X-Original-To": "incoming@patchwork.ozlabs.org",
        "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySPxt0Lltz9t2l\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu,  2 Nov 2017 23:47:46 +1100 (AEDT)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754894AbdKBMrn (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tThu, 2 Nov 2017 08:47:43 -0400",
            "from sauhun.de ([88.99.104.3]:33864 \"EHLO pokefinder.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751974AbdKBMrm (ORCPT <rfc822;linux-i2c@vger.kernel.org>);\n\tThu, 2 Nov 2017 08:47:42 -0400",
            "from localhost (p54B33C39.dip0.t-ipconnect.de [84.179.60.57])\n\tby pokefinder.org (Postfix) with ESMTPSA id 601A02C3237;\n\tThu,  2 Nov 2017 13:47:41 +0100 (CET)"
        ],
        "From": "Wolfram Sang <wsa+renesas@sang-engineering.com>",
        "To": "linux-i2c@vger.kernel.org",
        "Cc": "linux-renesas-soc@vger.kernel.org,\n\tYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,\n\tJacopo Mondi <jacopo@jmondi.org>,\n\tWolfram Sang <wsa+renesas@sang-engineering.com>",
        "Subject": "[PATCH RFT 4/5] i2c: sh_mobile: use direct writes when accessing\n\tICE bit",
        "Date": "Thu,  2 Nov 2017 13:47:30 +0100",
        "Message-Id": "<20171102124731.10484-5-wsa+renesas@sang-engineering.com>",
        "X-Mailer": "git-send-email 2.11.0",
        "In-Reply-To": "<20171102124731.10484-1-wsa+renesas@sang-engineering.com>",
        "References": "<20171102124731.10484-1-wsa+renesas@sang-engineering.com>",
        "Sender": "linux-i2c-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<linux-i2c.vger.kernel.org>",
        "X-Mailing-List": "linux-i2c@vger.kernel.org"
    },
    "content": "ICE bit is for resetting the module. Other bits don't matter then, so we\ndon't need to use the iic_set_clr() function but can use iic_wr().\n\nSigned-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>\n---\n drivers/i2c/busses/i2c-sh_mobile.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c\nindex cdd7a746b9d1ed..1701f193d94acf 100644\n--- a/drivers/i2c/busses/i2c-sh_mobile.c\n+++ b/drivers/i2c/busses/i2c-sh_mobile.c\n@@ -620,10 +620,10 @@ static int start_ch(struct sh_mobile_i2c_data *pd, struct i2c_msg *usr_msg,\n \n \tif (do_init) {\n \t\t/* Initialize channel registers */\n-\t\tiic_set_clr(pd, ICCR, 0, ICCR_ICE);\n+\t\tiic_wr(pd, ICCR, 0);\n \n \t\t/* Enable channel and configure rx ack */\n-\t\tiic_set_clr(pd, ICCR, ICCR_ICE, 0);\n+\t\tiic_wr(pd, ICCR, ICCR_ICE);\n \n \t\t/* Set the clock */\n \t\tiic_wr(pd, ICCL, pd->iccl & 0xff);\n@@ -740,7 +740,7 @@ static int sh_mobile_i2c_xfer(struct i2c_adapter *adapter,\n \t}\n \n \t/* Disable channel */\n-\tiic_set_clr(pd, ICCR, 0, ICCR_ICE);\n+\tiic_wr(pd, ICCR, 0);\n \n \t/* Disable clock and mark device as idle */\n \tclk_disable_unprepare(pd->clk);\n",
    "prefixes": [
        "RFT",
        "4/5"
    ]
}