Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/833309/?format=api
{ "id": 833309, "url": "http://patchwork.ozlabs.org/api/1.2/patches/833309/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/20171102112514.27542-1-nusiddiq@redhat.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/1.2/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171102112514.27542-1-nusiddiq@redhat.com>", "list_archive_url": null, "date": "2017-11-02T11:25:14", "name": "[ovs-dev] ovn-ctl: Provide the option to detach the OVN db servers or not when starting", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "267f208c880b1aa58f8b0e7af93c4e087efc36b8", "submitter": { "id": 67480, "url": "http://patchwork.ozlabs.org/api/1.2/people/67480/?format=api", "name": "Numan Siddique", "email": "nusiddiq@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/20171102112514.27542-1-nusiddiq@redhat.com/mbox/", "series": [ { "id": 11484, "url": "http://patchwork.ozlabs.org/api/1.2/series/11484/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=11484", "date": "2017-11-02T11:25:14", "name": "[ovs-dev] ovn-ctl: Provide the option to detach the OVN db servers or not when starting", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/11484/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/833309/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/833309/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=nusiddiq@redhat.com" ], "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ySN7G6xZTz9t2M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 2 Nov 2017 22:25:46 +1100 (AEDT)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 81004AD2;\n\tThu, 2 Nov 2017 11:25:25 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 918E6A59\n\tfor <dev@openvswitch.org>; Thu, 2 Nov 2017 11:25:23 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 3A6931AD\n\tfor <dev@openvswitch.org>; Thu, 2 Nov 2017 11:25:23 +0000 (UTC)", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 96BFB13A5F\n\tfor <dev@openvswitch.org>; Thu, 2 Nov 2017 11:25:22 +0000 (UTC)", "from numans.blr.redhat.com (dhcp-0-126.blr.redhat.com\n\t[10.70.1.126])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id EB6B560602;\n\tThu, 2 Nov 2017 11:25:19 +0000 (UTC)" ], "X-Greylist": [ "domain auto-whitelisted by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tThu, 02 Nov 2017 11:25:22 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 96BFB13A5F", "From": "nusiddiq@redhat.com", "To": "dev@openvswitch.org", "Date": "Thu, 2 Nov 2017 16:55:14 +0530", "Message-Id": "<20171102112514.27542-1-nusiddiq@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Spam-Status": "No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Subject": "[ovs-dev] [PATCH] ovn-ctl: Provide the option to detach the OVN db\n\tservers or not when starting", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "From: Numan Siddique <nusiddiq@redhat.com>\n\nPresently if the user wants to start OVN db servers as separate containers, 'ovn-ctl'\nscript is not useful as '--detach' option is passed when ovsdb-servers are started.\nIf the container command is 'ovn-ctl start_nb_ovsdb', the container exits as soon as\novn-ctl exits.\n\nThis patch adds 2 new options to the 'ovn-ctl' script - '--db-nb-detach' and\n'--db-sb-detach' which can take 'yes/no'. This will be really useful for the above\nmentioned requirement. The user can start NB ovsdb-server with the command\n'ovn-ctl start_nb_ovsdb --db-nb-detach=no'.\n\nWithout this option, the user may have to first generate the db by running 'ovsdb-tool'\nand then start the container with the command 'ovsdb-server ovnnb_db.db ....' and this\nis very inconvenient. This option will be useful only if the OVN db servers are started\nin separate containers.\n\nThis patch also updates the missing documentation in ovn-ctl.8.xml.\n\nSigned-off-by: Numan Siddique <nusiddiq@redhat.com>\n---\n ovn/utilities/ovn-ctl | 15 +++++++++++++--\n ovn/utilities/ovn-ctl.8.xml | 9 +++++++++\n 2 files changed, 22 insertions(+), 2 deletions(-)", "diff": "diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl\nindex 3e247a1c6..8261b82c7 100755\n--- a/ovn/utilities/ovn-ctl\n+++ b/ovn/utilities/ovn-ctl\n@@ -100,7 +100,10 @@ start_nb_ovsdb() {\n \n set ovsdb-server\n \n- set \"$@\" --detach --monitor\n+ if test X\"$DB_NB_DETACH\" = Xyes; then\n+ set \"$@\" --detach --monitor\n+ fi\n+\n set \"$@\" $OVN_NB_LOG --log-file=$OVN_NB_LOGFILE\n set \"$@\" --remote=punix:$DB_NB_SOCK --pidfile=$DB_NB_PID\n set \"$@\" --remote=db:OVN_Northbound,NB_Global,connections\n@@ -135,7 +138,10 @@ start_sb_ovsdb() {\n \n set ovsdb-server\n \n- set \"$@\" --detach --monitor\n+ if test X\"$DB_SB_DETACH\" = Xyes; then\n+ set \"$@\" --detach --monitor\n+ fi\n+\n set \"$@\" $OVN_SB_LOG --log-file=$OVN_SB_LOGFILE\n set \"$@\" --remote=punix:$DB_SB_SOCK --pidfile=$DB_SB_PID\n set \"$@\" --remote=db:OVN_Southbound,SB_Global,connections\n@@ -383,6 +389,9 @@ set_defaults () {\n DB_NB_CREATE_INSECURE_REMOTE=\"no\"\n \n MONITOR=\"yes\"\n+\n+ DB_NB_DETACH=\"yes\"\n+ DB_SB_DETACH=\"yes\"\n }\n \n set_option () {\n@@ -469,6 +478,8 @@ File location options:\n --db-sb-sync-from-port=ADDR OVN Southbound active db tcp port (default: $DB_SB_SYNC_FROM_PORT)\n --db-sb-sync-from-proto=PROTO OVN Southbound active db transport (default: $DB_SB_SYNC_FROM_PROTO)\n --db-sb-create-insecure-remote=yes|no Create ptcp OVN Southbound remote (default: $DB_SB_CREATE_INSECURE_REMOTE)\n+ --db-nb-detach=yes|no OVN_Northbound detach server (default: $DB_NB_DETACH)\n+ --db-sb-detach=yes|no OVN_Southbound detach server (default: $DB_SB_DETACH)\n \n Default directories with \"configure\" option and environment variable override:\n logs: /usr/local/var/log/openvswitch (--with-logdir, OVS_LOGDIR)\ndiff --git a/ovn/utilities/ovn-ctl.8.xml b/ovn/utilities/ovn-ctl.8.xml\nindex 7b090aee4..457475c19 100644\n--- a/ovn/utilities/ovn-ctl.8.xml\n+++ b/ovn/utilities/ovn-ctl.8.xml\n@@ -28,6 +28,13 @@\n <dt><code>demote_ovnsb</code></dt>\n <dt><code>status_ovnnb</code></dt>\n <dt><code>status_ovnsb</code></dt>\n+ <dt><code>start_ovsdb</code></dt>\n+ <dt><code>start_nb_ovsdb</code></dt>\n+ <dt><code>start_sb_ovsdb</code></dt>\n+ <dt><code>stop_ovsdb</code></dt>\n+ <dt><code>stop_nb_ovsdb</code></dt>\n+ <dt><code>stop_sb_ovsdb</code></dt>\n+ <dt><code>restart_ovsdb</code></dt>\n </dl>\n \n <h1>Options</h1>\n@@ -35,6 +42,8 @@\n <p><code>--ovn-northd-wrapper=<var>WRAPPER</var></code></p>\n <p><code>--ovn-controller-priority=<var>NICE</var></code></p>\n <p><code>--ovn-controller-wrapper=<var>WRAPPER</var></code></p>\n+ <p><code>--db-nb-detach=<var>yes|no</var></code></p>\n+ <p><code>--db-sb-detach=<var>yes|no</var></code></p>\n <p><code>-h</code> | <code>--help</code></p>\n \n <h1>File location options</h1>\n", "prefixes": [ "ovs-dev" ] }