Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/833307/?format=api
{ "id": 833307, "url": "http://patchwork.ozlabs.org/api/1.2/patches/833307/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20171102111350.3380744-1-arnd@arndb.de/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171102111350.3380744-1-arnd@arndb.de>", "list_archive_url": null, "date": "2017-11-02T11:13:36", "name": "[net-next] net: seeq: fix timer conversion", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "65dbf8c15bd7863f5f159a00ffa0d5c812b870f1", "submitter": { "id": 30, "url": "http://patchwork.ozlabs.org/api/1.2/people/30/?format=api", "name": "Arnd Bergmann", "email": "arnd@arndb.de" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20171102111350.3380744-1-arnd@arndb.de/mbox/", "series": [ { "id": 11482, "url": "http://patchwork.ozlabs.org/api/1.2/series/11482/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=11482", "date": "2017-11-02T11:13:36", "name": "[net-next] net: seeq: fix timer conversion", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/11482/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/833307/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/833307/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySMtQ2hNrz9s9Y\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 2 Nov 2017 22:14:38 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755457AbdKBLOZ (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 2 Nov 2017 07:14:25 -0400", "from mout.kundenserver.de ([217.72.192.75]:62641 \"EHLO\n\tmout.kundenserver.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752308AbdKBLOY (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 2 Nov 2017 07:14:24 -0400", "from wuerfel.lan ([109.193.157.232]) by mrelayeu.kundenserver.de\n\t(mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id\n\t0M2dqH-1dKa870EMv-00sQjq; Thu, 02 Nov 2017 12:13:54 +0100" ], "From": "Arnd Bergmann <arnd@arndb.de>", "To": "\"David S . Miller\" <davem@davemloft.net>", "Cc": "Arnd Bergmann <arnd@arndb.de>, Russell King <linux@armlinux.org.uk>,\n\tKees Cook <keescook@chromium.org>,\n\tlinux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org", "Subject": "[PATCH] [net-next] net: seeq: fix timer conversion", "Date": "Thu, 2 Nov 2017 12:13:36 +0100", "Message-Id": "<20171102111350.3380744-1-arnd@arndb.de>", "X-Mailer": "git-send-email 2.9.0", "X-Provags-ID": "V03:K0:qrDWzow80K9sawYJpQiWBzF4+t6AhRlrVbxi3SbJxzYcC2HKXWd\n\tHPaSFyjyaExFZxhArYWulANpPYypq1604/dMlqtAOzQ0QhHntN0pi5dZKNGT+t/frhFGSVT\n\tF/C+wbjwi+P0hXdlDa6BioC3Wyie6/6E9IsomzOxRLH1IzL7ZZQ3730VmTW6uc3KAFu2Ji6\n\tGP2e2osHWWNkekI6+9oRA==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:HKukd1khbcc=:LnVlvxZ7IHA0PP9I6vEfnK\n\tD8+sXFh0Ms8P3JU8Ty2Ppcna20yL9Ct2TiK9J1cSc4S7j/fkqwFzyuoiXnlpm9gk6x2sZIJdx\n\trsRd4u5U+2k281ZPG8V73CQLG8OKo/jR4wtNgv5zviraCfDjz9wzPGqHkLxL6muATSbHJBhdm\n\ttUctfW6TAVXAI+OmKPfet6aiM9Tkb7MjC2HSaUDRN2R0YupkWivyBodli8ZcEr0YxQCJECzU6\n\tB3MGB0mzYeyVey0g5lpmQTy2xONVoqFtdhE6PpZYxYNAHapsvM7xfvbAreBWFjlZ5u++m3JBe\n\tZke2Z2JoP4KQW/IEfmWQntx0ZtH5MPscqaQ7I1yYPwK/XfGen8P5ziHhBAAXYLgJBezevNhAK\n\tqxz23DL3RxAH6KZ4xT2UaVIOM08xLZuTu32vyKY+AG+sqIbH/o2edGS0aRYXBFPvWWkpEEJbt\n\tGCozgduw0HETxogW7jYnsuGsYY3myO1Wk8xtUNhZKeZJDd8h1FfDfmJBOjzXj+WYH7GCfF9Kk\n\tQX7b4odLGit0+9YMltXIoNl+y5VYWufjOQr91xzRx63TZHAuLhkU10Dc7pVHGftgpPuJSNsvo\n\t4t5a0DiLTH0DTF5LkcJ0PuHkz+DizYSWJosQywBBtae80V+hds7FEHKTuEydXC0qJo2BVIONH\n\t2bFoxAnsUh2jcoOW5DaJP01aOnSSGwNuCPLRjBbKHsd6Wp7hPhEcGS1wc39lV+bfJ14Uc0Cr8\n\tZmLPm+84ps7JW9vmf6Rl5qDQ4hDCbmg4DRjPzA==", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "One of the timer conversion patches evidently escaped build testing\nuntil I ran into in on ARM randconfig builds:\n\ndrivers/net/ethernet/seeq/ether3.c: In function 'ether3_ledoff':\ndrivers/net/ethernet/seeq/ether3.c:175:40: error: 'priv' undeclared (first use in this function); did you mean 'pid'?\ndrivers/net/ethernet/seeq/ether3.c:176:27: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]\n\nThis fixes the two small typos that caused the problems.\n\nFixes: 6fd9c53f7186 (\"net: seeq: Convert timers to use timer_setup()\")\nSigned-off-by: Arnd Bergmann <arnd@arndb.de>\n---\n drivers/net/ethernet/seeq/ether3.c | 2 +-\n drivers/net/ethernet/seeq/ether3.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/seeq/ether3.c b/drivers/net/ethernet/seeq/ether3.c\nindex da4807723a06..c5bc124b41a9 100644\n--- a/drivers/net/ethernet/seeq/ether3.c\n+++ b/drivers/net/ethernet/seeq/ether3.c\n@@ -172,7 +172,7 @@ ether3_setbuffer(struct net_device *dev, buffer_rw_t read, int start)\n */\n static void ether3_ledoff(struct timer_list *t)\n {\n-\tstruct dev_priv *private = from_timer(priv, t, timer);\n+\tstruct dev_priv *private = from_timer(private, t, timer);\n \tstruct net_device *dev = private->dev;\n \n \tether3_outw(priv(dev)->regs.config2 |= CFG2_CTRLO, REG_CONFIG2);\ndiff --git a/drivers/net/ethernet/seeq/ether3.h b/drivers/net/ethernet/seeq/ether3.h\nindex ea2ba286e665..be19e5fa5cf2 100644\n--- a/drivers/net/ethernet/seeq/ether3.h\n+++ b/drivers/net/ethernet/seeq/ether3.h\n@@ -165,7 +165,7 @@ struct dev_priv {\n unsigned char tx_tail;\t\t/* buffer nr of transmitting packet\t */\n unsigned int rx_head;\t\t/* address to fetch next packet from\t */\n struct timer_list timer;\n- net_device *dev;\n+ struct net_device *dev;\n int broken;\t\t\t\t/* 0 = ok, 1 = something went wrong\t */\n };\n \n", "prefixes": [ "net-next" ] }