Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/833303/?format=api
{ "id": 833303, "url": "http://patchwork.ozlabs.org/api/1.2/patches/833303/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20171102110903.2886660-1-arnd@arndb.de/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171102110903.2886660-1-arnd@arndb.de>", "list_archive_url": null, "date": "2017-11-02T11:08:53", "name": "ath10k: move pci suspend/resume functions", "commit_ref": null, "pull_url": null, "state": "awaiting-upstream", "archived": true, "hash": "e315e8973948af2d8347989db51aad1dc7742328", "submitter": { "id": 30, "url": "http://patchwork.ozlabs.org/api/1.2/people/30/?format=api", "name": "Arnd Bergmann", "email": "arnd@arndb.de" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20171102110903.2886660-1-arnd@arndb.de/mbox/", "series": [ { "id": 11478, "url": "http://patchwork.ozlabs.org/api/1.2/series/11478/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=11478", "date": "2017-11-02T11:08:53", "name": "ath10k: move pci suspend/resume functions", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/11478/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/833303/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/833303/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySMnH5Xnkz9s9Y\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 2 Nov 2017 22:10:11 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755854AbdKBLJs (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 2 Nov 2017 07:09:48 -0400", "from mout.kundenserver.de ([217.72.192.74]:61691 \"EHLO\n\tmout.kundenserver.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755842AbdKBLJp (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 2 Nov 2017 07:09:45 -0400", "from wuerfel.lan ([109.193.157.232]) by mrelayeu.kundenserver.de\n\t(mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id\n\t0LZvn3-1dRCzH3BRF-00lpB8; Thu, 02 Nov 2017 12:09:06 +0100" ], "From": "Arnd Bergmann <arnd@arndb.de>", "To": "Kalle Valo <kvalo@qca.qualcomm.com>", "Cc": "Arnd Bergmann <arnd@arndb.de>, Ryan Hsu <ryanhsu@qti.qualcomm.com>,\n\tGovind Singh <govinds@qti.qualcomm.com>,\n\tSrinivas Kandagatla <srinivas.kandagatla@linaro.org>,\n\tAshok Raj Nagarajan <arnagara@qti.qualcomm.com>,\n\tBen Greear <greearb@candelatech.com>,\n\tBrian Norris <briannorris@chromium.org>,\n\tColin Ian King <colin.king@canonical.com>,\n\tath10k@lists.infradead.org, linux-wireless@vger.kernel.org,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org", "Subject": "[PATCH] ath10k: move pci suspend/resume functions", "Date": "Thu, 2 Nov 2017 12:08:53 +0100", "Message-Id": "<20171102110903.2886660-1-arnd@arndb.de>", "X-Mailer": "git-send-email 2.9.0", "X-Provags-ID": "V03:K0:KRinh/Ctkc9Qa3fJoQtPt8H3Kmj8feCkxXPI3+unK2vh2rTU8ss\n\tGYyZP8kPnfU2t9j5GjOyA8imm9p+ZPgxgaKpNexSFQZy+ueEBfFLkMCy+NTzU/YeJ14RAg5\n\tRfv1XM6L8qTmbZCqdXjI+jR23gYPkaijTRBMETmxQmGtS9QHB+cQPl8R+CBNaE9y9S8zD5h\n\tSSziXqTWvCOCy8xPE7XcQ==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:TOiLmo1QlxE=:umwTVvE5kMtq6+aK+7Hyll\n\tURUmC4qZsITzYALS6hQZrKMNREQvpYLzARZHzuiBYhaMrrD3xoF4gOUz9cwwsfj1Hj5rYEnFm\n\ti9Pi2wMD+FFitxjPK/VlN42elBumWktE98g036ipD/eZG0dgb6OZBIMFPGFAYqNXHjPHxgayW\n\ttbx8DLNJLMOJfBBjKRRzDQ4dAz1uHVS7m0g4ARnqszU6IbKnnXL0UR7q6f5nqXy8f2VvrizxQ\n\t8mS9DWxOtIR1yxWqnWEf8DvfgHeskWyRCnUBjR9xaH4WhJF1bYnlLgBFPcCZj76N3FHTnZjaJ\n\teAXF3S63m86T/ccXXlm1/X6O4Zp1mkr2P+aMvQuFMvHXlAUvRPUqykF/CMiNPB35WGHc8mzUL\n\tH8C+7yYaXs36AxbqlreNr8X9CM0FZPIM4yu7UW6gOdx3zzmlKoD1cnkt20lzEWPAURsMD1KnN\n\terA41+2YGwMwOktn2XDyskoaUTuLCg+tJBqAD9BW2hooFemJXWx8pwtKm/cbGUSRbf2zYRK1K\n\tF4zfM7KCubCZT01RKDxXHnr1cM2ajTSNiKVmxvKqYYwIx2e8zmSvDG+s12sR2tqvqe1krBQGu\n\tCkmdH/vuk8XGGOGyNPedhi7nT9Lxlejd8y3nJDMvnDfhUpXW/LfFMz2UamkXdjrNG6nCzb5C4\n\tno1rNzGfUIJiYTaMOHkFZilSlT1AN/YURAhBJiwEl9chY/5YG+XQLy3v/UclQCEY2f0r1O4pg\n\tUe5fIFDrHItCA6q2ThNmQvTPPlSlE27qlsQqeQ==", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "The combination of two patches has led to a build failure:\n\ndrivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_suspend':\ndrivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit declaration of function 'ath10k_pci_suspend'; did you mean 'ath10k_pci_pm_suspend'? [-Werror=implicit-function-declaration]\ndrivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_resume':\ndrivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit declaration of function 'ath10k_pci_resume'; did you mean 'ath10k_pci_pm_resume'? [-Werror=implicit-function-declaration]\n\nThis moves the functions outside of the now incorrect #ifdef.\n\nFixes: 96378bd2c6cd (\"ath10k: fix core PCI suspend when WoWLAN is supported but disabled\")\nFixes: 6af1de2e4ec4 (\"ath10k: mark PM functions as __maybe_unused\")\nSigned-off-by: Arnd Bergmann <arnd@arndb.de>\n---\n drivers/net/wireless/ath/ath10k/pci.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c\nindex b18a9b690df4..6513edbd86e6 100644\n--- a/drivers/net/wireless/ath/ath10k/pci.c\n+++ b/drivers/net/wireless/ath/ath10k/pci.c\n@@ -2585,6 +2585,13 @@ static int ath10k_pci_hif_suspend(struct ath10k *ar)\n \treturn 0;\n }\n \n+static int ath10k_pci_hif_resume(struct ath10k *ar)\n+{\n+\t/* Nothing to do; the important stuff is in the driver resume. */\n+\treturn 0;\n+}\n+#endif\n+\n static int ath10k_pci_suspend(struct ath10k *ar)\n {\n \t/* The grace timer can still be counting down and ar->ps_awake be true.\n@@ -2597,12 +2604,6 @@ static int ath10k_pci_suspend(struct ath10k *ar)\n \treturn 0;\n }\n \n-static int ath10k_pci_hif_resume(struct ath10k *ar)\n-{\n-\t/* Nothing to do; the important stuff is in the driver resume. */\n-\treturn 0;\n-}\n-\n static int ath10k_pci_resume(struct ath10k *ar)\n {\n \tstruct ath10k_pci *ar_pci = ath10k_pci_priv(ar);\n@@ -2627,7 +2628,6 @@ static int ath10k_pci_resume(struct ath10k *ar)\n \n \treturn ret;\n }\n-#endif\n \n static bool ath10k_pci_validate_cal(void *data, size_t size)\n {\n", "prefixes": [] }