Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 833267,
    "url": "http://patchwork.ozlabs.org/api/1.2/patches/833267/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20171102093648.4141-1-privat@egil-hjelmeland.no/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20171102093648.4141-1-privat@egil-hjelmeland.no>",
    "list_archive_url": null,
    "date": "2017-11-02T09:36:48",
    "name": "[net-next] net: Define eth_stp_addr in linux/etherdevice.h",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a5e33b1c38d0aa9b322e445589aafa170bef8b10",
    "submitter": {
        "id": 72044,
        "url": "http://patchwork.ozlabs.org/api/1.2/people/72044/?format=api",
        "name": "Egil Hjelmeland",
        "email": "privat@egil-hjelmeland.no"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20171102093648.4141-1-privat@egil-hjelmeland.no/mbox/",
    "series": [
        {
            "id": 11461,
            "url": "http://patchwork.ozlabs.org/api/1.2/series/11461/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=11461",
            "date": "2017-11-02T09:36:48",
            "name": "[net-next] net: Define eth_stp_addr in linux/etherdevice.h",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/11461/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/833267/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/833267/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySKkG15d2z9s7c\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  2 Nov 2017 20:37:26 +1100 (AEDT)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S933460AbdKBJhO (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 2 Nov 2017 05:37:14 -0400",
            "from aibo.runbox.com ([91.220.196.211]:46048 \"EHLO aibo.runbox.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S933294AbdKBJhN (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tThu, 2 Nov 2017 05:37:13 -0400",
            "from [10.9.9.210] (helo=mailfront10.runbox.com)\n\tby mailtransmit03.runbox with esmtp (Exim 4.86_2)\n\t(envelope-from <privat@egil-hjelmeland.no>)\n\tid 1eABvr-0002g9-8z; Thu, 02 Nov 2017 10:37:03 +0100",
            "from 93.89.113.32.ip.vitnett.no ([93.89.113.32]\n\thelo=localhost.localdomain)\n\tby mailfront10.runbox.com with esmtpsa (uid:646232 )\n\t(TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82)\n\tid 1eABvf-00020j-V7; Thu, 02 Nov 2017 10:36:51 +0100"
        ],
        "From": "Egil Hjelmeland <privat@egil-hjelmeland.no>",
        "To": "andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,\n\tf.fainelli@gmail.com, rafal@milecki.pl, stephen@networkplumber.org,\n\tbridge@lists.linux-foundation.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org",
        "Cc": "Egil Hjelmeland <privat@egil-hjelmeland.no>",
        "Subject": "[PATCH net-next] net: Define eth_stp_addr in linux/etherdevice.h",
        "Date": "Thu,  2 Nov 2017 10:36:48 +0100",
        "Message-Id": "<20171102093648.4141-1-privat@egil-hjelmeland.no>",
        "X-Mailer": "git-send-email 2.11.0",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "Why:\nThe lan9303 driver defines eth_stp_addr as a synonym to\neth_reserved_addr_base to get the STP ethernet address 01:80:c2:00:00:00.\n\neth_reserved_addr_base is also used to define the start of Bridge Reserved\nethernet address range, which happen to be the STP address.\n\nbr_dev_setup refer to eth_reserved_addr_base as a definition of STP\naddress.\n\nClean up by:\n - Move the eth_stp_addr definition to linux/etherdevice.h\n - Use eth_stp_addr instead of eth_reserved_addr_base in br_dev_setup.\n\nSigned-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>\n---\n include/linux/dsa/lan9303.h | 2 --\n include/linux/etherdevice.h | 1 +\n net/bridge/br_device.c      | 2 +-\n 3 files changed, 2 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/include/linux/dsa/lan9303.h b/include/linux/dsa/lan9303.h\nindex b2110e69630f..05d8d136baab 100644\n--- a/include/linux/dsa/lan9303.h\n+++ b/include/linux/dsa/lan9303.h\n@@ -34,5 +34,3 @@ struct lan9303 {\n \t **/\n \tstruct lan9303_alr_cache_entry alr_cache[LAN9303_NUM_ALR_RECORDS];\n };\n-\n-#define eth_stp_addr eth_reserved_addr_base\ndiff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h\nindex 2d9f80848d4b..263dbcad22fc 100644\n--- a/include/linux/etherdevice.h\n+++ b/include/linux/etherdevice.h\n@@ -66,6 +66,7 @@ int eth_gro_complete(struct sk_buff *skb, int nhoff);\n /* Reserved Ethernet Addresses per IEEE 802.1Q */\n static const u8 eth_reserved_addr_base[ETH_ALEN] __aligned(2) =\n { 0x01, 0x80, 0xc2, 0x00, 0x00, 0x00 };\n+#define eth_stp_addr eth_reserved_addr_base\n \n /**\n  * is_link_local_ether_addr - Determine if given Ethernet address is link-local\ndiff --git a/net/bridge/br_device.c b/net/bridge/br_device.c\nindex 28bb22186fa0..af5b8c87f590 100644\n--- a/net/bridge/br_device.c\n+++ b/net/bridge/br_device.c\n@@ -421,7 +421,7 @@ void br_dev_setup(struct net_device *dev)\n \tbr->bridge_id.prio[0] = 0x80;\n \tbr->bridge_id.prio[1] = 0x00;\n \n-\tether_addr_copy(br->group_addr, eth_reserved_addr_base);\n+\tether_addr_copy(br->group_addr, eth_stp_addr);\n \n \tbr->stp_enabled = BR_NO_STP;\n \tbr->group_fwd_mask = BR_GROUPFWD_DEFAULT;\n",
    "prefixes": [
        "net-next"
    ]
}