Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/832963/?format=api
{ "id": 832963, "url": "http://patchwork.ozlabs.org/api/1.2/patches/832963/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1509547642-51110-9-git-send-email-lipeng321@huawei.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1509547642-51110-9-git-send-email-lipeng321@huawei.com>", "list_archive_url": null, "date": "2017-11-01T14:47:21", "name": "[net-next,8/9] net: hns3: Fix a misuse to devm_free_irq", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "f5ce6aebc74e3b8595c457c055d0d6b0708b5d64", "submitter": { "id": 71468, "url": "http://patchwork.ozlabs.org/api/1.2/people/71468/?format=api", "name": "lipeng (Y)", "email": "lipeng321@huawei.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1509547642-51110-9-git-send-email-lipeng321@huawei.com/mbox/", "series": [ { "id": 11334, "url": "http://patchwork.ozlabs.org/api/1.2/series/11334/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=11334", "date": "2017-11-01T14:47:14", "name": "net: hns3: add support for reset", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/11334/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/832963/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/832963/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yRr6z3xHTz9sPs\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 2 Nov 2017 01:23:39 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S933117AbdKAOWu (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 1 Nov 2017 10:22:50 -0400", "from szxga06-in.huawei.com ([45.249.212.32]:38428 \"EHLO huawei.com\"\n\trhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1754551AbdKAOVM (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tWed, 1 Nov 2017 10:21:12 -0400", "from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59])\n\tby Forcepoint Email with ESMTP id DFC35AFEFF8E6;\n\tWed, 1 Nov 2017 22:20:58 +0800 (CST)", "from linux-ioko.site (10.71.200.31) by\n\tDGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP\n\tServer id 14.3.361.1; Wed, 1 Nov 2017 22:19:51 +0800" ], "From": "Lipeng <lipeng321@huawei.com>", "To": "<davem@davemloft.net>", "CC": "<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,\n\t<linuxarm@huawei.com>, <yisen.zhuang@huawei.com>,\n\t<salil.mehta@huawei.com>, <lipeng321@huawei.com>", "Subject": "[PATCH net-next 8/9] net: hns3: Fix a misuse to devm_free_irq", "Date": "Wed, 1 Nov 2017 22:47:21 +0800", "Message-ID": "<1509547642-51110-9-git-send-email-lipeng321@huawei.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1509547642-51110-1-git-send-email-lipeng321@huawei.com>", "References": "<1509547642-51110-1-git-send-email-lipeng321@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.71.200.31]", "X-CFilter-Loop": "Reflected", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: qumingguang <qumingguang@huawei.com>\n\nwe should use free_irq to free the nic irq during the unloading time.\nbecause we use request_irq to apply it when nic up. It will crash if\nup net device after reset the port.\nThis patch fixes the issue.\n\nSigned-off-by: qumingguang <qumingguang@huawei.com>\nSigned-off-by: Lipeng <lipeng321@huawei.com>\n---\n drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c\nindex 681a043..8084fff 100644\n--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c\n+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c\n@@ -2558,9 +2558,8 @@ static int hns3_nic_uninit_vector_data(struct hns3_nic_priv *priv)\n \t\t\t(void)irq_set_affinity_hint(\n \t\t\t\tpriv->tqp_vector[i].vector_irq,\n \t\t\t\t\t\t NULL);\n-\t\t\tdevm_free_irq(&pdev->dev,\n-\t\t\t\t priv->tqp_vector[i].vector_irq,\n-\t\t\t\t &priv->tqp_vector[i]);\n+\t\t\tfree_irq(priv->tqp_vector[i].vector_irq,\n+\t\t\t\t &priv->tqp_vector[i]);\n \t\t}\n \n \t\tpriv->ring_data[i].ring->irq_init_flag = HNS3_VECTOR_NOT_INITED;\n", "prefixes": [ "net-next", "8/9" ] }