Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/831196/?format=api
{ "id": 831196, "url": "http://patchwork.ozlabs.org/api/1.2/patches/831196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/20171027105045.939-1-hegdevasant@linux.vnet.ibm.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/1.2/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171027105045.939-1-hegdevasant@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-10-27T10:50:45", "name": "FSP/CONSOLE: Disable notification on unresponsive consoles", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "82ada21dc76b865ba844f03e3dfb93aebb37977e", "submitter": { "id": 22361, "url": "http://patchwork.ozlabs.org/api/1.2/people/22361/?format=api", "name": "Vasant Hegde", "email": "hegdevasant@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/20171027105045.939-1-hegdevasant@linux.vnet.ibm.com/mbox/", "series": [ { "id": 10554, "url": "http://patchwork.ozlabs.org/api/1.2/series/10554/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/list/?series=10554", "date": "2017-10-27T10:50:45", "name": "FSP/CONSOLE: Disable notification on unresponsive consoles", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/10554/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/831196/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/831196/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yNgf15b5xz9t2Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 27 Oct 2017 21:51:05 +1100 (AEDT)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yNgf13sKKzDrbm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 27 Oct 2017 21:51:05 +1100 (AEDT)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yNgdv0ny2zDqfh\n\tfor <skiboot@lists.ozlabs.org>; Fri, 27 Oct 2017 21:50:58 +1100 (AEDT)", "from pps.filterd (m0098410.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv9RAo0It116304\n\tfor <skiboot@lists.ozlabs.org>; Fri, 27 Oct 2017 06:50:54 -0400", "from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2dv0y9fuv2-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Fri, 27 Oct 2017 06:50:54 -0400", "from localhost\n\tby e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <hegdevasant@linux.vnet.ibm.com>; \n\tFri, 27 Oct 2017 11:50:52 +0100", "from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198)\n\tby e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tFri, 27 Oct 2017 11:50:51 +0100", "from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com\n\t[9.149.105.62])\n\tby b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v9RAopxX24051858; Fri, 27 Oct 2017 10:50:51 GMT", "from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id F410CAE057;\n\tFri, 27 Oct 2017 11:44:43 +0100 (BST)", "from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 26967AE045;\n\tFri, 27 Oct 2017 11:44:43 +0100 (BST)", "from hegdevasant.in.ibm.com (unknown [9.109.222.221])\n\tby d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tFri, 27 Oct 2017 11:44:42 +0100 (BST)" ], "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=hegdevasant@linux.vnet.ibm.com; receiver=<UNKNOWN>)", "From": "Vasant Hegde <hegdevasant@linux.vnet.ibm.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Fri, 27 Oct 2017 16:20:45 +0530", "X-Mailer": "git-send-email 2.9.3", "X-TM-AS-GCONF": "00", "x-cbid": "17102710-0020-0000-0000-000003C58ADA", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17102710-0021-0000-0000-0000425A7225", "Message-Id": "<20171027105045.939-1-hegdevasant@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-10-27_05:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0\n\tclassifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1707230000\n\tdefinitions=main-1710270147", "Subject": "[Skiboot] [PATCH] FSP/CONSOLE: Disable notification on unresponsive\n\tconsoles", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "Cc": "sam@mendozajonas.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Commit fd6b71fc fixed the situation where ipmi console was open (hvc0) but got\ndata on different console (hvc1).\n\nDuring FSP R/R OPAL closes all consoles. After R/R complete FSP requests to\nopen hvc1 and sends data on this. If hvc1 registration failed or not opened in\nhost kernel then it will not read data and results in RCU stalls.\n\nNote that this is workaround for older kernel where we don't have separate irq\nfor each console. Latest kernel works fine without this patch.\n\nCC: stable\nCC: Sam Mendoza-Jonas <sam@mendozajonas.com>\nSigned-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>\n---\n hw/fsp/fsp-console.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/hw/fsp/fsp-console.c b/hw/fsp/fsp-console.c\nindex e3628d7..8d845d8 100644\n--- a/hw/fsp/fsp-console.c\n+++ b/hw/fsp/fsp-console.c\n@@ -704,6 +704,7 @@ static int64_t fsp_console_read(int64_t term_number, int64_t *length,\n \tstruct fsp_serbuf_hdr *sb;\n \tbool pending = false;\n \tuint32_t old_nin, n, i, chunk, req = *length;\n+\tint rc = OPAL_SUCCESS;\n \n \tif (term_number < 0 || term_number >= MAX_SERIAL)\n \t\treturn OPAL_PARAMETER;\n@@ -712,8 +713,8 @@ static int64_t fsp_console_read(int64_t term_number, int64_t *length,\n \t\treturn OPAL_PARAMETER;\n \tlock(&fsp_con_lock);\n \tif (!fs->open) {\n-\t\tunlock(&fsp_con_lock);\n-\t\treturn OPAL_CLOSED;\n+\t\trc = OPAL_CLOSED;\n+\t\tgoto clr_flag;\n \t}\n \tif (fs->waiting)\n \t\tfs->waiting = 0;\n@@ -744,6 +745,7 @@ static int64_t fsp_console_read(int64_t term_number, int64_t *length,\n \t buffer[4], buffer[5], buffer[6], buffer[7]);\n #endif /* OPAL_DEBUG_CONSOLE_IO */\n \n+clr_flag:\n \t/* Might clear the input pending flag */\n \tfor (i = 0; i < MAX_SERIAL && !pending; i++) {\n \t\tstruct fsp_serial *fs = &fsp_serials[i];\n@@ -772,7 +774,7 @@ static int64_t fsp_console_read(int64_t term_number, int64_t *length,\n \n \tunlock(&fsp_con_lock);\n \n-\treturn OPAL_SUCCESS;\n+\treturn rc;\n }\n \n void fsp_console_poll(void *data __unused)\n", "prefixes": [] }