Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/831102/?format=api
{ "id": 831102, "url": "http://patchwork.ozlabs.org/api/1.2/patches/831102/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20171027055445.GA96228@beast/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171027055445.GA96228@beast>", "list_archive_url": null, "date": "2017-10-27T05:54:45", "name": "drivers/net: appletalk/cops: Convert timers to use timer_setup()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "49585b9fd646380f68f8212f535436f1390cdc0d", "submitter": { "id": 10641, "url": "http://patchwork.ozlabs.org/api/1.2/people/10641/?format=api", "name": "Kees Cook", "email": "keescook@chromium.org" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20171027055445.GA96228@beast/mbox/", "series": [ { "id": 10508, "url": "http://patchwork.ozlabs.org/api/1.2/series/10508/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=10508", "date": "2017-10-27T05:54:45", "name": "drivers/net: appletalk/cops: Convert timers to use timer_setup()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/10508/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/831102/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/831102/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"H7loj5Jw\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNY8c25G0z9t2Q\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 27 Oct 2017 16:58:40 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752079AbdJ0Fyw (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 27 Oct 2017 01:54:52 -0400", "from mail-pg0-f66.google.com ([74.125.83.66]:55363 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751530AbdJ0Fys (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 27 Oct 2017 01:54:48 -0400", "by mail-pg0-f66.google.com with SMTP id 15so4496639pgc.12\n\tfor <netdev@vger.kernel.org>; Thu, 26 Oct 2017 22:54:48 -0700 (PDT)", "from www.outflux.net\n\t(173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133])\n\tby smtp.gmail.com with ESMTPSA id\n\tc22sm12954363pfe.177.2017.10.26.22.54.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 26 Oct 2017 22:54:46 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google;\n\th=date:from:to:cc:subject:message-id:mime-version:content-disposition;\n\tbh=pY4kkHa+6BwvrDN3g2iw4UlkTErKO/fZ6xybUKNDNZ0=;\n\tb=H7loj5JwQjJyUZQ4CFMdV/rLKONNd9oQlfAdQC9balRFO3unba8/W5lcd3xzOn/RyR\n\tmhFzCf9RxhMkGWM8qjW63jLGuFOZA2CYeTfynUdwGiz/WIECcqg32v61Yf+gIYlxZOcP\n\t1ztaxu4YWrDXWDmcHovfzG3EoBW2FrgfpcxDg=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version\n\t:content-disposition;\n\tbh=pY4kkHa+6BwvrDN3g2iw4UlkTErKO/fZ6xybUKNDNZ0=;\n\tb=duSL4i3pJfEgTbDcQngxFLFsWrQHeTdinfmZm54ZY4lt1MKPuMvgwWy7hrzUwCBKS3\n\tvQzE4Pb+AA/gBqihjgwHGJJxxCgYL3aOlR8Yjcqm8JKPj16dTOWqG2nA9jojYxrEWyE6\n\tCweFVcE5kV4Em9R2zT+fvQm3nAZBzfOd08B22i6/bYkuM1oT6RAmMIlmQBEd9sXagvhE\n\tjJjJNQgptvWq5E4PRg4lFdluKWwq8fEkhMaIcwTINNxF/KL8jHS3dR34oqhbbpNngscD\n\tG5qjeTa3Qc+/SPm0yd1dnt26j1PFmI169OYG18LyI68vwS7x6lpD6H7OWNuk5m4mgZEL\n\tnfPg==", "X-Gm-Message-State": "AMCzsaWAKWl7+2XNkMin9OKM97SW+sKv70O0ZOjof9Yk9KaNtUXwsffc\n\tgCO2Ze/7WWyLpz90yryId2Qp4w==", "X-Google-Smtp-Source": "ABhQp+SlU18VUA+1lLdk7XN5/zKu1p0ChgC19TObvb4kehXxyIfXId1nNrgv/ECPU2Nm3M30MNipOA==", "X-Received": "by 10.98.0.206 with SMTP id 197mr7781528pfa.194.1509083687755;\n\tThu, 26 Oct 2017 22:54:47 -0700 (PDT)", "Date": "Thu, 26 Oct 2017 22:54:45 -0700", "From": "Kees Cook <keescook@chromium.org>", "To": "\"David S. Miller\" <davem@davemloft.net>", "Cc": "Allen Pais <allen.lkml@gmail.com>,\n\tDavid Howells <dhowells@redhat.com>, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org", "Subject": "[PATCH] drivers/net: appletalk/cops: Convert timers to use\n\ttimer_setup()", "Message-ID": "<20171027055445.GA96228@beast>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "In preparation for unconditionally passing the struct timer_list pointer to\nall timer callbacks, switch to using the new timer_setup() and from_timer()\nto pass the timer pointer explicitly.\n\nCc: Allen Pais <allen.lkml@gmail.com>\nCc: \"David S. Miller\" <davem@davemloft.net>\nCc: David Howells <dhowells@redhat.com>\nCc: netdev@vger.kernel.org\nSigned-off-by: Kees Cook <keescook@chromium.org>\n---\n drivers/net/appletalk/cops.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/appletalk/cops.c b/drivers/net/appletalk/cops.c\nindex caf04284711a..bb49f6e40a19 100644\n--- a/drivers/net/appletalk/cops.c\n+++ b/drivers/net/appletalk/cops.c\n@@ -155,6 +155,7 @@ static int cops_irqlist[] = {\n };\n \n static struct timer_list cops_timer;\n+static struct net_device *cops_timer_dev;\n \n /* use 0 for production, 1 for verification, 2 for debug, 3 for verbose debug */\n #ifndef COPS_DEBUG\n@@ -187,7 +188,7 @@ static void cops_load (struct net_device *dev);\n static int cops_nodeid (struct net_device *dev, int nodeid);\n \n static irqreturn_t cops_interrupt (int irq, void *dev_id);\n-static void cops_poll (unsigned long ltdev);\n+static void cops_poll(struct timer_list *t);\n static void cops_timeout(struct net_device *dev);\n static void cops_rx (struct net_device *dev);\n static netdev_tx_t cops_send_packet (struct sk_buff *skb,\n@@ -424,7 +425,8 @@ static int cops_open(struct net_device *dev)\n \t\t */\n \t\tif(lp->board==TANGENT)\t/* Poll 20 times per second */\n \t\t{\n-\t\t setup_timer(&cops_timer, cops_poll, (unsigned long)dev);\n+\t\t cops_timer_dev = dev;\n+\t\t timer_setup(&cops_timer, cops_poll, 0);\n \t\t cops_timer.expires \t= jiffies + HZ/20;\n \t\t add_timer(&cops_timer);\n \t\t} \n@@ -671,12 +673,11 @@ static int cops_nodeid (struct net_device *dev, int nodeid)\n *\tPoll the Tangent type cards to see if we have work.\n */\n \n-static void cops_poll(unsigned long ltdev)\n+static void cops_poll(struct timer_list *unused)\n {\n \tint ioaddr, status;\n \tint boguscount = 0;\n-\n-\tstruct net_device *dev = (struct net_device *)ltdev;\n+\tstruct net_device *dev = cops_timer_dev;\n \n \tdel_timer(&cops_timer);\n \n", "prefixes": [] }