Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/831079/?format=api
{ "id": 831079, "url": "http://patchwork.ozlabs.org/api/1.2/patches/831079/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20171027045510.5827-12-edumazet@google.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171027045510.5827-12-edumazet@google.com>", "list_archive_url": null, "date": "2017-10-27T04:55:06", "name": "[v2,net-next,11/15] tcp: Namespace-ify sysctl_tcp_max_reordering", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e5201bb09fd3fa91eb8a5bd4c58c5d22ba3411b9", "submitter": { "id": 13357, "url": "http://patchwork.ozlabs.org/api/1.2/people/13357/?format=api", "name": "Eric Dumazet", "email": "edumazet@google.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20171027045510.5827-12-edumazet@google.com/mbox/", "series": [ { "id": 10492, "url": "http://patchwork.ozlabs.org/api/1.2/series/10492/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=10492", "date": "2017-10-27T04:54:55", "name": "tcp: move 14 sysctls to namespaces", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/10492/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/831079/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/831079/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"czkYpMb3\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNWm83Hd1z9t30\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 27 Oct 2017 15:55:52 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752046AbdJ0Ezt (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 27 Oct 2017 00:55:49 -0400", "from mail-io0-f193.google.com ([209.85.223.193]:55920 \"EHLO\n\tmail-io0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751947AbdJ0Ezj (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 27 Oct 2017 00:55:39 -0400", "by mail-io0-f193.google.com with SMTP id p186so10094016ioe.12\n\tfor <netdev@vger.kernel.org>; Thu, 26 Oct 2017 21:55:39 -0700 (PDT)", "from localhost ([2620:15c:2c4:201:c5be:583d:61a8:d070])\n\tby smtp.gmail.com with ESMTPSA id\n\te77sm471863itc.25.2017.10.26.21.55.37\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tThu, 26 Oct 2017 21:55:37 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Goyblv+ZZc50IvxeGi9UID5ShHraMtbs/BjUFS28gbs=;\n\tb=czkYpMb3pCM7woO1QqyJuVvLzBYBBZ+79s4KtFIE2OwyyiaCev1XAjTePrmkRa+w39\n\tFrSkplpS5MxRZFeFQvC2E4dyE96UfhMGIXvk1ZRiZiwHHoBvD1SXWABEHCSQ4v2Z9Vh3\n\tEIecEEC4EeRWvHRsi1BR8IUvKG/YU+mf/8YIVtN36E0YPLEp8C+cCIXYR/Vrh4jHmjgZ\n\tvwBkHWkACh+bn3TwcDOFo6r5bHHi+MP7MyKZqJwyxE/bxFI5L3ENzNepce7/YQ/5Khwh\n\t6TAblS7VdYpCis/AON1/YANQEJmMFUzpOcOSWDK6AYgNCPqK/s6t04FfTLVQy0sX4uz0\n\t2N3w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Goyblv+ZZc50IvxeGi9UID5ShHraMtbs/BjUFS28gbs=;\n\tb=V0hcUREzM3l1Y9W8QykqOY9pOvnWtvkqc2ds9RdDSLvvqt7BJ2dTgy4oopdARNZOYc\n\tcu9ujA7aG6+AlXVoE9h8i/KeRr8AueHAP1jo21Mo6QJtCkWZLfGeX0BZi6CCTM/1Qs+h\n\tWm+jMMLqR+imp4KovdGHeh7+s7nrhgPkpBVTJ2goiNLfpDG3ZxWb5Nza46cGRHF6tAEF\n\tdxfuKQ73o5lGihnCMAUmtmXQ/FBts9B0rO07LdcsejxVFWEAoM9ovPrUG0MNRp09+3FN\n\tK8Vdi/GmJ0kIXkPibm8Z6bMPdYgZzxglNf4dglrtFEeKnB+Cm2P5fk38k7nP8GyZqmXd\n\t9/hw==", "X-Gm-Message-State": "AMCzsaXACXkbsFeF/M95wLmyRd6UA/N8fKcunJhfO437tsAFEcwELcEr\n\t0g47IMVuJp99lukFTmfbLiaZSA==", "X-Google-Smtp-Source": "ABhQp+RrMbMWdhDJbdrTwdml7ug3VMuXP+reiXFJ/x0mto9c9wX/V2OuRjDk9UrXYhchaugMVWMjiA==", "X-Received": "by 10.36.121.150 with SMTP id z144mr1724336itc.28.1509080137955; \n\tThu, 26 Oct 2017 21:55:37 -0700 (PDT)", "From": "Eric Dumazet <edumazet@google.com>", "To": "\"David S . Miller\" <davem@davemloft.net>", "Cc": "netdev <netdev@vger.kernel.org>, Eric Dumazet <edumazet@google.com>,\n\tEric Dumazet <eric.dumazet@gmail.com>", "Subject": "[PATCH v2 net-next 11/15] tcp: Namespace-ify\n\tsysctl_tcp_max_reordering", "Date": "Thu, 26 Oct 2017 21:55:06 -0700", "Message-Id": "<20171027045510.5827-12-edumazet@google.com>", "X-Mailer": "git-send-email 2.15.0.rc2.357.g7e34df9404-goog", "In-Reply-To": "<20171027045510.5827-1-edumazet@google.com>", "References": "<20171027045510.5827-1-edumazet@google.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Signed-off-by: Eric Dumazet <edumazet@google.com>\n---\n include/net/netns/ipv4.h | 1 +\n include/net/tcp.h | 1 -\n net/ipv4/sysctl_net_ipv4.c | 14 +++++++-------\n net/ipv4/tcp_input.c | 3 +--\n net/ipv4/tcp_ipv4.c | 2 ++\n 5 files changed, 11 insertions(+), 10 deletions(-)", "diff": "diff --git a/include/net/netns/ipv4.h b/include/net/netns/ipv4.h\nindex f0e792beeea974b0850090d7624a3d7490124067..3f6844665a2fbe66fc0c91bd13e057ac2e03007a 100644\n--- a/include/net/netns/ipv4.h\n+++ b/include/net/netns/ipv4.h\n@@ -137,6 +137,7 @@ struct netns_ipv4 {\n \tint sysctl_tcp_rfc1337;\n \tint sysctl_tcp_abort_on_overflow;\n \tint sysctl_tcp_fack;\n+\tint sysctl_tcp_max_reordering;\n \tstruct inet_timewait_death_row tcp_death_row;\n \tint sysctl_max_syn_backlog;\n \tint sysctl_tcp_fastopen;\ndiff --git a/include/net/tcp.h b/include/net/tcp.h\nindex fc134ba74c7d38d08304b5be36506946784538f2..8cd286226a1eca27d97b9f182d1a951b072e4575 100644\n--- a/include/net/tcp.h\n+++ b/include/net/tcp.h\n@@ -244,7 +244,6 @@ void tcp_time_wait(struct sock *sk, int state, int timeo);\n \n /* sysctl variables for tcp */\n extern int sysctl_tcp_max_orphans;\n-extern int sysctl_tcp_max_reordering;\n extern int sysctl_tcp_dsack;\n extern long sysctl_tcp_mem[3];\n extern int sysctl_tcp_wmem[3];\ndiff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c\nindex 1f23be13ce7be8b2a12b82aada36c6351fdfb70a..18cd228a20690541936dd6b3d9bb02cb283a9740 100644\n--- a/net/ipv4/sysctl_net_ipv4.c\n+++ b/net/ipv4/sysctl_net_ipv4.c\n@@ -414,13 +414,6 @@ static struct ctl_table ipv4_table[] = {\n \t\t.mode\t\t= 0644,\n \t\t.proc_handler\t= proc_dointvec_jiffies,\n \t},\n-\t{\n-\t\t.procname\t= \"tcp_max_reordering\",\n-\t\t.data\t\t= &sysctl_tcp_max_reordering,\n-\t\t.maxlen\t\t= sizeof(int),\n-\t\t.mode\t\t= 0644,\n-\t\t.proc_handler\t= proc_dointvec\n-\t},\n \t{\n \t\t.procname\t= \"tcp_dsack\",\n \t\t.data\t\t= &sysctl_tcp_dsack,\n@@ -1145,6 +1138,13 @@ static struct ctl_table ipv4_net_table[] = {\n \t\t.mode\t\t= 0644,\n \t\t.proc_handler\t= proc_dointvec\n \t},\n+\t{\n+\t\t.procname\t= \"tcp_max_reordering\",\n+\t\t.data\t\t= &init_net.ipv4.sysctl_tcp_max_reordering,\n+\t\t.maxlen\t\t= sizeof(int),\n+\t\t.mode\t\t= 0644,\n+\t\t.proc_handler\t= proc_dointvec\n+\t},\n \t{ }\n };\n \ndiff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c\nindex c5b94460793f9693719b38978c123209e2b6ec0f..c118657f06ee390053e38c35f03bea5b82845513 100644\n--- a/net/ipv4/tcp_input.c\n+++ b/net/ipv4/tcp_input.c\n@@ -79,7 +79,6 @@\n #include <linux/unaligned/access_ok.h>\n #include <linux/static_key.h>\n \n-int sysctl_tcp_max_reordering __read_mostly = 300;\n int sysctl_tcp_dsack __read_mostly = 1;\n int sysctl_tcp_app_win __read_mostly = 31;\n int sysctl_tcp_adv_win_scale __read_mostly = 1;\n@@ -889,7 +888,7 @@ static void tcp_update_reordering(struct sock *sk, const int metric,\n \t\treturn;\n \n \tif (metric > tp->reordering) {\n-\t\ttp->reordering = min(sysctl_tcp_max_reordering, metric);\n+\t\ttp->reordering = min(sock_net(sk)->ipv4.sysctl_tcp_max_reordering, metric);\n \n #if FASTRETRANS_DEBUG > 1\n \t\tpr_debug(\"Disorder%d %d %u f%u s%u rr%d\\n\",\ndiff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c\nindex 2bc6ba2059d32aa848dbc415b4b0e194b61b0268..c379a242abb3546044da9a3ef032f6f68acafe88 100644\n--- a/net/ipv4/tcp_ipv4.c\n+++ b/net/ipv4/tcp_ipv4.c\n@@ -2488,6 +2488,8 @@ static int __net_init tcp_sk_init(struct net *net)\n \tnet->ipv4.sysctl_tcp_recovery = TCP_RACK_LOSS_DETECTION;\n \tnet->ipv4.sysctl_tcp_slow_start_after_idle = 1; /* By default, RFC2861 behavior. */\n \tnet->ipv4.sysctl_tcp_retrans_collapse = 1;\n+\tnet->ipv4.sysctl_tcp_max_reordering = 300;\n+\n \tnet->ipv4.sysctl_tcp_fastopen = TFO_CLIENT_ENABLE;\n \tspin_lock_init(&net->ipv4.tcp_fastopen_ctx_lock);\n \tnet->ipv4.sysctl_tcp_fastopen_blackhole_timeout = 60 * 60;\n", "prefixes": [ "v2", "net-next", "11/15" ] }