Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/831073/?format=api
{ "id": 831073, "url": "http://patchwork.ozlabs.org/api/1.2/patches/831073/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20171027045510.5827-5-edumazet@google.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171027045510.5827-5-edumazet@google.com>", "list_archive_url": null, "date": "2017-10-27T04:54:59", "name": "[v2,net-next,04/15] tcp: Namespace-ify sysctl_tcp_slow_start_after_idle", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6ad235297989ab2cc0c80af120b868c720a15050", "submitter": { "id": 13357, "url": "http://patchwork.ozlabs.org/api/1.2/people/13357/?format=api", "name": "Eric Dumazet", "email": "edumazet@google.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20171027045510.5827-5-edumazet@google.com/mbox/", "series": [ { "id": 10492, "url": "http://patchwork.ozlabs.org/api/1.2/series/10492/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=10492", "date": "2017-10-27T04:54:55", "name": "tcp: move 14 sysctls to namespaces", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/10492/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/831073/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/831073/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"Yag3i7oq\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNWlk56p3z9t30\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 27 Oct 2017 15:55:30 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751931AbdJ0Ez2 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 27 Oct 2017 00:55:28 -0400", "from mail-io0-f195.google.com ([209.85.223.195]:46662 \"EHLO\n\tmail-io0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751706AbdJ0EzY (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 27 Oct 2017 00:55:24 -0400", "by mail-io0-f195.google.com with SMTP id 101so10131836ioj.3\n\tfor <netdev@vger.kernel.org>; Thu, 26 Oct 2017 21:55:24 -0700 (PDT)", "from localhost ([2620:15c:2c4:201:c5be:583d:61a8:d070])\n\tby smtp.gmail.com with ESMTPSA id\n\ti130sm459712itf.42.2017.10.26.21.55.23\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tThu, 26 Oct 2017 21:55:23 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=YlM91bRJeJ7fh8U6MYWYMMbKVXjeHXNoY0667ZEFVYM=;\n\tb=Yag3i7oqbG+roRu3jWN8HYVNY2U1BtXiH8ItTLVlorWlB9H5wPTYMO65drCOM+odw8\n\taCZ7joAvBPHQTSb8EG5eA5nw6RPPF5ji6tpqZGsyF/U92hawCVLwAVT7WUsjtymL/EKa\n\tADVbW74tcx7Ah9Jh86ZB2IMxrSaRC4IfaGhD8jHJMMTA9BiSN78wqrJmOAUiBY4dsFva\n\tQ9iG6bfiL4xckFXDkhN2rWhtUiGN1SO2YYQn9CinFw0QmAV+Sbokb3mGBEftuD4aJ01o\n\t/tqxA8FwbYH4g5fi9mlT7h4ieHavQU/1cmo7NlqL5xT6w1H5dY2DCSSOqpv4j6CBTV0H\n\tnAOw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=YlM91bRJeJ7fh8U6MYWYMMbKVXjeHXNoY0667ZEFVYM=;\n\tb=XmxnlqLmF5wqa6N9pkY6nMcLovHpRjsZ5EvizTlI+rFgxE7zooG8X8m0WCfnVlAvKq\n\tGWI/py+zrVUdFHZfKyLH/piH5KAX1zcIxuVsrbE9v31A2ijfCI+TIJaq9HnvKIL9Dxme\n\thQgiMlAJvryToP5ppfHRLSCyhfbJJ6Soj+/UGjVwnU9qmwW6BJwrC16xQeNMnZKSX6g3\n\tpTBccYRzwzZCItbCd3g3Gl1z23xN1fPTDbVhK+fDRBcdMiuJpvBN5E9Wqed89kjJfwkL\n\t+/PzvMGANMCJbQgbHfj+DR0PeyjDVl2Q+MpVTxeRsKZJHvpZMPU3fEfwKA0MnVSizHe6\n\tZ+6A==", "X-Gm-Message-State": "AMCzsaVf6MWfBKrUzr+5zWLmGq0h6rRd1aN+eSoyeS5vameSnQbORlIE\n\tTHjMrZYWcMuz219sr8Hol6E01RxYiHw=", "X-Google-Smtp-Source": "ABhQp+SVRMpEZVsixJTHRSBTn3QRX4Im+jp46GbzROXdwdncMpzIKy7XrxYoV8cqlPRL9jBA1EmeMw==", "X-Received": "by 10.107.31.143 with SMTP id f137mr24766285iof.86.1509080123790;\n\tThu, 26 Oct 2017 21:55:23 -0700 (PDT)", "From": "Eric Dumazet <edumazet@google.com>", "To": "\"David S . Miller\" <davem@davemloft.net>", "Cc": "netdev <netdev@vger.kernel.org>, Eric Dumazet <edumazet@google.com>,\n\tEric Dumazet <eric.dumazet@gmail.com>", "Subject": "[PATCH v2 net-next 04/15] tcp: Namespace-ify\n\tsysctl_tcp_slow_start_after_idle", "Date": "Thu, 26 Oct 2017 21:54:59 -0700", "Message-Id": "<20171027045510.5827-5-edumazet@google.com>", "X-Mailer": "git-send-email 2.15.0.rc2.357.g7e34df9404-goog", "In-Reply-To": "<20171027045510.5827-1-edumazet@google.com>", "References": "<20171027045510.5827-1-edumazet@google.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Signed-off-by: Eric Dumazet <edumazet@google.com>\n---\n include/net/netns/ipv4.h | 1 +\n include/net/tcp.h | 3 +--\n net/ipv4/sysctl_net_ipv4.c | 14 +++++++-------\n net/ipv4/tcp_ipv4.c | 1 +\n net/ipv4/tcp_output.c | 5 +----\n 5 files changed, 11 insertions(+), 13 deletions(-)", "diff": "diff --git a/include/net/netns/ipv4.h b/include/net/netns/ipv4.h\nindex 2a9f37b39c45fe451e45025790a4e5c45ece5cbc..8662692686b3af98a94a176230b9ed147881d87a 100644\n--- a/include/net/netns/ipv4.h\n+++ b/include/net/netns/ipv4.h\n@@ -131,6 +131,7 @@ struct netns_ipv4 {\n \tint sysctl_tcp_early_retrans;\n \tint sysctl_tcp_recovery;\n \tint sysctl_tcp_thin_linear_timeouts;\n+\tint sysctl_tcp_slow_start_after_idle;\n \tstruct inet_timewait_death_row tcp_death_row;\n \tint sysctl_max_syn_backlog;\n \tint sysctl_tcp_fastopen;\ndiff --git a/include/net/tcp.h b/include/net/tcp.h\nindex 063a7a48b7fe23092023d053e26a967389628cdc..cc2ab522eb5cf7cb08b6918cdfd5c5500cfbf057 100644\n--- a/include/net/tcp.h\n+++ b/include/net/tcp.h\n@@ -262,7 +262,6 @@ extern int sysctl_tcp_nometrics_save;\n extern int sysctl_tcp_moderate_rcvbuf;\n extern int sysctl_tcp_tso_win_divisor;\n extern int sysctl_tcp_workaround_signed_windows;\n-extern int sysctl_tcp_slow_start_after_idle;\n \n #define TCP_RACK_LOSS_DETECTION 0x1 /* Use RACK to detect losses */\n \n@@ -1308,7 +1307,7 @@ static inline void tcp_slow_start_after_idle_check(struct sock *sk)\n \tstruct tcp_sock *tp = tcp_sk(sk);\n \ts32 delta;\n \n-\tif (!sysctl_tcp_slow_start_after_idle || tp->packets_out ||\n+\tif (!sock_net(sk)->ipv4.sysctl_tcp_slow_start_after_idle || tp->packets_out ||\n \t ca_ops->cong_control)\n \t\treturn;\n \tdelta = tcp_jiffies32 - tp->lsndtime;\ndiff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c\nindex 12003214f4d80b38d5f754ddd91be8a990168ade..40d69af8b363bc236e23879973872d8f9346d85e 100644\n--- a/net/ipv4/sysctl_net_ipv4.c\n+++ b/net/ipv4/sysctl_net_ipv4.c\n@@ -571,13 +571,6 @@ static struct ctl_table ipv4_table[] = {\n \t\t.mode\t\t= 0644,\n \t\t.proc_handler\t= proc_dointvec\n \t},\n-\t{\n-\t\t.procname\t= \"tcp_slow_start_after_idle\",\n-\t\t.data\t\t= &sysctl_tcp_slow_start_after_idle,\n-\t\t.maxlen\t\t= sizeof(int),\n-\t\t.mode\t\t= 0644,\n-\t\t.proc_handler\t= proc_dointvec\n-\t},\n #ifdef CONFIG_NETLABEL\n \t{\n \t\t.procname\t= \"cipso_cache_enable\",\n@@ -1145,6 +1138,13 @@ static struct ctl_table ipv4_net_table[] = {\n \t\t.mode = 0644,\n \t\t.proc_handler = proc_dointvec\n \t},\n+\t{\n+\t\t.procname\t= \"tcp_slow_start_after_idle\",\n+\t\t.data\t\t= &init_net.ipv4.sysctl_tcp_slow_start_after_idle,\n+\t\t.maxlen\t\t= sizeof(int),\n+\t\t.mode\t\t= 0644,\n+\t\t.proc_handler\t= proc_dointvec\n+\t},\n \t{ }\n };\n \ndiff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c\nindex 517ff1948a71287b06ea0859e1f25a15119a3dd9..cea63a4b59655823def7a423d27191003c7f084c 100644\n--- a/net/ipv4/tcp_ipv4.c\n+++ b/net/ipv4/tcp_ipv4.c\n@@ -2486,6 +2486,7 @@ static int __net_init tcp_sk_init(struct net *net)\n \tnet->ipv4.sysctl_tcp_timestamps = 1;\n \tnet->ipv4.sysctl_tcp_early_retrans = 3;\n \tnet->ipv4.sysctl_tcp_recovery = TCP_RACK_LOSS_DETECTION;\n+\tnet->ipv4.sysctl_tcp_slow_start_after_idle = 1; /* By default, RFC2861 behavior. */\n \n \tnet->ipv4.sysctl_tcp_fastopen = TFO_CLIENT_ENABLE;\n \tspin_lock_init(&net->ipv4.tcp_fastopen_ctx_lock);\ndiff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c\nindex 21713836d46af9d48de10e8ec0e7410572ed7eeb..bdc288a06f941add38a5cde434081c63ee94ed42 100644\n--- a/net/ipv4/tcp_output.c\n+++ b/net/ipv4/tcp_output.c\n@@ -62,9 +62,6 @@ int sysctl_tcp_limit_output_bytes __read_mostly = 262144;\n */\n int sysctl_tcp_tso_win_divisor __read_mostly = 3;\n \n-/* By default, RFC2861 behavior. */\n-int sysctl_tcp_slow_start_after_idle __read_mostly = 1;\n-\n static bool tcp_write_xmit(struct sock *sk, unsigned int mss_now, int nonagle,\n \t\t\t int push_one, gfp_t gfp);\n \n@@ -1690,7 +1687,7 @@ static void tcp_cwnd_validate(struct sock *sk, bool is_cwnd_limited)\n \t\tif (tp->packets_out > tp->snd_cwnd_used)\n \t\t\ttp->snd_cwnd_used = tp->packets_out;\n \n-\t\tif (sysctl_tcp_slow_start_after_idle &&\n+\t\tif (sock_net(sk)->ipv4.sysctl_tcp_slow_start_after_idle &&\n \t\t (s32)(tcp_jiffies32 - tp->snd_cwnd_stamp) >= inet_csk(sk)->icsk_rto &&\n \t\t !ca_ops->cong_control)\n \t\t\ttcp_cwnd_application_limited(sk);\n", "prefixes": [ "v2", "net-next", "04/15" ] }