Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/831072/?format=api
{ "id": 831072, "url": "http://patchwork.ozlabs.org/api/1.2/patches/831072/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20171027045510.5827-3-edumazet@google.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171027045510.5827-3-edumazet@google.com>", "list_archive_url": null, "date": "2017-10-27T04:54:57", "name": "[v2,net-next,02/15] tcp: Namespace-ify sysctl_tcp_recovery", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "42a17e13bc59fc8053d818e778f97416408d665b", "submitter": { "id": 13357, "url": "http://patchwork.ozlabs.org/api/1.2/people/13357/?format=api", "name": "Eric Dumazet", "email": "edumazet@google.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20171027045510.5827-3-edumazet@google.com/mbox/", "series": [ { "id": 10492, "url": "http://patchwork.ozlabs.org/api/1.2/series/10492/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=10492", "date": "2017-10-27T04:54:55", "name": "tcp: move 14 sysctls to namespaces", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/10492/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/831072/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/831072/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"ZaxQnH+b\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNWld04bfz9t30\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 27 Oct 2017 15:55:25 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751857AbdJ0EzX (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 27 Oct 2017 00:55:23 -0400", "from mail-io0-f195.google.com ([209.85.223.195]:46653 \"EHLO\n\tmail-io0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751588AbdJ0EzU (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 27 Oct 2017 00:55:20 -0400", "by mail-io0-f195.google.com with SMTP id 101so10131631ioj.3\n\tfor <netdev@vger.kernel.org>; Thu, 26 Oct 2017 21:55:20 -0700 (PDT)", "from localhost ([2620:15c:2c4:201:c5be:583d:61a8:d070])\n\tby smtp.gmail.com with ESMTPSA id\n\tz8sm455179itc.41.2017.10.26.21.55.18\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tThu, 26 Oct 2017 21:55:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=xLba1AOfXyc8Hy5ukNHADgzLoyIX0a8rDrhDJ9orHDw=;\n\tb=ZaxQnH+boXzTH6Is2gJesXka3GQOS8Tjn2p683LyXcFbN8orn7spy4I1Mar+QT6x63\n\tzmEpZaxlsH0ImdMarZl4rCuGR4VwUuecA3/Hi3zOHn1H/ZvThuanvpyA5Hb4ZgF+gpzB\n\tlB4M6QiQyp46Bm9OlEe+Fc0IIPk+UdoEiChen5D+lkkzKlRtNKEHoiUPJAbrchr9s7+h\n\tV0DIXiq0VMN4g7Q27GVrgfC+2ISc4GvEK5AEnAesweJg/vZLuhd8pD/pSRNkCxyl+lQL\n\t4ocyA2pX8Y+7q1nVRcGEptr15z443Vbv8LdPP3D5xpJjdsibSWT2RcJKbZt3eNA9evgz\n\tO/HA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=xLba1AOfXyc8Hy5ukNHADgzLoyIX0a8rDrhDJ9orHDw=;\n\tb=rpjPiADHnBVm/vLshfWkDAAeWrEtE54R4GBh7wlmbdZXsRf5yAxmoheHUhO79qb3vs\n\tShz3uSYeW6BKXhBjLxGMI9W7QDhj8t8XohWOimAm44pErPn270644eaRykGOiPR+au24\n\t2xtDWVWvOrNKPq2D3odFby2iJmNMnwHR17QFPVrM82e5gj53aJWV4zS078g62+7V8Df1\n\tTJidy+pmsQGNRsmhF0WBFXqxfaZljrHIjU5x+D9IOfrvkZPFHe45dIuXZT2Fm/p9lilj\n\tSHsujfnk4HbALM7nNP5Zxk/3g++thre/0ytPr91uzttKYaOiSsEiPYZ1/KlQzbTWd2zs\n\tb+Mw==", "X-Gm-Message-State": "AMCzsaXFYma/q6WgCuCxmHA51TFDcwoVOoIBed8yYcJmw1wObi4ckmWo\n\tWtJwtXITHEUmSY6jaWnXA05B6Q==", "X-Google-Smtp-Source": "ABhQp+TcnnP9Zl5xhqzb8v+gODKg7Dx3tfEmB2s+P3/mnythxIcsMJZGmNrBKTNGlYvmcFuXgALlmg==", "X-Received": "by 10.36.8.136 with SMTP id 130mr1652556itc.18.1509080119486;\n\tThu, 26 Oct 2017 21:55:19 -0700 (PDT)", "From": "Eric Dumazet <edumazet@google.com>", "To": "\"David S . Miller\" <davem@davemloft.net>", "Cc": "netdev <netdev@vger.kernel.org>, Eric Dumazet <edumazet@google.com>,\n\tEric Dumazet <eric.dumazet@gmail.com>", "Subject": "[PATCH v2 net-next 02/15] tcp: Namespace-ify sysctl_tcp_recovery", "Date": "Thu, 26 Oct 2017 21:54:57 -0700", "Message-Id": "<20171027045510.5827-3-edumazet@google.com>", "X-Mailer": "git-send-email 2.15.0.rc2.357.g7e34df9404-goog", "In-Reply-To": "<20171027045510.5827-1-edumazet@google.com>", "References": "<20171027045510.5827-1-edumazet@google.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Signed-off-by: Eric Dumazet <edumazet@google.com>\n---\n include/net/netns/ipv4.h | 1 +\n include/net/tcp.h | 2 +-\n net/ipv4/sysctl_net_ipv4.c | 14 +++++++-------\n net/ipv4/tcp_input.c | 2 +-\n net/ipv4/tcp_ipv4.c | 1 +\n net/ipv4/tcp_recovery.c | 2 --\n 6 files changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/include/net/netns/ipv4.h b/include/net/netns/ipv4.h\nindex a7f39e3ea666a835b6042e4008c86ccaadd14b46..d6ed718075d44cfc0e60995c1e938d588ad261a8 100644\n--- a/include/net/netns/ipv4.h\n+++ b/include/net/netns/ipv4.h\n@@ -129,6 +129,7 @@ struct netns_ipv4 {\n \tint sysctl_tcp_window_scaling;\n \tint sysctl_tcp_timestamps;\n \tint sysctl_tcp_early_retrans;\n+\tint sysctl_tcp_recovery;\n \tstruct inet_timewait_death_row tcp_death_row;\n \tint sysctl_max_syn_backlog;\n \tint sysctl_tcp_fastopen;\ndiff --git a/include/net/tcp.h b/include/net/tcp.h\nindex a12b71d4118baa6b939bdeba7380cb3830d46ff0..c7f51534fc44c61a95225e0adc0a1200ea5c0c1c 100644\n--- a/include/net/tcp.h\n+++ b/include/net/tcp.h\n@@ -265,7 +265,7 @@ extern int sysctl_tcp_workaround_signed_windows;\n extern int sysctl_tcp_slow_start_after_idle;\n extern int sysctl_tcp_thin_linear_timeouts;\n extern int sysctl_tcp_thin_dupack;\n-extern int sysctl_tcp_recovery;\n+\n #define TCP_RACK_LOSS_DETECTION 0x1 /* Use RACK to detect losses */\n \n extern int sysctl_tcp_limit_output_bytes;\ndiff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c\nindex f0f650f020afd535f41943c6c9fb1483be7cfb8d..78019adcae875a438264ee47723670f6b54cacf9 100644\n--- a/net/ipv4/sysctl_net_ipv4.c\n+++ b/net/ipv4/sysctl_net_ipv4.c\n@@ -449,13 +449,6 @@ static struct ctl_table ipv4_table[] = {\n \t\t.mode\t\t= 0644,\n \t\t.proc_handler\t= proc_dointvec\n \t},\n-\t{\n-\t\t.procname\t= \"tcp_recovery\",\n-\t\t.data\t\t= &sysctl_tcp_recovery,\n-\t\t.maxlen\t\t= sizeof(int),\n-\t\t.mode\t\t= 0644,\n-\t\t.proc_handler\t= proc_dointvec,\n-\t},\n \t{\n \t\t.procname\t= \"tcp_max_reordering\",\n \t\t.data\t\t= &sysctl_tcp_max_reordering,\n@@ -1145,6 +1138,13 @@ static struct ctl_table ipv4_net_table[] = {\n \t\t.extra1\t\t= &zero,\n \t\t.extra2\t\t= &four,\n \t},\n+\t{\n+\t\t.procname\t= \"tcp_recovery\",\n+\t\t.data\t\t= &init_net.ipv4.sysctl_tcp_recovery,\n+\t\t.maxlen\t\t= sizeof(int),\n+\t\t.mode\t\t= 0644,\n+\t\t.proc_handler\t= proc_dointvec,\n+\t},\n \t{ }\n };\n \ndiff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c\nindex 7656b1e6d5046297b4c5e6cf5591266b9be40095..5b2272dbf6a9a507d62d8ee594fab53284b22a6d 100644\n--- a/net/ipv4/tcp_input.c\n+++ b/net/ipv4/tcp_input.c\n@@ -2788,7 +2788,7 @@ static void tcp_rack_identify_loss(struct sock *sk, int *ack_flag)\n \tstruct tcp_sock *tp = tcp_sk(sk);\n \n \t/* Use RACK to detect loss */\n-\tif (sysctl_tcp_recovery & TCP_RACK_LOSS_DETECTION) {\n+\tif (sock_net(sk)->ipv4.sysctl_tcp_recovery & TCP_RACK_LOSS_DETECTION) {\n \t\tu32 prior_retrans = tp->retrans_out;\n \n \t\ttcp_rack_mark_lost(sk);\ndiff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c\nindex 7ab313f6768e234173d78f17cfb1f664b230e958..517ff1948a71287b06ea0859e1f25a15119a3dd9 100644\n--- a/net/ipv4/tcp_ipv4.c\n+++ b/net/ipv4/tcp_ipv4.c\n@@ -2485,6 +2485,7 @@ static int __net_init tcp_sk_init(struct net *net)\n \tnet->ipv4.sysctl_tcp_window_scaling = 1;\n \tnet->ipv4.sysctl_tcp_timestamps = 1;\n \tnet->ipv4.sysctl_tcp_early_retrans = 3;\n+\tnet->ipv4.sysctl_tcp_recovery = TCP_RACK_LOSS_DETECTION;\n \n \tnet->ipv4.sysctl_tcp_fastopen = TFO_CLIENT_ENABLE;\n \tspin_lock_init(&net->ipv4.tcp_fastopen_ctx_lock);\ndiff --git a/net/ipv4/tcp_recovery.c b/net/ipv4/tcp_recovery.c\nindex cda6074a429a24b7be600065d95600f4f9810ee4..d3603a9e24eae8649edd12d3f0678015b09b2037 100644\n--- a/net/ipv4/tcp_recovery.c\n+++ b/net/ipv4/tcp_recovery.c\n@@ -1,8 +1,6 @@\n #include <linux/tcp.h>\n #include <net/tcp.h>\n \n-int sysctl_tcp_recovery __read_mostly = TCP_RACK_LOSS_DETECTION;\n-\n static void tcp_rack_mark_skb_lost(struct sock *sk, struct sk_buff *skb)\n {\n \tstruct tcp_sock *tp = tcp_sk(sk);\n", "prefixes": [ "v2", "net-next", "02/15" ] }