Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/831017/?format=api
{ "id": 831017, "url": "http://patchwork.ozlabs.org/api/1.2/patches/831017/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-11-xiyou.wangcong@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171027012443.3306-11-xiyou.wangcong@gmail.com>", "list_archive_url": null, "date": "2017-10-27T01:24:37", "name": "[net,10/16] net_sched: use tcf_queue_work() in route filter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2d79879861db9504f6be4d6fdfe996b427b5acba", "submitter": { "id": 211, "url": "http://patchwork.ozlabs.org/api/1.2/people/211/?format=api", "name": "Cong Wang", "email": "xiyou.wangcong@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-11-xiyou.wangcong@gmail.com/mbox/", "series": [ { "id": 10472, "url": "http://patchwork.ozlabs.org/api/1.2/series/10472/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=10472", "date": "2017-10-27T01:24:27", "name": "net_sched: fix races with RCU callbacks", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/10472/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/831017/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/831017/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"m3ccRVzQ\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNR5P5jFBz9t2h\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 27 Oct 2017 12:25:29 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932465AbdJ0BZ1 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 26 Oct 2017 21:25:27 -0400", "from mail-pg0-f65.google.com ([74.125.83.65]:46471 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932376AbdJ0BZK (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 26 Oct 2017 21:25:10 -0400", "by mail-pg0-f65.google.com with SMTP id k7so4062345pga.3\n\tfor <netdev@vger.kernel.org>; Thu, 26 Oct 2017 18:25:10 -0700 (PDT)", "from tw-172-25-30-113.office.twttr.net ([8.25.197.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tb16sm13211973pfe.58.2017.10.26.18.25.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 26 Oct 2017 18:25:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=RzVDRG0yLAkLolyzaXk8BIezg0Fh3ANMiQPaitduj1E=;\n\tb=m3ccRVzQvyEahXHlnKdlWC/SaVg0yQ9laXRu2EkJPf0nTmLPyNTUfEVUeiK/AIhJ60\n\teLRf+gEyvrIwy0cVA4hoV68MnA4sy19bEpn2jByBbB68FyOGQSEcasIB1IeA1SW7taVc\n\tY9qVf5yEAX4PJFqPPzcBXJslpAiY9cF3ekKS4jeMJWKUGcMJgLl8saygliSLEvrs/Fsu\n\tJ/rTjuNJKSvipIyoYF9h8PDpnDNkHJAPFXq21kGN87NQuF9uczlzdUfUGpGhKmABAdwX\n\t5EP+72Us2GYeGu9H9lXfHLKHBd3WUrIS0oFs6DbE6MX4wVdNIvEGPa+pTN7i7NVU3k3Y\n\tWDXw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=RzVDRG0yLAkLolyzaXk8BIezg0Fh3ANMiQPaitduj1E=;\n\tb=V+89EuXBinvBDJhWDnjUddGD0Hw2KAZfF25rnWYY3udBwJMGVRdv/38haaxz2Zcdvh\n\tN7jmX42b5ATUgWVwTHk97YB76SQAKAArxl5/aaqIQ4IO35a2Fu3jN+2FDAR2R/NNBdES\n\tJAbPPcsAiIpp186j7hECCh6PdOES0Hki5BAl1iQ4BZ4xgNqAt3G0BaS6xcBa3L6CHn1q\n\tUnyRIhRYI4XCXwK3KRV1b2okVpF9gV7yPFGrYkDXudJhpz8TpzKRfTpmL3CXBsKPip2W\n\tuzOyzgrdmoMVkcRcNdx+fcImXWL9vyD+HdcpnT46hQddmMXv2Z65mnvaYB5+Da72FQAm\n\tnvxw==", "X-Gm-Message-State": "AMCzsaUL5aIxpOUl1DQoteYO4NazYSg2Meg4Pj13oh7Z9ZBtA6ZWPI3q\n\tfVIESAtFHJekviy0b+j1Zt5YqNGT", "X-Google-Smtp-Source": "ABhQp+QqQnoKXR68l7/vSiONuQ9cq5rcBtKoajBol297vRht8KyJFhYaS3gnkXPWNBiJbl0AW1ZQ4Q==", "X-Received": "by 10.101.81.130 with SMTP id h2mr6380929pgq.175.1509067509891; \n\tThu, 26 Oct 2017 18:25:09 -0700 (PDT)", "From": "Cong Wang <xiyou.wangcong@gmail.com>", "To": "netdev@vger.kernel.org", "Cc": "Chris Mi <chrism@mellanox.com>, Cong Wang <xiyou.wangcong@gmail.com>,\n\tDaniel Borkmann <daniel@iogearbox.net>, Jiri Pirko <jiri@resnulli.us>,\n\tJohn Fastabend <john.fastabend@gmail.com>,\n\tJamal Hadi Salim <jhs@mojatatu.com>,\n\t\"Paul E. McKenney\" <paulmck@linux.vnet.ibm.com>", "Subject": "[Patch net 10/16] net_sched: use tcf_queue_work() in route filter", "Date": "Thu, 26 Oct 2017 18:24:37 -0700", "Message-Id": "<20171027012443.3306-11-xiyou.wangcong@gmail.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20171027012443.3306-1-xiyou.wangcong@gmail.com>", "References": "<20171027012443.3306-1-xiyou.wangcong@gmail.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Defer the tcf_exts_destroy() in RCU callback to\ntc filter workqueue and get RTNL lock.\n\nReported-by: Chris Mi <chrism@mellanox.com>\nCc: Daniel Borkmann <daniel@iogearbox.net>\nCc: Jiri Pirko <jiri@resnulli.us>\nCc: John Fastabend <john.fastabend@gmail.com>\nCc: Jamal Hadi Salim <jhs@mojatatu.com>\nCc: \"Paul E. McKenney\" <paulmck@linux.vnet.ibm.com>\nSigned-off-by: Cong Wang <xiyou.wangcong@gmail.com>\n---\n net/sched/cls_route.c | 19 ++++++++++++++++---\n 1 file changed, 16 insertions(+), 3 deletions(-)", "diff": "diff --git a/net/sched/cls_route.c b/net/sched/cls_route.c\nindex 9ddde65915d2..4b14ccd8b8f2 100644\n--- a/net/sched/cls_route.c\n+++ b/net/sched/cls_route.c\n@@ -57,7 +57,10 @@ struct route4_filter {\n \tu32\t\t\thandle;\n \tstruct route4_bucket\t*bkt;\n \tstruct tcf_proto\t*tp;\n-\tstruct rcu_head\t\trcu;\n+\tunion {\n+\t\tstruct work_struct\twork;\n+\t\tstruct rcu_head\t\trcu;\n+\t};\n };\n \n #define ROUTE4_FAILURE ((struct route4_filter *)(-1L))\n@@ -254,12 +257,22 @@ static int route4_init(struct tcf_proto *tp)\n \treturn 0;\n }\n \n-static void route4_delete_filter(struct rcu_head *head)\n+static void route4_delete_filter_work(struct work_struct *work)\n {\n-\tstruct route4_filter *f = container_of(head, struct route4_filter, rcu);\n+\tstruct route4_filter *f = container_of(work, struct route4_filter, work);\n \n+\trtnl_lock();\n \ttcf_exts_destroy(&f->exts);\n \tkfree(f);\n+\trtnl_unlock();\n+}\n+\n+static void route4_delete_filter(struct rcu_head *head)\n+{\n+\tstruct route4_filter *f = container_of(head, struct route4_filter, rcu);\n+\n+\tINIT_WORK(&f->work, route4_delete_filter_work);\n+\ttcf_queue_work(&f->work);\n }\n \n static void route4_destroy(struct tcf_proto *tp)\n", "prefixes": [ "net", "10/16" ] }