Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/831013/?format=api
{ "id": 831013, "url": "http://patchwork.ozlabs.org/api/1.2/patches/831013/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-6-xiyou.wangcong@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171027012443.3306-6-xiyou.wangcong@gmail.com>", "list_archive_url": null, "date": "2017-10-27T01:24:32", "name": "[net,05/16] net_sched: use tcf_queue_work() in flow filter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0407892a9c2cc047ffcc3d93d9870f24343c68a3", "submitter": { "id": 211, "url": "http://patchwork.ozlabs.org/api/1.2/people/211/?format=api", "name": "Cong Wang", "email": "xiyou.wangcong@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-6-xiyou.wangcong@gmail.com/mbox/", "series": [ { "id": 10472, "url": "http://patchwork.ozlabs.org/api/1.2/series/10472/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=10472", "date": "2017-10-27T01:24:27", "name": "net_sched: fix races with RCU callbacks", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/10472/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/831013/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/831013/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"rXKWARGC\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNR571hmjz9t2x\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 27 Oct 2017 12:25:15 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932408AbdJ0BZM (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 26 Oct 2017 21:25:12 -0400", "from mail-pf0-f193.google.com ([209.85.192.193]:49817 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751984AbdJ0BZE (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 26 Oct 2017 21:25:04 -0400", "by mail-pf0-f193.google.com with SMTP id i5so3774636pfe.6\n\tfor <netdev@vger.kernel.org>; Thu, 26 Oct 2017 18:25:04 -0700 (PDT)", "from tw-172-25-30-113.office.twttr.net ([8.25.197.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tb16sm13211973pfe.58.2017.10.26.18.25.02\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 26 Oct 2017 18:25:02 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=z0ibl67H9bChFam2CTu++RpCk4JH2i0IoTSp2O6BhG8=;\n\tb=rXKWARGC+op1vUpQq95AHNieYnMU617VtFS4JVwQkbavlVBDTQJxaUgaca9Hk03Dbo\n\tAJIHtD709alFEnhjCTHbo6hhOA+5eN+esB5u5AfrshcrIJqM/d78UeDLvnIgnuksa++h\n\tm0ur/ftQShC/ZMrAd7/xFIV9xrbDwf4+fNo9HMslcb6O6aZBOZaHSFQPW13eRjeNxvH4\n\tYEAUHUo39dMKHYNJPhlfP3HV6mEu870lAq5En6H7wTHD2LrVHlUxH2LYkO+lb0QY0CaM\n\te6ebM0aybszFXiWmnBMzo2bp1XtX9nJtV1Yk/FpuC31pCKaSIgk1d3i4MkkrT6CQjLV/\n\t4mow==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=z0ibl67H9bChFam2CTu++RpCk4JH2i0IoTSp2O6BhG8=;\n\tb=R3v8vUv8b4johriIxjnZVjGHyaS9w+icddbmCsu3055dWlaMqYFJZjJBhQ+6lIbozV\n\tsQapFSuIP5flNSdiQ2AOsXSNvoz8PPKKjUmMZ8iDmI4n8s5Do4RjuVB/LG/nIQsIXVt4\n\tADIDMtWrZ1oSZBjStVe7j6mbO03VZeTI12WE4s+ukJNkMKCGIw69pv3+z/hHtMxsMZic\n\trI7FCXXjwJq3gejzxrpIJEhY5K1sT/CunyK5s11tJCDKAEO9nrY3rOg7qIj4ZaXk0orl\n\tYsmsobM0teV0IP8QQJQdIluDCggymKjznu3SyskUXnneDu1opCY1G8gzmLCBYkCBzorY\n\t7Wjg==", "X-Gm-Message-State": "AMCzsaUEPthpZJiJy3dnAdZsS0Yeltl3kJZk1Z7E7iP7FYa/QH39CQXG\n\tGsfxhUoGu4copb2wYMZPyL7LLoSM", "X-Google-Smtp-Source": "ABhQp+RhmoY22MSACDKzUnC3GLVJaUKPx0VrjXE7ijuwDP4ONIbwC1hJuvK1mm8j1dOKIm6HXHtDwg==", "X-Received": "by 10.98.204.150 with SMTP id j22mr7306478pfk.3.1509067503660;\n\tThu, 26 Oct 2017 18:25:03 -0700 (PDT)", "From": "Cong Wang <xiyou.wangcong@gmail.com>", "To": "netdev@vger.kernel.org", "Cc": "Chris Mi <chrism@mellanox.com>, Cong Wang <xiyou.wangcong@gmail.com>,\n\tDaniel Borkmann <daniel@iogearbox.net>, Jiri Pirko <jiri@resnulli.us>,\n\tJohn Fastabend <john.fastabend@gmail.com>,\n\tJamal Hadi Salim <jhs@mojatatu.com>,\n\t\"Paul E. McKenney\" <paulmck@linux.vnet.ibm.com>", "Subject": "[Patch net 05/16] net_sched: use tcf_queue_work() in flow filter", "Date": "Thu, 26 Oct 2017 18:24:32 -0700", "Message-Id": "<20171027012443.3306-6-xiyou.wangcong@gmail.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20171027012443.3306-1-xiyou.wangcong@gmail.com>", "References": "<20171027012443.3306-1-xiyou.wangcong@gmail.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Defer the tcf_exts_destroy() in RCU callback to\ntc filter workqueue and get RTNL lock.\n\nReported-by: Chris Mi <chrism@mellanox.com>\nCc: Daniel Borkmann <daniel@iogearbox.net>\nCc: Jiri Pirko <jiri@resnulli.us>\nCc: John Fastabend <john.fastabend@gmail.com>\nCc: Jamal Hadi Salim <jhs@mojatatu.com>\nCc: \"Paul E. McKenney\" <paulmck@linux.vnet.ibm.com>\nSigned-off-by: Cong Wang <xiyou.wangcong@gmail.com>\n---\n net/sched/cls_flow.c | 19 ++++++++++++++++---\n 1 file changed, 16 insertions(+), 3 deletions(-)", "diff": "diff --git a/net/sched/cls_flow.c b/net/sched/cls_flow.c\nindex 2a3a60ec5b86..67f3a2af6aab 100644\n--- a/net/sched/cls_flow.c\n+++ b/net/sched/cls_flow.c\n@@ -57,7 +57,10 @@ struct flow_filter {\n \tu32\t\t\tdivisor;\n \tu32\t\t\tbaseclass;\n \tu32\t\t\thashrnd;\n-\tstruct rcu_head\t\trcu;\n+\tunion {\n+\t\tstruct work_struct\twork;\n+\t\tstruct rcu_head\t\trcu;\n+\t};\n };\n \n static inline u32 addr_fold(void *addr)\n@@ -369,14 +372,24 @@ static const struct nla_policy flow_policy[TCA_FLOW_MAX + 1] = {\n \t[TCA_FLOW_PERTURB]\t= { .type = NLA_U32 },\n };\n \n-static void flow_destroy_filter(struct rcu_head *head)\n+static void flow_destroy_filter_work(struct work_struct *work)\n {\n-\tstruct flow_filter *f = container_of(head, struct flow_filter, rcu);\n+\tstruct flow_filter *f = container_of(work, struct flow_filter, work);\n \n+\trtnl_lock();\n \tdel_timer_sync(&f->perturb_timer);\n \ttcf_exts_destroy(&f->exts);\n \ttcf_em_tree_destroy(&f->ematches);\n \tkfree(f);\n+\trtnl_unlock();\n+}\n+\n+static void flow_destroy_filter(struct rcu_head *head)\n+{\n+\tstruct flow_filter *f = container_of(head, struct flow_filter, rcu);\n+\n+\tINIT_WORK(&f->work, flow_destroy_filter_work);\n+\ttcf_queue_work(&f->work);\n }\n \n static int flow_change(struct net *net, struct sk_buff *in_skb,\n", "prefixes": [ "net", "05/16" ] }