Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/831011/?format=api
{ "id": 831011, "url": "http://patchwork.ozlabs.org/api/1.2/patches/831011/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-3-xiyou.wangcong@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171027012443.3306-3-xiyou.wangcong@gmail.com>", "list_archive_url": null, "date": "2017-10-27T01:24:29", "name": "[net,02/16] net_sched: use tcf_queue_work() in basic filter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f8981b67c5784f19b5bde3bfa5a5d113f6f97c53", "submitter": { "id": 211, "url": "http://patchwork.ozlabs.org/api/1.2/people/211/?format=api", "name": "Cong Wang", "email": "xiyou.wangcong@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20171027012443.3306-3-xiyou.wangcong@gmail.com/mbox/", "series": [ { "id": 10472, "url": "http://patchwork.ozlabs.org/api/1.2/series/10472/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=10472", "date": "2017-10-27T01:24:27", "name": "net_sched: fix races with RCU callbacks", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/10472/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/831011/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/831011/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MUZ9mpMc\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNR520zVtz9t2h\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 27 Oct 2017 12:25:10 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932340AbdJ0BZI (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 26 Oct 2017 21:25:08 -0400", "from mail-pf0-f193.google.com ([209.85.192.193]:51529 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751959AbdJ0BZB (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 26 Oct 2017 21:25:01 -0400", "by mail-pf0-f193.google.com with SMTP id n14so3764012pfh.8\n\tfor <netdev@vger.kernel.org>; Thu, 26 Oct 2017 18:25:00 -0700 (PDT)", "from tw-172-25-30-113.office.twttr.net ([8.25.197.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tb16sm13211973pfe.58.2017.10.26.18.24.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 26 Oct 2017 18:24:59 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=HbPkji9ndIcw7jvrrIaHRWQrGLe607rDkphGWTBy2II=;\n\tb=MUZ9mpMc1KD1XRK/PMfhkj3jZ8qh/S+aiazJyhAhreoQ2zTAm3jJ8AkkC4o1oPMmnF\n\tOsDioC3N0eZnLDYvnSUxRsyKF+6XdgBtcPHfoaYWGpLKkRGrJdvy24hzwipazpIcTXtG\n\tgBhoqCsCz8FvXAYqKtyoeGHi4Zc6NnLZ0q+RiwzWHovG3is8QP5EjGOHEkzE+m31p74l\n\tSis7fHu0rvZnn60xLnLH5Zbd/mD/cXaM+TRDrWDlR4zt+IUXJlNyZdiVHWNT+0XIWP/o\n\tO4X0pPRRn2yYv9e9Ozc5w2QVuwq3V8hChVzt/dCQFVOZW6qwCm3CNTroAjhqgmVs8uCw\n\tyNdA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=HbPkji9ndIcw7jvrrIaHRWQrGLe607rDkphGWTBy2II=;\n\tb=kpehBx57PagFQG+7Mq7cRa4i5M7QDUOhHifAHghP9FK1k7sM2DuAD8Kms8cCTdawTP\n\tuzXbn8P285DPbu+t/LA3fZEf7ephqSLxKO3W+NLc9Cc2P1CpnNxJjZmYxtBv3YSVB4IR\n\tjqft7C5kxYV8yFk2Zqu2Vmcj+S1j7cB/4x4sBhgwbG14/nhedLe1fZcyTE3riyXUw/kE\n\tKtiHhTLtSOSqnC6LPEaQDPu6d1S0r9dnA+NNwLb4/Tl33bqKKkoUPlmZ8sCaH3/lStKt\n\tFBsehw1piUcebloD4Kwp28jtJoRqCAvdfGVjZStwJCntFX7kCpy1Z6PCrMWt6OBukbSX\n\t9neA==", "X-Gm-Message-State": "AMCzsaWfEY6nulM5RmItUPzW7UYqpcYyBcBUBgFS3huq29qoH+BsT54L\n\tGWAm15uQmj6gDu32arOECXQZM3lT", "X-Google-Smtp-Source": "ABhQp+Tn3wdccHg1btPBy0t6nI/IfJtUfnkN299H+7ST1tfh0yPfddFS/yhBhM8r5VE1sl6M34A3Zg==", "X-Received": "by 10.84.240.70 with SMTP id h6mr5731855plt.109.1509067500080;\n\tThu, 26 Oct 2017 18:25:00 -0700 (PDT)", "From": "Cong Wang <xiyou.wangcong@gmail.com>", "To": "netdev@vger.kernel.org", "Cc": "Chris Mi <chrism@mellanox.com>, Cong Wang <xiyou.wangcong@gmail.com>,\n\tDaniel Borkmann <daniel@iogearbox.net>, Jiri Pirko <jiri@resnulli.us>,\n\tJohn Fastabend <john.fastabend@gmail.com>,\n\tJamal Hadi Salim <jhs@mojatatu.com>,\n\t\"Paul E. McKenney\" <paulmck@linux.vnet.ibm.com>", "Subject": "[Patch net 02/16] net_sched: use tcf_queue_work() in basic filter", "Date": "Thu, 26 Oct 2017 18:24:29 -0700", "Message-Id": "<20171027012443.3306-3-xiyou.wangcong@gmail.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20171027012443.3306-1-xiyou.wangcong@gmail.com>", "References": "<20171027012443.3306-1-xiyou.wangcong@gmail.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Defer the tcf_exts_destroy() in RCU callback to\ntc filter workqueue and get RTNL lock.\n\nReported-by: Chris Mi <chrism@mellanox.com>\nCc: Daniel Borkmann <daniel@iogearbox.net>\nCc: Jiri Pirko <jiri@resnulli.us>\nCc: John Fastabend <john.fastabend@gmail.com>\nCc: Jamal Hadi Salim <jhs@mojatatu.com>\nCc: \"Paul E. McKenney\" <paulmck@linux.vnet.ibm.com>\nSigned-off-by: Cong Wang <xiyou.wangcong@gmail.com>\n---\n net/sched/cls_basic.c | 20 +++++++++++++++++---\n 1 file changed, 17 insertions(+), 3 deletions(-)", "diff": "diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c\nindex d89ebafd2239..f177649a2419 100644\n--- a/net/sched/cls_basic.c\n+++ b/net/sched/cls_basic.c\n@@ -34,7 +34,10 @@ struct basic_filter {\n \tstruct tcf_result\tres;\n \tstruct tcf_proto\t*tp;\n \tstruct list_head\tlink;\n-\tstruct rcu_head\t\trcu;\n+\tunion {\n+\t\tstruct work_struct\twork;\n+\t\tstruct rcu_head\t\trcu;\n+\t};\n };\n \n static int basic_classify(struct sk_buff *skb, const struct tcf_proto *tp,\n@@ -82,15 +85,26 @@ static int basic_init(struct tcf_proto *tp)\n \treturn 0;\n }\n \n-static void basic_delete_filter(struct rcu_head *head)\n+static void basic_delete_filter_work(struct work_struct *work)\n {\n-\tstruct basic_filter *f = container_of(head, struct basic_filter, rcu);\n+\tstruct basic_filter *f = container_of(work, struct basic_filter, work);\n \n+\trtnl_lock();\n \ttcf_exts_destroy(&f->exts);\n \ttcf_em_tree_destroy(&f->ematches);\n+\trtnl_unlock();\n+\n \tkfree(f);\n }\n \n+static void basic_delete_filter(struct rcu_head *head)\n+{\n+\tstruct basic_filter *f = container_of(head, struct basic_filter, rcu);\n+\n+\tINIT_WORK(&f->work, basic_delete_filter_work);\n+\ttcf_queue_work(&f->work);\n+}\n+\n static void basic_destroy(struct tcf_proto *tp)\n {\n \tstruct basic_head *head = rtnl_dereference(tp->root);\n", "prefixes": [ "net", "02/16" ] }