Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 829948,
    "url": "http://patchwork.ozlabs.org/api/1.2/patches/829948/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20171024152415.22864-11-jack@suse.cz/",
    "project": {
        "id": 8,
        "url": "http://patchwork.ozlabs.org/api/1.2/projects/8/?format=api",
        "name": "Linux ext4 filesystem development",
        "link_name": "linux-ext4",
        "list_id": "linux-ext4.vger.kernel.org",
        "list_email": "linux-ext4@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20171024152415.22864-11-jack@suse.cz>",
    "list_archive_url": null,
    "date": "2017-10-24T15:24:07",
    "name": "[10/17] dax: Allow dax_iomap_fault() to return pfn",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "adabbbf27f2600c2ba8048a35ad917dc264b74eb",
    "submitter": {
        "id": 363,
        "url": "http://patchwork.ozlabs.org/api/1.2/people/363/?format=api",
        "name": "Jan Kara",
        "email": "jack@suse.cz"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20171024152415.22864-11-jack@suse.cz/mbox/",
    "series": [
        {
            "id": 10008,
            "url": "http://patchwork.ozlabs.org/api/1.2/series/10008/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/list/?series=10008",
            "date": "2017-10-24T15:23:57",
            "name": "dax, ext4, xfs: Synchronous page faults",
            "version": 5,
            "mbox": "http://patchwork.ozlabs.org/series/10008/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/829948/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/829948/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<linux-ext4-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yLxv56Xvlz9t3m\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 25 Oct 2017 02:26:25 +1100 (AEDT)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932405AbdJXP0Y (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 24 Oct 2017 11:26:24 -0400",
            "from mx2.suse.de ([195.135.220.15]:36116 \"EHLO mx2.suse.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S932334AbdJXPZc (ORCPT <rfc822;linux-ext4@vger.kernel.org>);\n\tTue, 24 Oct 2017 11:25:32 -0400",
            "from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx2.suse.de (Postfix) with ESMTP id 22CCCAD24;\n\tTue, 24 Oct 2017 15:25:28 +0000 (UTC)",
            "by quack2.suse.cz (Postfix, from userid 1000)\n\tid 6648F1E35D7; Tue, 24 Oct 2017 17:25:27 +0200 (CEST)"
        ],
        "X-Virus-Scanned": "by amavisd-new at test-mx.suse.de",
        "From": "Jan Kara <jack@suse.cz>",
        "To": "Dan Williams <dan.j.williams@intel.com>",
        "Cc": "Ross Zwisler <ross.zwisler@linux.intel.com>,\n\tChristoph Hellwig <hch@infradead.org>,\n\t<linux-ext4@vger.kernel.org>, linux-nvdimm@lists.01.org,\n\t<linux-fsdevel@vger.kernel.org>, <linux-xfs@vger.kernel.org>,\n\tlinux-api@vger.kernel.org, <linux-mm@kvack.org>, Jan Kara <jack@suse.cz>",
        "Subject": "[PATCH 10/17] dax: Allow dax_iomap_fault() to return pfn",
        "Date": "Tue, 24 Oct 2017 17:24:07 +0200",
        "Message-Id": "<20171024152415.22864-11-jack@suse.cz>",
        "X-Mailer": "git-send-email 2.12.3",
        "In-Reply-To": "<20171024152415.22864-1-jack@suse.cz>",
        "References": "<20171024152415.22864-1-jack@suse.cz>",
        "Sender": "linux-ext4-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<linux-ext4.vger.kernel.org>",
        "X-Mailing-List": "linux-ext4@vger.kernel.org"
    },
    "content": "For synchronous page fault dax_iomap_fault() will need to return PFN\nwhich will then need to be inserted into page tables after fsync()\ncompletes. Add necessary parameter to dax_iomap_fault().\n\nReviewed-by: Christoph Hellwig <hch@lst.de>\nReviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>\nSigned-off-by: Jan Kara <jack@suse.cz>\n---\n fs/dax.c            | 13 +++++++------\n fs/ext2/file.c      |  2 +-\n fs/ext4/file.c      |  2 +-\n fs/xfs/xfs_file.c   |  4 ++--\n include/linux/dax.h |  2 +-\n 5 files changed, 12 insertions(+), 11 deletions(-)",
    "diff": "diff --git a/fs/dax.c b/fs/dax.c\nindex 5214ed9ba508..5ddf15161390 100644\n--- a/fs/dax.c\n+++ b/fs/dax.c\n@@ -1079,7 +1079,7 @@ static int dax_fault_return(int error)\n \treturn VM_FAULT_SIGBUS;\n }\n \n-static int dax_iomap_pte_fault(struct vm_fault *vmf,\n+static int dax_iomap_pte_fault(struct vm_fault *vmf, pfn_t *pfnp,\n \t\t\t       const struct iomap_ops *ops)\n {\n \tstruct vm_area_struct *vma = vmf->vma;\n@@ -1280,7 +1280,7 @@ static int dax_pmd_load_hole(struct vm_fault *vmf, struct iomap *iomap,\n \treturn VM_FAULT_FALLBACK;\n }\n \n-static int dax_iomap_pmd_fault(struct vm_fault *vmf,\n+static int dax_iomap_pmd_fault(struct vm_fault *vmf, pfn_t *pfnp,\n \t\t\t       const struct iomap_ops *ops)\n {\n \tstruct vm_area_struct *vma = vmf->vma;\n@@ -1425,7 +1425,7 @@ static int dax_iomap_pmd_fault(struct vm_fault *vmf,\n \treturn result;\n }\n #else\n-static int dax_iomap_pmd_fault(struct vm_fault *vmf,\n+static int dax_iomap_pmd_fault(struct vm_fault *vmf, pfn_t *pfnp,\n \t\t\t       const struct iomap_ops *ops)\n {\n \treturn VM_FAULT_FALLBACK;\n@@ -1436,6 +1436,7 @@ static int dax_iomap_pmd_fault(struct vm_fault *vmf,\n  * dax_iomap_fault - handle a page fault on a DAX file\n  * @vmf: The description of the fault\n  * @pe_size: Size of the page to fault in\n+ * @pfnp: PFN to insert for synchronous faults if fsync is required\n  * @ops: Iomap ops passed from the file system\n  *\n  * When a page fault occurs, filesystems may call this helper in\n@@ -1444,13 +1445,13 @@ static int dax_iomap_pmd_fault(struct vm_fault *vmf,\n  * successfully.\n  */\n int dax_iomap_fault(struct vm_fault *vmf, enum page_entry_size pe_size,\n-\t\t    const struct iomap_ops *ops)\n+\t\t    pfn_t *pfnp, const struct iomap_ops *ops)\n {\n \tswitch (pe_size) {\n \tcase PE_SIZE_PTE:\n-\t\treturn dax_iomap_pte_fault(vmf, ops);\n+\t\treturn dax_iomap_pte_fault(vmf, pfnp, ops);\n \tcase PE_SIZE_PMD:\n-\t\treturn dax_iomap_pmd_fault(vmf, ops);\n+\t\treturn dax_iomap_pmd_fault(vmf, pfnp, ops);\n \tdefault:\n \t\treturn VM_FAULT_FALLBACK;\n \t}\ndiff --git a/fs/ext2/file.c b/fs/ext2/file.c\nindex ff3a3636a5ca..d2bb7c96307d 100644\n--- a/fs/ext2/file.c\n+++ b/fs/ext2/file.c\n@@ -99,7 +99,7 @@ static int ext2_dax_fault(struct vm_fault *vmf)\n \t}\n \tdown_read(&ei->dax_sem);\n \n-\tret = dax_iomap_fault(vmf, PE_SIZE_PTE, &ext2_iomap_ops);\n+\tret = dax_iomap_fault(vmf, PE_SIZE_PTE, NULL, &ext2_iomap_ops);\n \n \tup_read(&ei->dax_sem);\n \tif (vmf->flags & FAULT_FLAG_WRITE)\ndiff --git a/fs/ext4/file.c b/fs/ext4/file.c\nindex b1da660ac3bc..3cec0b95672f 100644\n--- a/fs/ext4/file.c\n+++ b/fs/ext4/file.c\n@@ -306,7 +306,7 @@ static int ext4_dax_huge_fault(struct vm_fault *vmf,\n \t\tdown_read(&EXT4_I(inode)->i_mmap_sem);\n \t}\n \tif (!IS_ERR(handle))\n-\t\tresult = dax_iomap_fault(vmf, pe_size, &ext4_iomap_ops);\n+\t\tresult = dax_iomap_fault(vmf, pe_size, NULL, &ext4_iomap_ops);\n \telse\n \t\tresult = VM_FAULT_SIGBUS;\n \tif (write) {\ndiff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c\nindex 309e26c9dddb..7c6b8def6eed 100644\n--- a/fs/xfs/xfs_file.c\n+++ b/fs/xfs/xfs_file.c\n@@ -1040,7 +1040,7 @@ __xfs_filemap_fault(\n \n \txfs_ilock(XFS_I(inode), XFS_MMAPLOCK_SHARED);\n \tif (IS_DAX(inode)) {\n-\t\tret = dax_iomap_fault(vmf, pe_size, &xfs_iomap_ops);\n+\t\tret = dax_iomap_fault(vmf, pe_size, NULL, &xfs_iomap_ops);\n \t} else {\n \t\tif (write_fault)\n \t\t\tret = iomap_page_mkwrite(vmf, &xfs_iomap_ops);\n@@ -1111,7 +1111,7 @@ xfs_filemap_pfn_mkwrite(\n \tif (vmf->pgoff >= size)\n \t\tret = VM_FAULT_SIGBUS;\n \telse if (IS_DAX(inode))\n-\t\tret = dax_iomap_fault(vmf, PE_SIZE_PTE, &xfs_iomap_ops);\n+\t\tret = dax_iomap_fault(vmf, PE_SIZE_PTE, NULL, &xfs_iomap_ops);\n \txfs_iunlock(ip, XFS_MMAPLOCK_SHARED);\n \tsb_end_pagefault(inode->i_sb);\n \treturn ret;\ndiff --git a/include/linux/dax.h b/include/linux/dax.h\nindex 122197124b9d..e7fa4b8f45bc 100644\n--- a/include/linux/dax.h\n+++ b/include/linux/dax.h\n@@ -95,7 +95,7 @@ bool dax_write_cache_enabled(struct dax_device *dax_dev);\n ssize_t dax_iomap_rw(struct kiocb *iocb, struct iov_iter *iter,\n \t\tconst struct iomap_ops *ops);\n int dax_iomap_fault(struct vm_fault *vmf, enum page_entry_size pe_size,\n-\t\t    const struct iomap_ops *ops);\n+\t\t    pfn_t *pfnp, const struct iomap_ops *ops);\n int dax_delete_mapping_entry(struct address_space *mapping, pgoff_t index);\n int dax_invalidate_mapping_entry_sync(struct address_space *mapping,\n \t\t\t\t      pgoff_t index);\n",
    "prefixes": [
        "10/17"
    ]
}