Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/815540/?format=api
{ "id": 815540, "url": "http://patchwork.ozlabs.org/api/1.2/patches/815540/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1505828954-19926-1-git-send-email-philipp.tomsich@theobroma-systems.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.2/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505828954-19926-1-git-send-email-philipp.tomsich@theobroma-systems.com>", "list_archive_url": null, "date": "2017-09-19T13:49:14", "name": "[U-Boot] rockchip: pinctrl: rk3368: add pinctrl for SDMMC0", "commit_ref": "fd0a1ba52ec65e82caf163d0074e768c3abc57ae", "pull_url": null, "state": "accepted", "archived": false, "hash": "907c691fa05b421b3d357808e5bc0346463ca977", "submitter": { "id": 53488, "url": "http://patchwork.ozlabs.org/api/1.2/people/53488/?format=api", "name": "Philipp Tomsich", "email": "philipp.tomsich@theobroma-systems.com" }, "delegate": { "id": 69486, "url": "http://patchwork.ozlabs.org/api/1.2/users/69486/?format=api", "username": "ptomsich", "first_name": "Philipp", "last_name": "Tomsich", "email": "philipp.tomsich@theobroma-systems.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1505828954-19926-1-git-send-email-philipp.tomsich@theobroma-systems.com/mbox/", "series": [ { "id": 3885, "url": "http://patchwork.ozlabs.org/api/1.2/series/3885/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=3885", "date": "2017-09-19T13:49:14", "name": "[U-Boot] rockchip: pinctrl: rk3368: add pinctrl for SDMMC0", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3885/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815540/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815540/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxPPS500kz9sMN\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Sep 2017 23:49:31 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 991B7C21F1A; Tue, 19 Sep 2017 13:49:26 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id D3286C21D78;\n\tTue, 19 Sep 2017 13:49:23 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid C5D3AC21D78; Tue, 19 Sep 2017 13:49:21 +0000 (UTC)", "from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id 770FDC21D74\n\tfor <u-boot@lists.denx.de>; Tue, 19 Sep 2017 13:49:21 +0000 (UTC)", "from [86.59.122.178] (port=35238 helo=android.lan)\n\tby mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:RSA_AES_128_CBC_SHA256:128)\n\t(Exim 4.80) (envelope-from <philipp.tomsich@theobroma-systems.com>)\n\tid 1duItr-00078Z-0O; Tue, 19 Sep 2017 15:49:19 +0200" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0", "From": "Philipp Tomsich <philipp.tomsich@theobroma-systems.com>", "To": "u-boot@lists.denx.de", "Date": "Tue, 19 Sep 2017 15:49:14 +0200", "Message-Id": "<1505828954-19926-1-git-send-email-philipp.tomsich@theobroma-systems.com>", "X-Mailer": "git-send-email 2.1.4", "Cc": "Andy Yan <andy.yan@rock-chips.com>", "Subject": "[U-Boot] [PATCH] rockchip: pinctrl: rk3368: add pinctrl for SDMMC0", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "Apparently, our earlier assumption that the BROM will always set up\nthe iomux for SDcard communication does not always hold true: when\nbooting U-Boot from the on-module (on the RK3368-uQ7) eMMC, the SDcard\npins are not set up and need to be configured by the pinctrl driver to\nallow SD card access.\n\nThis change implements support for setting up the SDMMC pins in\npinctrl for the RK3368.\n\nReported-by: Klaus Goger <klaus.goger@theobroma-systems.com>\nSigned-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>\n---\n\n drivers/pinctrl/rockchip/pinctrl_rk3368.c | 39 +++++++++++++++++++++++++++----\n 1 file changed, 34 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/pinctrl/rockchip/pinctrl_rk3368.c b/drivers/pinctrl/rockchip/pinctrl_rk3368.c\nindex b1f5704..25249e3 100644\n--- a/drivers/pinctrl/rockchip/pinctrl_rk3368.c\n+++ b/drivers/pinctrl/rockchip/pinctrl_rk3368.c\n@@ -208,6 +208,29 @@ enum {\n \tGPIO2A0_FLASH_CSN0 = (1 << GPIO2A0_SHIFT),\n };\n \n+/*GRF_GPIO2B_IOMUX*/\n+enum {\n+\tGPIO2B3_SHIFT = 6,\n+\tGPIO2B3_MASK = GENMASK(GPIO2B3_SHIFT + 1, GPIO2B3_SHIFT),\n+\tGPIO2B3_GPIO = 0,\n+\tGPIO2B3_SDMMC0_DTECTN = (1 << GPIO2B3_SHIFT),\n+\n+\tGPIO2B2_SHIFT = 4,\n+\tGPIO2B2_MASK = GENMASK(GPIO2B2_SHIFT + 1, GPIO2B2_SHIFT),\n+\tGPIO2B2_GPIO = 0,\n+\tGPIO2B2_SDMMC0_CMD = (1 << GPIO2B2_SHIFT),\n+\n+\tGPIO2B1_SHIFT = 2,\n+\tGPIO2B1_MASK = GENMASK(GPIO2B1_SHIFT + 1, GPIO2B1_SHIFT),\n+\tGPIO2B1_GPIO = 0,\n+\tGPIO2B1_SDMMC0_CLKOUT = (1 << GPIO2B1_SHIFT),\n+\n+\tGPIO2B0_SHIFT = 0,\n+\tGPIO2B0_MASK = GENMASK(GPIO2B0_SHIFT + 1, GPIO2B0_SHIFT),\n+\tGPIO2B0_GPIO = 0,\n+\tGPIO2B0_SDMMC0_D3 = (1 << GPIO2B0_SHIFT),\n+};\n+\n /*GRF_GPIO2D_IOMUX*/\n enum {\n \tGPIO2D7_SHIFT = 14,\n@@ -580,11 +603,17 @@ static void pinctrl_rk3368_sdmmc_config(struct rk3368_grf *grf, int mmc_id)\n \t\t\t GPIO2A4_EMMC_CLKOUT);\n \t\tbreak;\n \tcase PERIPH_ID_SDCARD:\n-\t\t/*\n-\t\t * We assume that the BROM has already set this up\n-\t\t * correctly for us and that there's nothing to do\n-\t\t * here.\n-\t\t */\n+\t\tdebug(\"mmc id = %d setting registers!\\n\", mmc_id);\n+\t\trk_clrsetreg(&grf->gpio2a_iomux,\n+\t\t\t GPIO2A5_MASK | GPIO2A7_MASK |\n+\t\t\t GPIO2A7_MASK,\n+\t\t\t GPIO2A5_SDMMC0_D0 | GPIO2A6_SDMMC0_D1 |\n+\t\t\t GPIO2A7_SDMMC0_D2);\n+\t\trk_clrsetreg(&grf->gpio2b_iomux,\n+\t\t\t GPIO2B0_MASK | GPIO2B1_MASK |\n+\t\t\t GPIO2B2_MASK | GPIO2B3_MASK,\n+\t\t\t GPIO2B0_SDMMC0_D3 | GPIO2B1_SDMMC0_CLKOUT |\n+\t\t\t GPIO2B2_SDMMC0_CMD | GPIO2B3_SDMMC0_DTECTN);\n \t\tbreak;\n \tdefault:\n \t\tdebug(\"mmc id = %d iomux error!\\n\", mmc_id);\n", "prefixes": [ "U-Boot" ] }