Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/815116/?format=api
{ "id": 815116, "url": "http://patchwork.ozlabs.org/api/1.2/patches/815116/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170918191822.65142-10-jwi@linux.vnet.ibm.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170918191822.65142-10-jwi@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-09-18T19:18:22", "name": "[net-next,9/9] s390/qeth: tidy up parameter naming for qeth_do_send_packet()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bf59a4782be4e2f89edf7938fce4167aed61f824", "submitter": { "id": 71397, "url": "http://patchwork.ozlabs.org/api/1.2/people/71397/?format=api", "name": "Julian Wiedmann", "email": "jwi@linux.vnet.ibm.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170918191822.65142-10-jwi@linux.vnet.ibm.com/mbox/", "series": [ { "id": 3715, "url": "http://patchwork.ozlabs.org/api/1.2/series/3715/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=3715", "date": "2017-09-18T19:18:13", "name": "s390/qeth: updates 2017-09-18", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3715/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815116/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815116/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwwmp3cVmz9s7G\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 19 Sep 2017 05:19:38 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751370AbdIRTTg (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 18 Sep 2017 15:19:36 -0400", "from mx0a-001b2d01.pphosted.com ([148.163.156.1]:54654 \"EHLO\n\tmx0a-001b2d01.pphosted.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751301AbdIRTTe (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 18 Sep 2017 15:19:34 -0400", "from pps.filterd (m0098404.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8IJJFL5104970\n\tfor <netdev@vger.kernel.org>; Mon, 18 Sep 2017 15:19:34 -0400", "from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d2m1r0k5w-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <netdev@vger.kernel.org>; Mon, 18 Sep 2017 15:19:34 -0400", "from localhost\n\tby e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <netdev@vger.kernel.org> from <jwi@linux.vnet.ibm.com>;\n\tMon, 18 Sep 2017 20:19:31 +0100", "from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196)\n\tby e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tMon, 18 Sep 2017 20:19:29 +0100", "from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com\n\t[9.149.105.232])\n\tby b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8IJJTxZ17694970; Mon, 18 Sep 2017 19:19:29 GMT", "from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id B9C2E52041;\n\tMon, 18 Sep 2017 19:14:29 +0100 (BST)", "from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9])\n\tby d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id 7B33A5203F; \n\tMon, 18 Sep 2017 19:14:29 +0100 (BST)" ], "From": "Julian Wiedmann <jwi@linux.vnet.ibm.com>", "To": "David Miller <davem@davemloft.net>", "Cc": "<netdev@vger.kernel.org>, <linux-s390@vger.kernel.org>,\n\tMartin Schwidefsky <schwidefsky@de.ibm.com>,\n\tHeiko Carstens <heiko.carstens@de.ibm.com>,\n\tStefan Raspl <raspl@linux.vnet.ibm.com>,\n\tUrsula Braun <ubraun@linux.vnet.ibm.com>,\n\tJulian Wiedmann <jwi@linux.vnet.ibm.com>", "Subject": "[PATCH net-next 9/9] s390/qeth: tidy up parameter naming for\n\tqeth_do_send_packet()", "Date": "Mon, 18 Sep 2017 21:18:22 +0200", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170918191822.65142-1-jwi@linux.vnet.ibm.com>", "References": "<20170918191822.65142-1-jwi@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17091819-0012-0000-0000-00000579E6CD", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17091819-0013-0000-0000-000018F316B5", "Message-Id": "<20170918191822.65142-10-jwi@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-18_08:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709180272", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Jens Remus <jremus@linux.vnet.ibm.com>\n\nCppcheck reports the following for drivers/s390/net/qeth_core.h:\n\n warning - line 1560 - Function 'qeth_do_send_packet' argument order\n different:\n declaration 'card, queue, skb, hdr, hd_len, offset, elements'\n definition 'card, queue, skb, hdr, offset, hd_len, elements_needed'.\n\nMatch the naming in the function's declaration against its definition.\n\nSigned-off-by: Jens Remus <jremus@linux.vnet.ibm.com>\nReviewed-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>\nSigned-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>\n---\n drivers/s390/net/qeth_core.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/s390/net/qeth_core.h b/drivers/s390/net/qeth_core.h\nindex b7e8531625aa..91fcadbede80 100644\n--- a/drivers/s390/net/qeth_core.h\n+++ b/drivers/s390/net/qeth_core.h\n@@ -967,7 +967,8 @@ int qeth_do_send_packet_fast(struct qeth_qdio_out_q *queue, struct sk_buff *skb,\n \t\t\t unsigned int hd_len);\n int qeth_do_send_packet(struct qeth_card *card, struct qeth_qdio_out_q *queue,\n \t\t\tstruct sk_buff *skb, struct qeth_hdr *hdr,\n-\t\t\tunsigned int hd_len, unsigned int offset, int elements);\n+\t\t\tunsigned int offset, unsigned int hd_len,\n+\t\t\tint elements_needed);\n int qeth_do_ioctl(struct net_device *dev, struct ifreq *rq, int cmd);\n int qeth_core_get_sset_count(struct net_device *, int);\n void qeth_core_get_ethtool_stats(struct net_device *,\n", "prefixes": [ "net-next", "9/9" ] }