Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/815074/?format=api
{ "id": 815074, "url": "http://patchwork.ozlabs.org/api/1.2/patches/815074/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1505759538-15365-1-git-send-email-thuth@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505759538-15365-1-git-send-email-thuth@redhat.com>", "list_archive_url": null, "date": "2017-09-18T18:32:18", "name": "default-configs: Replace $(and ...) with $(call land, ...)", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "504d01faff67e40cc623b6117a0d0982ca1c1572", "submitter": { "id": 66152, "url": "http://patchwork.ozlabs.org/api/1.2/people/66152/?format=api", "name": "Thomas Huth", "email": "thuth@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1505759538-15365-1-git-send-email-thuth@redhat.com/mbox/", "series": [ { "id": 3704, "url": "http://patchwork.ozlabs.org/api/1.2/series/3704/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3704", "date": "2017-09-18T18:32:18", "name": "default-configs: Replace $(and ...) with $(call land, ...)", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3704/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815074/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815074/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwvlX0Bz3z9s7B\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Sep 2017 04:33:27 +1000 (AEST)", "from localhost ([::1]:38281 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1du0rG-0003US-4X\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 14:33:26 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:35909)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <thuth@redhat.com>) id 1du0qQ-0003Ce-Md\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 14:32:36 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <thuth@redhat.com>) id 1du0qN-0000RQ-IK\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 14:32:34 -0400", "from mx1.redhat.com ([209.132.183.28]:57988)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <thuth@redhat.com>) id 1du0qN-0000QJ-A0\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 14:32:31 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4A86A7EA97;\n\tMon, 18 Sep 2017 18:32:29 +0000 (UTC)", "from thh440s.redhat.com (ovpn-116-57.ams2.redhat.com\n\t[10.36.116.57])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9F56960610;\n\tMon, 18 Sep 2017 18:32:19 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 4A86A7EA97", "From": "Thomas Huth <thuth@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 18 Sep 2017 20:32:18 +0200", "Message-Id": "<1505759538-15365-1-git-send-email-thuth@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tMon, 18 Sep 2017 18:32:29 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH] default-configs: Replace $(and ...) with\n\t$(call land, ...)", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Michael S Tsirkin <mst@redhat.com>, Cornelia Huck <cohuck@redhat.com>,\n\tChristian Borntraeger <borntraeger@de.ibm.com>, =?utf-8?q?Marc-Andr?=\n\t=?utf-8?b?w6kgTHVyZWF1?= <marcandre.lureau@gmail.com>,\n\tMarcel Apfelbaum <marcel@redhat.com>,\n\tPaolo Bonzini <pbonzini@redhat.com>, David Gibson\n\t<david@gibson.dropbear.id.au>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Using $(and ...) is dangerous here: It only works as long as the first \nargument is set to 'y' or completely unset. It does not work if the\nfirst argument is set to 'n' for example. Let's use the \"land\" make\nfunction instead which has been written explicitely for this purpose.\n\nSigned-off-by: Thomas Huth <thuth@redhat.com>\n---\n default-configs/pci.mak | 2 +-\n default-configs/ppc-softmmu.mak | 2 +-\n default-configs/ppc64-softmmu.mak | 4 ++--\n default-configs/s390x-softmmu.mak | 2 +-\n 4 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/default-configs/pci.mak b/default-configs/pci.mak\nindex a758630..187e438 100644\n--- a/default-configs/pci.mak\n+++ b/default-configs/pci.mak\n@@ -43,4 +43,4 @@ CONFIG_VGA=y\n CONFIG_VGA_PCI=y\n CONFIG_IVSHMEM_DEVICE=$(CONFIG_IVSHMEM)\n CONFIG_ROCKER=y\n-CONFIG_VHOST_USER_SCSI=$(and $(CONFIG_VHOST_USER),$(CONFIG_LINUX))\n+CONFIG_VHOST_USER_SCSI=$(call land,$(CONFIG_VHOST_USER),$(CONFIG_LINUX))\ndiff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-softmmu.mak\nindex a3972c5..d7a3755 100644\n--- a/default-configs/ppc-softmmu.mak\n+++ b/default-configs/ppc-softmmu.mak\n@@ -43,7 +43,7 @@ CONFIG_XILINX_ETHLITE=y\n CONFIG_PREP=y\n CONFIG_MAC=y\n CONFIG_E500=y\n-CONFIG_OPENPIC_KVM=$(and $(CONFIG_E500),$(CONFIG_KVM))\n+CONFIG_OPENPIC_KVM=$(call land,$(CONFIG_E500),$(CONFIG_KVM))\n CONFIG_PLATFORM_BUS=y\n CONFIG_ETSEC=y\n CONFIG_LIBDECNUMBER=y\ndiff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak\nindex af32589..9086475 100644\n--- a/default-configs/ppc64-softmmu.mak\n+++ b/default-configs/ppc64-softmmu.mak\n@@ -48,7 +48,7 @@ CONFIG_POWERNV=y\n CONFIG_PREP=y\n CONFIG_MAC=y\n CONFIG_E500=y\n-CONFIG_OPENPIC_KVM=$(and $(CONFIG_E500),$(CONFIG_KVM))\n+CONFIG_OPENPIC_KVM=$(call land,$(CONFIG_E500),$(CONFIG_KVM))\n CONFIG_PLATFORM_BUS=y\n CONFIG_ETSEC=y\n CONFIG_LIBDECNUMBER=y\n@@ -56,7 +56,7 @@ CONFIG_SM501=y\n # For pSeries\n CONFIG_XICS=$(CONFIG_PSERIES)\n CONFIG_XICS_SPAPR=$(CONFIG_PSERIES)\n-CONFIG_XICS_KVM=$(and $(CONFIG_PSERIES),$(CONFIG_KVM))\n+CONFIG_XICS_KVM=$(call land,$(CONFIG_PSERIES),$(CONFIG_KVM))\n # For PReP\n CONFIG_SERIAL_ISA=y\n CONFIG_MC146818RTC=y\ndiff --git a/default-configs/s390x-softmmu.mak b/default-configs/s390x-softmmu.mak\nindex 6ab2bc6..444bf16 100644\n--- a/default-configs/s390x-softmmu.mak\n+++ b/default-configs/s390x-softmmu.mak\n@@ -1,6 +1,6 @@\n CONFIG_PCI=y\n CONFIG_VIRTIO_PCI=$(CONFIG_PCI)\n-CONFIG_VHOST_USER_SCSI=$(and $(CONFIG_VHOST_USER),$(CONFIG_LINUX))\n+CONFIG_VHOST_USER_SCSI=$(call land,$(CONFIG_VHOST_USER),$(CONFIG_LINUX))\n CONFIG_VIRTIO=y\n CONFIG_SCLPCONSOLE=y\n CONFIG_TERMINAL3270=y\n", "prefixes": [] }