Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/814837/?format=api
{ "id": 814837, "url": "http://patchwork.ozlabs.org/api/1.2/patches/814837/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20170918091256.GA37055@adacore.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.2/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170918091256.GA37055@adacore.com>", "list_archive_url": null, "date": "2017-09-18T09:12:56", "name": "[Ada] Scalar_Storage_Order support in conjunction with overlay", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b3307b9578cc0bc727c147ed40ec4a820edf4de0", "submitter": { "id": 64226, "url": "http://patchwork.ozlabs.org/api/1.2/people/64226/?format=api", "name": "Pierre-Marie de Rodat", "email": "derodat@adacore.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20170918091256.GA37055@adacore.com/mbox/", "series": [ { "id": 3597, "url": "http://patchwork.ozlabs.org/api/1.2/series/3597/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=3597", "date": "2017-09-18T09:12:56", "name": "[Ada] Scalar_Storage_Order support in conjunction with overlay", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3597/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814837/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814837/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-return-462364-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462364-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"s3H3clVs\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwgJy2ffkz9s7g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 19:13:06 +1000 (AEST)", "(qmail 42456 invoked by alias); 18 Sep 2017 09:12:59 -0000", "(qmail 41778 invoked by uid 89); 18 Sep 2017 09:12:59 -0000", "from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tMon, 18 Sep 2017 09:12:58 +0000", "from localhost (localhost.localdomain [127.0.0.1])\tby\n\tfiltered-rock.gnat.com (Postfix) with ESMTP id C93A6560EA;\n\tMon, 18 Sep 2017 05:12:56 -0400 (EDT)", "from rock.gnat.com ([127.0.0.1])\tby localhost (rock.gnat.com\n\t[127.0.0.1]) (amavisd-new, port 10024)\twith LMTP id\n\ttfY4+8oYJwrY; Mon, 18 Sep 2017 05:12:56 -0400 (EDT)", "from tron.gnat.com (tron.gnat.com [205.232.38.10])\tby\n\trock.gnat.com (Postfix) with ESMTP id B8810560E6;\n\tMon, 18 Sep 2017 05:12:56 -0400 (EDT)", "by tron.gnat.com (Postfix, from userid 4862)\tid B75544FC;\n\tMon, 18 Sep 2017 05:12:56 -0400 (EDT)" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:mime-version:content-type; q=dns;\n\ts=default; b=nLp9ElytLfGP3tuDPUBkkem4ji8ThCCs34kvs8MJQGCV92tDpt\n\ttKnL548YOqgoI9ctJTS2kU6YKAvnfFKSqzlUIVv7nX3fNPnYDpV9l60nT69Fur5j\n\tXZ4yAZbLPtblEhMfxOGT1z6kdmSufoKnoz7p45cDqeB7FBa+/uAnMFkoQ=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:mime-version:content-type; s=\n\tdefault; bh=Tap5qk/2iZpU0Wkrx+YLx9NfwBw=; b=s3H3clVst2Q0OXrO+Ty4\n\tgcNiMxVY9So/kGvl93QOnZfxbJa+h7ISxkEZ4QoZVrcULsU2yC9NJUDANGO226yI\n\tEZEhn9320yRoM2Xz9J9vESBw729ULbFh3uJWO4jesvYKeBafFXhjj4uey82jCY6C\n\t/tHaEerr3G08AmMAetZ2ye0=", "Mailing-List": "contact gcc-patches-help@gcc.gnu.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "List-Archive": "<http://gcc.gnu.org/ml/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-help@gcc.gnu.org>", "Sender": "gcc-patches-owner@gcc.gnu.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-11.9 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=", "X-HELO": "rock.gnat.com", "Date": "Mon, 18 Sep 2017 05:12:56 -0400", "From": "Pierre-Marie de Rodat <derodat@adacore.com>", "To": "gcc-patches@gcc.gnu.org", "Cc": "Eric Botcazou <ebotcazou@adacore.com>", "Subject": "[Ada] Scalar_Storage_Order support in conjunction with overlay", "Message-ID": "<20170918091256.GA37055@adacore.com>", "MIME-Version": "1.0", "Content-Type": "multipart/mixed; boundary=\"6c2NcOVqGQ03X4Wi\"", "Content-Disposition": "inline", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "X-IsSubscribed": "yes" }, "content": "Toggling the scalar storage order by means of type punning or aliasing is not\nsupported in the general case, but it might be reasonable to support simple\noverlays precisely used to test the effect of the attribute.\n\nThe following procedure must give the same output at all optimization levels:\n\nwith System;\nwith Interfaces; use Interfaces;\nwith Ada.Text_IO; use Ada.Text_IO;\n\nprocedure P is\n\n type U8Array is Array (Natural Range <>) of Unsigned_8;\n\n type One_Element_Unpacked is record\n Value : Integer;\n end record;\n\n type One_Element_Packed is new One_Element_Unpacked;\n for One_Element_Packed use record\n Value at 0 range 0 .. 31;\n end record;\n\n One_Element_Packed_Size : constant Positive := 32;\n for One_Element_Packed'Bit_Order use System.High_Order_First;\n for One_Element_Packed'Scalar_Storage_Order use System.High_Order_First;\n for One_Element_Packed'Size use One_Element_Packed_Size;\n\n subtype One_Element_Byte_Array\n is U8Array(1 .. (One_Element_Packed'Object_Size/Unsigned_8'Object_Size));\n\n function F (Input : in One_Element_Packed) return One_Element_Byte_Array is\n Result : constant One_Element_Byte_Array;\n pragma Import (Ada, Result);\n for Result'Address use Input'Address;\n begin\n return Result;\n end;\n\n a : constant One_Element_Packed := (Value => 12);\n a_bytes : constant One_Element_Byte_Array := F (a);\n\nbegin\n Put(\"Record with single component byte representation:\");\n for element of a_bytes loop\n Put(element'img & \" \");\n end loop;\nend;\n\nTested on x86_64-pc-linux-gnu, committed on trunk\n\n2017-09-18 Eric Botcazou <ebotcazou@adacore.com>\n\n\t* sem_ch13.adb (Analyze_Attribute_Definition_Clause) <Address>: Mark\n\tthe entity as being volatile for an overlay that toggles the scalar\n\tstorage order.", "diff": "Index: sem_ch13.adb\n===================================================================\n--- sem_ch13.adb\t(revision 252907)\n+++ sem_ch13.adb\t(working copy)\n@@ -5084,6 +5084,22 @@\n Register_Address_Clause_Check\n (N, U_Ent, No_Uint, O_Ent, Off);\n end if;\n+\n+ -- If the overlay changes the storage order, mark the\n+ -- entity as being volatile to block any optimization\n+ -- for it since the construct is not really supported\n+ -- by the back end.\n+\n+ if (Is_Record_Type (Etype (U_Ent))\n+ or else Is_Array_Type (Etype (U_Ent)))\n+ and then (Is_Record_Type (Etype (O_Ent))\n+ or else Is_Array_Type (Etype (O_Ent)))\n+ and then Reverse_Storage_Order (Etype (U_Ent))\n+ /= Reverse_Storage_Order (Etype (O_Ent))\n+ then\n+ Set_Treat_As_Volatile (U_Ent);\n+ end if;\n+\n else\n -- If this is not an overlay, mark a variable as being\n -- volatile to prevent unwanted optimizations. It's a\n", "prefixes": [ "Ada" ] }