Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/814808/?format=api
{ "id": 814808, "url": "http://patchwork.ozlabs.org/api/1.2/patches/814808/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/2507479.MzcqCaxoQO@polaris/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.2/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<2507479.MzcqCaxoQO@polaris>", "list_archive_url": null, "date": "2017-09-18T07:50:45", "name": "Fix PR target/81361", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c2be415ad78dad7fd014b66d5f9f148616d3668a", "submitter": { "id": 4365, "url": "http://patchwork.ozlabs.org/api/1.2/people/4365/?format=api", "name": "Eric Botcazou", "email": "ebotcazou@adacore.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/2507479.MzcqCaxoQO@polaris/mbox/", "series": [ { "id": 3577, "url": "http://patchwork.ozlabs.org/api/1.2/series/3577/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=3577", "date": "2017-09-18T07:50:45", "name": "Fix PR target/81361", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3577/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814808/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814808/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-return-462355-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462355-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"sANLT1N6\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwdVl1grSz9s3w\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 17:51:27 +1000 (AEST)", "(qmail 114366 invoked by alias); 18 Sep 2017 07:51:16 -0000", "(qmail 102931 invoked by uid 89); 18 Sep 2017 07:50:53 -0000", "from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210)\n\tby sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with\n\tESMTP; Mon, 18 Sep 2017 07:50:50 +0000", "from localhost (localhost [127.0.0.1])\tby\n\tfiltered-smtp.eu.adacore.com (Postfix) with ESMTP id\n\t9D6FD822AA\tfor <gcc-patches@gcc.gnu.org>;\n\tMon, 18 Sep 2017 09:50:48 +0200 (CEST)", "from smtp.eu.adacore.com ([127.0.0.1])\tby localhost\n\t(smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port\n\t10024)\twith ESMTP id eEjTnNEPQ4yP for <gcc-patches@gcc.gnu.org>;\n\tMon, 18 Sep 2017 09:50:48 +0200 (CEST)", "from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net\n\t[88.161.99.133])\t(using TLSv1.2 with cipher\n\tECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\t(No client\n\tcertificate requested)\tby smtp.eu.adacore.com (Postfix) with\n\tESMTPSA id 720E1822A7\tfor <gcc-patches@gcc.gnu.org>;\n\tMon, 18 Sep 2017 09:50:48 +0200 (CEST)" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:from\n\t:to:subject:date:message-id:mime-version:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=O5cUXquJiWHOCgso\n\t1dhUvg2Th+fueWf0daE5ksbJEKAWbucupoDvJiYXbV+0t+SyqYG1U/ggruyuUt+E\n\t8WbtAJKA9IkcMW7+YGjYF9VGrqPKoediOBJK8W8mCtMv+2g3BTfCaUdZ6pNLUw3R\n\tndzWW+XD+XikhpN0cmqzWvlVLyY=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:from\n\t:to:subject:date:message-id:mime-version:content-type\n\t:content-transfer-encoding; s=default; bh=nyYjHFIwNsaUQHPH3sj8ky\n\trjSQU=; b=sANLT1N6MKc+FzrilhsmNqJ7ttBMXJzQ9jFKBpQdV7JZptDJPW56KZ\n\tbFXRUagUjsqXj88s/YYf4x7pS37Uu3Un3pF4wghSHTYV3K4dh3Y2TrkIOWGC/Yfl\n\tAZ1GxDUZsEaa2mqrq7NeeiJNp3/alZA4KMJ0iN/qCJ06J7GPchp0I=", "Mailing-List": "contact gcc-patches-help@gcc.gnu.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "List-Archive": "<http://gcc.gnu.org/ml/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-help@gcc.gnu.org>", "Sender": "gcc-patches-owner@gcc.gnu.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-15.4 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=", "X-HELO": "smtp.eu.adacore.com", "From": "Eric Botcazou <ebotcazou@adacore.com>", "To": "gcc-patches@gcc.gnu.org", "Subject": "[patch] Fix PR target/81361", "Date": "Mon, 18 Sep 2017 09:50:45 +0200", "Message-ID": "<2507479.MzcqCaxoQO@polaris>", "User-Agent": "KMail/4.14.10 (Linux/3.16.7-53-desktop; KDE/4.14.9; x86_64; ; )", "MIME-Version": "1.0", "Content-Type": "multipart/mixed; boundary=\"nextPart3126022.TeLj9WWodM\"", "Content-Transfer-Encoding": "7Bit" }, "content": "Hi,\n\nexception handling is currently broken in all languages for Darwin at -O2 on \nthe mainline because of what appears to be a bug in either the assembler or \nthe system unwinder. The problem occurs when the compiler decides to split a \nfunction into hot & cold parts and the cold part is active wrt EH; in this \ncase, the compiler generates a FDE for each part (the Darwin port doesn't use \nthe CFI assembler directives) and the second FDE looks like:\n\n.set L$set$24,LEFDE3-LASFDE3\n\t.long L$set$24\t# FDE Length\nLASFDE3:\n\t.long\tLASFDE3-EH_frame1\t# FDE CIE offset\n\t.quad\tLCOLDB1-.\t# FDE initial location\n\t.set L$set$25,LCOLDE1-LCOLDB1\n\t.quad L$set$25\t# FDE address range\n\t.byte\t0x8\t# uleb128 0x8; Augmentation size\n\t.quad\tLLSDAC5-.\t# Language Specific Data Area\n\t.byte\t0x1\t# DW_CFA_set_loc\n\t.quad\tLCFI1-.\n\t.byte\t0xe\t# DW_CFA_def_cfa_offset\n\t.byte\t0x10\t# uleb128 0x10\n\t.byte\t0x83\t# DW_CFA_offset, column 0x3\n\t.byte\t0x2\t# uleb128 0x2\n\nNote the DW_CFA_set_loc operation: it's the only case where the compiler emits \nit (DW_CFA_advance_loc4 is usually emitted) and is the source of the problem, \nsince it appears that the PC-relative relocation is not applied to the operand \nof the DW_CFA_set_loc (unlike to the 2 other cases in the FDE).\n\nThis DW_CFA_set_loc instruction is emitted by add_cfis_to_fde for the second \nFDE generated for the cold part of a function but doesn't seem necessary any \nmore, since there is a label (LCOLDB1) to be used now (this can also be seen \non Linux with the -fno-dwarf2-cfi-asm option).\n\nBootstrapped/regtested on x86-64/Linux by me and various versions of Darwin by \nIain, Dominique and myself. OK for the mainline?\n\n\n2017-09-18 Eric Botcazou <ebotcazou@adacore.com>\n\n\tPR target/81361\n\t* dwarf2cfi.c (add_cfis_to_fde): Do not generate DW_CFA_set_loc\n\tafter switching to a new text section.", "diff": "Index: dwarf2cfi.c\n===================================================================\n--- dwarf2cfi.c\t(revision 252749)\n+++ dwarf2cfi.c\t(working copy)\n@@ -2209,20 +2209,13 @@ add_cfis_to_fde (void)\n {\n dw_fde_ref fde = cfun->fde;\n rtx_insn *insn, *next;\n- /* We always start with a function_begin label. */\n- bool first = false;\n \n for (insn = get_insns (); insn; insn = next)\n {\n next = NEXT_INSN (insn);\n \n if (NOTE_P (insn) && NOTE_KIND (insn) == NOTE_INSN_SWITCH_TEXT_SECTIONS)\n-\t{\n-\t fde->dw_fde_switch_cfi_index = vec_safe_length (fde->dw_fde_cfi);\n-\t /* Don't attempt to advance_loc4 between labels\n-\t in different sections. */\n-\t first = true;\n-\t}\n+\tfde->dw_fde_switch_cfi_index = vec_safe_length (fde->dw_fde_cfi);\n \n if (NOTE_P (insn) && NOTE_KIND (insn) == NOTE_INSN_CFI)\n \t{\n@@ -2247,8 +2240,7 @@ add_cfis_to_fde (void)\n \n \t /* Set the location counter to the new label. */\n \t xcfi = new_cfi ();\n-\t xcfi->dw_cfi_opc = (first ? DW_CFA_set_loc\n-\t\t\t\t : DW_CFA_advance_loc4);\n+\t xcfi->dw_cfi_opc = DW_CFA_advance_loc4;\n \t xcfi->dw_cfi_oprnd1.dw_cfi_addr = label;\n \t vec_safe_push (fde->dw_fde_cfi, xcfi);\n \n@@ -2263,7 +2255,6 @@ add_cfis_to_fde (void)\n \t insn = NEXT_INSN (insn);\n \t }\n \t while (insn != next);\n-\t first = false;\n \t}\n }\n }\n", "prefixes": [] }