Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/814718/?format=api
{ "id": 814718, "url": "http://patchwork.ozlabs.org/api/1.2/patches/814718/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170917232842.14544-1-f4bug@amsat.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170917232842.14544-1-f4bug@amsat.org>", "list_archive_url": null, "date": "2017-09-17T23:28:42", "name": "qom/cpu: move cpu_model null check to cpu_class_by_name()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "57e49b1d0faded88c3f8fe616e7a33ecb809d780", "submitter": { "id": 70924, "url": "http://patchwork.ozlabs.org/api/1.2/people/70924/?format=api", "name": "Philippe Mathieu-Daudé", "email": "f4bug@amsat.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170917232842.14544-1-f4bug@amsat.org/mbox/", "series": [ { "id": 3550, "url": "http://patchwork.ozlabs.org/api/1.2/series/3550/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3550", "date": "2017-09-17T23:28:42", "name": "qom/cpu: move cpu_model null check to cpu_class_by_name()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3550/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814718/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814718/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"s1C6qcO9\"; dkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwQMg03fwz9s7h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 09:29:34 +1000 (AEST)", "from localhost ([::1]:33986 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dtj0G-0008Fx-Ut\n\tfor incoming@patchwork.ozlabs.org; Sun, 17 Sep 2017 19:29:32 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:46258)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dtizo-0008FU-TH\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 19:29:07 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dtizk-00056p-9c\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 19:29:04 -0400", "from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:33285)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dtizk-00056e-4v; Sun, 17 Sep 2017 19:29:00 -0400", "by mail-qt0-x244.google.com with SMTP id b1so4720160qtc.0;\n\tSun, 17 Sep 2017 16:29:00 -0700 (PDT)", "from yoga.offpageads.com ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tu133sm4162279qka.92.2017.09.17.16.28.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 17 Sep 2017 16:28:58 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=zOroSb19kmoQU/bQT4aanpA9QRWKuBpUwRPCcWUTVfc=;\n\tb=s1C6qcO9tVTLkcKtetF+YWa1XeM6BlXyliGf0dpaZyMIAGOmz27jtA8wmLSh4H1gk0\n\tNZkWYqR3aVgDApsYhIV9Z2dzYiRF87rOz9nNlEIGqd9aFiPwTBRMon9W4ztLOzhoUpe3\n\t4mU2kdKxqvl09SgQxbCUqMgjJLKyxPrHGCapXDN+GbS+E41go9n83ArMLc2/Q2seBl40\n\tLvus+Dxy3JmSMbYz+BZNWmKopc/SWUrIpBKKT+sWqGOC6bMXFJE5XgeCd3v+9ipco2kl\n\tIA0ot0PdVE1oqzcYz8dmScHw8c9Sny9srmw3ANUlWek8SdNTkFWSvPAl/+k5SuaAamw1\n\ti8Yg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:mime-version:content-transfer-encoding;\n\tbh=zOroSb19kmoQU/bQT4aanpA9QRWKuBpUwRPCcWUTVfc=;\n\tb=A5U54aOTNLiymPqWu4CoVqYXzSUgA811vRNHUvK9MFlLrPPzYaTeS1eFQfBMgSugB1\n\t57LEtwFuLuo409nWKND98Vgo6DDYksOUzJxAtaaaKRZB1OHb/YsqTLybXrHV7MSqoYiP\n\tRMysanXVC+GrrqUTIL5sBOhMOJZYWvq0Sxg1wbWh35mfFntT0Ovf0EKrVbVGuwkPutn3\n\txRgmKWj3myJUedN7gNNujNoXlCYpoQ0h+rIZRWKCC4kdyh7ubY9X4bUdxC8EcGly9NTb\n\thZw1yzLOOICXgwVnWLb9sA5dFKNWDKbib9eONsnGIQHF5m9i/aIeiocvI6Qs8J1TUizC\n\tgg5w==", "X-Gm-Message-State": "AHPjjUgONJ2vrIsHXBYLl54jjDs4pT5Z1LevG4JXFrQP2+Ojf5dvWztX\n\tjx5ii3wUVkMIww==", "X-Google-Smtp-Source": "AOwi7QDTmJipiRIA7tpmUDAMhb1yLVao+rS5Bxi9BGL5MLBK+ydix95rDnM+nSrTrCF+qJM9A05p+Q==", "X-Received": "by 10.200.15.132 with SMTP id b4mr49202021qtk.127.1505690939552; \n\tSun, 17 Sep 2017 16:28:59 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>", "To": "Igor Mammedov <imammedo@redhat.com>,\n\tEduardo Habkost <ehabkost@redhat.com>, Stefan Hajnoczi\n\t<stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, \n\t=?utf-8?q?Llu=C3=ADs_Vilanova?= <vilanova@ac.upc.edu>,\n\tRichard Henderson <rth@twiddle.net>, Alexander Graf <agraf@suse.de>, \n\tAnthony Green <green@moxielogic.com>, Artyom Tarasenko\n\t<atar4qemu@gmail.com>, \tAurelien Jarno <aurelien@aurel32.net>,\n\tBastian Koppelmann <kbastian@mail.uni-paderborn.de>, \n\tChris Wulff <crwulff@gmail.com>, David Gibson\n\t<david@gibson.dropbear.id.au>, \"Edgar E. Iglesias\"\n\t<edgar.iglesias@gmail.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>,\n\tLaurent Vivier <laurent@vivier.eu>, \tMarek Vasut <marex@denx.de>,\n\tMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, \n\tMax Filippov <jcmvbkbc@gmail.com>, Michael Walle <michael@walle.cc>, \n\tPeter Maydell <peter.maydell@linaro.org>, \n\tStafford Horne <shorne@gmail.com>, Yongbok Kim <yongbok.kim@imgtec.com>", "Date": "Sun, 17 Sep 2017 20:28:42 -0300", "Message-Id": "<20170917232842.14544-1-f4bug@amsat.org>", "X-Mailer": "git-send-email 2.14.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2607:f8b0:400d:c0d::244", "Subject": "[Qemu-devel] [PATCH] qom/cpu: move cpu_model null check to\n\tcpu_class_by_name()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>,\n\tqemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, \n\tMarcel Apfelbaum <marcel@redhat.com>, =?utf-8?q?Marc-Andr=C3=A9_Lurea?=\n\t=?utf-8?q?u?= <marcandre.lureau@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "and clean every implementation.\n\nSuggested-by: Eduardo Habkost <ehabkost@redhat.com>\nSigned-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n---\nBased-on: 20170917232010.14183-7-f4bug@amsat.org\n\n qom/cpu.c | 7 ++++++-\n target/alpha/cpu.c | 6 +-----\n target/arm/cpu.c | 4 ----\n target/cris/cpu.c | 4 ----\n target/lm32/cpu.c | 4 ----\n target/m68k/cpu.c | 4 ----\n target/mips/cpu.c | 4 ----\n target/moxie/cpu.c | 8 +-------\n target/openrisc/cpu.c | 4 ----\n target/sh4/cpu.c | 3 ---\n target/sparc/cpu.c | 4 ----\n target/tricore/cpu.c | 4 ----\n target/unicore32/cpu.c | 4 ----\n target/xtensa/cpu.c | 4 ----\n 14 files changed, 8 insertions(+), 56 deletions(-)", "diff": "diff --git a/qom/cpu.c b/qom/cpu.c\nindex dc5392dbeb..411d8cdd2b 100644\n--- a/qom/cpu.c\n+++ b/qom/cpu.c\n@@ -311,7 +311,12 @@ static bool cpu_common_has_work(CPUState *cs)\n \n ObjectClass *cpu_class_by_name(const char *typename, const char *cpu_model)\n {\n- CPUClass *cc = CPU_CLASS(object_class_by_name(typename));\n+ CPUClass *cc;\n+\n+ if (!cpu_model) {\n+ return NULL;\n+ }\n+ cc = CPU_CLASS(object_class_by_name(typename));\n \n return cc->class_by_name(cpu_model);\n }\ndiff --git a/target/alpha/cpu.c b/target/alpha/cpu.c\nindex e6c6aabdf0..b8a21f4e01 100644\n--- a/target/alpha/cpu.c\n+++ b/target/alpha/cpu.c\n@@ -127,14 +127,10 @@ static const AlphaCPUAlias alpha_cpu_aliases[] = {\n \n static ObjectClass *alpha_cpu_class_by_name(const char *cpu_model)\n {\n- ObjectClass *oc = NULL;\n+ ObjectClass *oc;\n char *typename;\n int i;\n \n- if (cpu_model == NULL) {\n- return NULL;\n- }\n-\n oc = object_class_by_name(cpu_model);\n if (oc != NULL && object_class_dynamic_cast(oc, TYPE_ALPHA_CPU) != NULL &&\n !object_class_is_abstract(oc)) {\ndiff --git a/target/arm/cpu.c b/target/arm/cpu.c\nindex 412e94c7ad..ea219c2dde 100644\n--- a/target/arm/cpu.c\n+++ b/target/arm/cpu.c\n@@ -906,10 +906,6 @@ static ObjectClass *arm_cpu_class_by_name(const char *cpu_model)\n char *typename;\n char **cpuname;\n \n- if (!cpu_model) {\n- return NULL;\n- }\n-\n cpuname = g_strsplit(cpu_model, \",\", 1);\n typename = g_strdup_printf(\"%s-\" TYPE_ARM_CPU, cpuname[0]);\n oc = object_class_by_name(typename);\ndiff --git a/target/cris/cpu.c b/target/cris/cpu.c\nindex ceebfed79b..88d93f2d11 100644\n--- a/target/cris/cpu.c\n+++ b/target/cris/cpu.c\n@@ -69,10 +69,6 @@ static ObjectClass *cris_cpu_class_by_name(const char *cpu_model)\n ObjectClass *oc;\n char *typename;\n \n- if (cpu_model == NULL) {\n- return NULL;\n- }\n-\n #if defined(CONFIG_USER_ONLY)\n if (strcasecmp(cpu_model, \"any\") == 0) {\n return object_class_by_name(\"crisv32-\" TYPE_CRIS_CPU);\ndiff --git a/target/lm32/cpu.c b/target/lm32/cpu.c\nindex 2b8c36b6d0..bf081f56d2 100644\n--- a/target/lm32/cpu.c\n+++ b/target/lm32/cpu.c\n@@ -246,10 +246,6 @@ static ObjectClass *lm32_cpu_class_by_name(const char *cpu_model)\n ObjectClass *oc;\n char *typename;\n \n- if (cpu_model == NULL) {\n- return NULL;\n- }\n-\n typename = g_strdup_printf(\"%s-\" TYPE_LM32_CPU, cpu_model);\n oc = object_class_by_name(typename);\n g_free(typename);\ndiff --git a/target/m68k/cpu.c b/target/m68k/cpu.c\nindex 55bf24bae6..8c70e0805c 100644\n--- a/target/m68k/cpu.c\n+++ b/target/m68k/cpu.c\n@@ -87,10 +87,6 @@ static ObjectClass *m68k_cpu_class_by_name(const char *cpu_model)\n ObjectClass *oc;\n char *typename;\n \n- if (cpu_model == NULL) {\n- return NULL;\n- }\n-\n typename = g_strdup_printf(\"%s-\" TYPE_M68K_CPU, cpu_model);\n oc = object_class_by_name(typename);\n g_free(typename);\ndiff --git a/target/mips/cpu.c b/target/mips/cpu.c\nindex 1a9a3ed94d..c15b894362 100644\n--- a/target/mips/cpu.c\n+++ b/target/mips/cpu.c\n@@ -166,10 +166,6 @@ static ObjectClass *mips_cpu_class_by_name(const char *cpu_model)\n ObjectClass *oc;\n char *typename;\n \n- if (cpu_model == NULL) {\n- return NULL;\n- }\n-\n typename = mips_cpu_type_name(cpu_model);\n oc = object_class_by_name(typename);\n g_free(typename);\ndiff --git a/target/moxie/cpu.c b/target/moxie/cpu.c\nindex 748d02f29e..30bd44fcad 100644\n--- a/target/moxie/cpu.c\n+++ b/target/moxie/cpu.c\n@@ -89,13 +89,7 @@ static void moxie_cpu_initfn(Object *obj)\n \n static ObjectClass *moxie_cpu_class_by_name(const char *cpu_model)\n {\n- ObjectClass *oc;\n-\n- if (cpu_model == NULL) {\n- return NULL;\n- }\n-\n- oc = object_class_by_name(cpu_model);\n+ ObjectClass *oc = object_class_by_name(cpu_model);\n if (oc != NULL && (!object_class_dynamic_cast(oc, TYPE_MOXIE_CPU) ||\n object_class_is_abstract(oc))) {\n return NULL;\ndiff --git a/target/openrisc/cpu.c b/target/openrisc/cpu.c\nindex a979f0bf8b..af9cdcc102 100644\n--- a/target/openrisc/cpu.c\n+++ b/target/openrisc/cpu.c\n@@ -108,10 +108,6 @@ static ObjectClass *openrisc_cpu_class_by_name(const char *cpu_model)\n ObjectClass *oc;\n char *typename;\n \n- if (cpu_model == NULL) {\n- return NULL;\n- }\n-\n typename = g_strdup_printf(\"%s-\" TYPE_OPENRISC_CPU, cpu_model);\n oc = object_class_by_name(typename);\n g_free(typename);\ndiff --git a/target/sh4/cpu.c b/target/sh4/cpu.c\nindex 6ce7cba5a9..252440e019 100644\n--- a/target/sh4/cpu.c\n+++ b/target/sh4/cpu.c\n@@ -133,9 +133,6 @@ static ObjectClass *superh_cpu_class_by_name(const char *cpu_model)\n ObjectClass *oc;\n GSList *list, *item;\n \n- if (cpu_model == NULL) {\n- return NULL;\n- }\n if (strcasecmp(cpu_model, \"any\") == 0) {\n return object_class_by_name(TYPE_SH7750R_CPU);\n }\ndiff --git a/target/sparc/cpu.c b/target/sparc/cpu.c\nindex 0806d699e6..beab90f3e6 100644\n--- a/target/sparc/cpu.c\n+++ b/target/sparc/cpu.c\n@@ -730,10 +730,6 @@ static ObjectClass *sparc_cpu_class_by_name(const char *cpu_model)\n ObjectClass *oc;\n char *typename;\n \n- if (cpu_model == NULL) {\n- return NULL;\n- }\n-\n typename = sparc_cpu_type_name(cpu_model);\n oc = object_class_by_name(typename);\n g_free(typename);\ndiff --git a/target/tricore/cpu.c b/target/tricore/cpu.c\nindex 5ab5b56454..871eb35453 100644\n--- a/target/tricore/cpu.c\n+++ b/target/tricore/cpu.c\n@@ -120,10 +120,6 @@ static ObjectClass *tricore_cpu_class_by_name(const char *cpu_model)\n ObjectClass *oc;\n char *typename;\n \n- if (!cpu_model) {\n- return NULL;\n- }\n-\n typename = g_strdup_printf(\"%s-\" TYPE_TRICORE_CPU, cpu_model);\n oc = object_class_by_name(typename);\n g_free(typename);\ndiff --git a/target/unicore32/cpu.c b/target/unicore32/cpu.c\nindex c9b78ce68e..138acc9dd8 100644\n--- a/target/unicore32/cpu.c\n+++ b/target/unicore32/cpu.c\n@@ -44,10 +44,6 @@ static ObjectClass *uc32_cpu_class_by_name(const char *cpu_model)\n ObjectClass *oc;\n char *typename;\n \n- if (cpu_model == NULL) {\n- return NULL;\n- }\n-\n typename = g_strdup_printf(\"%s-\" TYPE_UNICORE32_CPU, cpu_model);\n oc = object_class_by_name(typename);\n g_free(typename);\ndiff --git a/target/xtensa/cpu.c b/target/xtensa/cpu.c\nindex 85897df0a8..dcdc765a86 100644\n--- a/target/xtensa/cpu.c\n+++ b/target/xtensa/cpu.c\n@@ -83,10 +83,6 @@ static ObjectClass *xtensa_cpu_class_by_name(const char *cpu_model)\n ObjectClass *oc;\n char *typename;\n \n- if (cpu_model == NULL) {\n- return NULL;\n- }\n-\n typename = g_strdup_printf(\"%s-\" TYPE_XTENSA_CPU, cpu_model);\n oc = object_class_by_name(typename);\n g_free(typename);\n", "prefixes": [] }