Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 814441,
    "url": "http://patchwork.ozlabs.org/api/1.2/patches/814441/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170916002305.2794-1-rosenp@gmail.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170916002305.2794-1-rosenp@gmail.com>",
    "list_archive_url": null,
    "date": "2017-09-16T00:23:05",
    "name": "bgmac: Remove all offloading features, including GRO.",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "6bfb443aa71bbef22d03355552428e2eed284bba",
    "submitter": {
        "id": 70304,
        "url": "http://patchwork.ozlabs.org/api/1.2/people/70304/?format=api",
        "name": "Rosen Penev",
        "email": "rosenp@gmail.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170916002305.2794-1-rosenp@gmail.com/mbox/",
    "series": [
        {
            "id": 3402,
            "url": "http://patchwork.ozlabs.org/api/1.2/series/3402/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=3402",
            "date": "2017-09-16T00:23:05",
            "name": "bgmac: Remove all offloading features, including GRO.",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/3402/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/814441/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/814441/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"X22n0hHU\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvCfj23Crz9sRW\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 16 Sep 2017 10:23:25 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751422AbdIPAXT (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 15 Sep 2017 20:23:19 -0400",
            "from mail-pf0-f193.google.com ([209.85.192.193]:35946 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751201AbdIPAXS (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 15 Sep 2017 20:23:18 -0400",
            "by mail-pf0-f193.google.com with SMTP id f84so1896853pfj.3\n\tfor <netdev@vger.kernel.org>; Fri, 15 Sep 2017 17:23:18 -0700 (PDT)",
            "from mangix.lan ([2001:470:1f05:c3e::8ce])\n\tby smtp.gmail.com with ESMTPSA id\n\tw12sm3655336pfk.83.2017.09.15.17.23.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 15 Sep 2017 17:23:17 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=v4TJYpcNTvgWGBXnjM2NSC5LPa4hwv/eELlRr8Hhyp8=;\n\tb=X22n0hHUE6B/tnMkp44fVHzvTsMH3FpvR5m/3SjHDGVkBr5Pe+rbj72HgsnvOWf5G2\n\tGkrDrgaGVF9n0Qip+Yn21RPCOszWrGyg9Z4S4SRC/5+PBjQ0JL6lyJ497/jAgqMncZ15\n\teeddomnU7SAeyd+zt/Z1QBDC8YDwsvKbEkeGttkuHRqt+W30S5CWZMiSpo9Ro9caRwfU\n\t5d7L8q9abAyUp78v9M0zfmALTN3/G8nskU1IqinWPp5fN+8MqRj0xAP9FE2HoJDaSVdc\n\tDCE0iubLyyrVHU7N5SsTpmWXDbWyjKIYKLwfr6J6fNUTFYgEArdkZmfkuHu3vMlsiPa3\n\tr3lA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=v4TJYpcNTvgWGBXnjM2NSC5LPa4hwv/eELlRr8Hhyp8=;\n\tb=mUMDgHHXGrT5+rlVcAlcZyYZhoOoxY9D6ePVw/z6MNfm01iex8ZAuQ9kOwgfwJSXT8\n\tI2rRDVbytyjD5u+hyzcVuk92ajb6yWuaNjVMKELZRW9CJShmYtVNQs0LKoqVM28VQMYK\n\tEtPt1x/S+msdVqNn9WZsw9SAcFurwJs88swFRKNgbeS6ieOjGbiDl5NpzM9N/2I2OYPH\n\tPYtMQ6UhUlEBsq6TsZSU5pB2gvF5xdOrmq8SZ/4u3zQLRHj/ss+zCpQOObr+0Ok0xc/N\n\ttG590q9BzlsliHNsawSdvDFTfpbEJSniwkyFSRImObkJpPOtsAyKj625PTpWx5TFNVMz\n\thigg==",
        "X-Gm-Message-State": "AHPjjUgDBurxs/UeIbBdeQzmCJSoAXHKqHPBWObIoELLc8j+MfUvOBmI\n\tjVeveRAUmTic+nABIu4=",
        "X-Google-Smtp-Source": "AOwi7QDxpKi4nAnqwKdybQ6IeFKf3kUPRy3dPym0HHJShzkRG4MTGCQkrUQOZYwu24prJsjiQ9nKIg==",
        "X-Received": "by 10.84.253.151 with SMTP id a23mr8453644plm.144.1505521397913; \n\tFri, 15 Sep 2017 17:23:17 -0700 (PDT)",
        "From": "Rosen Penev <rosenp@gmail.com>",
        "To": "netdev@vger.kernel.org",
        "Cc": "Rosen Penev <rosenp@gmail.com>",
        "Subject": "[PATCH] bgmac: Remove all offloading features, including GRO.",
        "Date": "Fri, 15 Sep 2017 17:23:05 -0700",
        "Message-Id": "<20170916002305.2794-1-rosenp@gmail.com>",
        "X-Mailer": "git-send-email 2.13.5",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "On a linksys E1200v1 (actually a crossflashed E1000v2), the offloading features give no measurable benefit to speed or latency. Furthermore, disabling GRO actually improves iperf performance by a whoppimg 3mbps. Results:\n\nCurrently:\n\n[  4] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52410\n[ ID] Interval        Transfer    Bandwidth       Reads   Dist(bin=16.0K)\n[  4] 0.00-10.02 sec  52.4 MBytes  43.8 Mbits/sec  641    75:181:12:1:1:0:0:371\n[  5] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52412\n[  5] 0.00-10.02 sec  52.4 MBytes  43.8 Mbits/sec  629    51:194:13:1:0:1:0:369\n[  4] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52414\n[  4] 0.00-10.02 sec  51.9 MBytes  43.4 Mbits/sec  695    126:203:1:0:0:0:2:363\n[  5] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52416\n[  5] 0.00-10.01 sec  52.4 MBytes  43.9 Mbits/sec  626    57:186:10:0:0:0:0:373\n[  4] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52420\n[  4] 0.00-10.02 sec  52.4 MBytes  43.8 Mbits/sec  605    36:179:16:1:0:1:0:372\n[  5] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52422\n\nAfter disabling everything - including GRO:\n\n[  4] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52440\n[ ID] Interval        Transfer    Bandwidth       Reads   Dist(bin=16.0K)\n[  4] 0.00-10.01 sec  55.1 MBytes  46.2 Mbits/sec  672    180:82:0:0:1:0:0:409\n[  5] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52442\n[  5] 0.00-10.01 sec  56.0 MBytes  46.9 Mbits/sec  636    117:96:0:0:1:0:0:422\n[  4] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52444\n[  4] 0.00-10.01 sec  55.4 MBytes  46.4 Mbits/sec  675    172:92:0:0:1:0:0:410\n[  5] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52446\n[  5] 0.00-10.01 sec  56.0 MBytes  46.9 Mbits/sec  633    119:90:0:1:1:0:0:422\n[  4] local 192.168.1.1 port 5001 connected with 192.168.1.100 port 52448\n[  4] 0.00-10.01 sec  55.2 MBytes  46.3 Mbits/sec  688    157:123:0:0:2:0:0:406\n\nv2: Changed napi_gro_receive to netif_receive_skb. Seems to have an identical result.\n\nSigned-off-by: Rosen Penev <rosenp@gmail.com>\n---\n drivers/net/ethernet/broadcom/bgmac.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c\nindex 48d672b204a4..1fb0053aeee7 100644\n--- a/drivers/net/ethernet/broadcom/bgmac.c\n+++ b/drivers/net/ethernet/broadcom/bgmac.c\n@@ -483,7 +483,7 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring,\n \t\t\tskb->protocol = eth_type_trans(skb, bgmac->net_dev);\n \t\t\tbgmac->net_dev->stats.rx_bytes += len;\n \t\t\tbgmac->net_dev->stats.rx_packets++;\n-\t\t\tnapi_gro_receive(&bgmac->napi, skb);\n+\t\t\tnetif_receive_skb(skb);\n \t\t\thandled++;\n \t\t} while (0);\n \n",
    "prefixes": []
}