Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/813256/?format=api
{ "id": 813256, "url": "http://patchwork.ozlabs.org/api/1.2/patches/813256/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913093215.10043-2-kraxel@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170913093215.10043-2-kraxel@redhat.com>", "list_archive_url": null, "date": "2017-09-13T09:32:12", "name": "[PULL,1/4] xhci: Avoid DMA when ERSTBA is set to zero", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "920e8f2a66f19a5e54118dc467b94067a1e7a8bc", "submitter": { "id": 589, "url": "http://patchwork.ozlabs.org/api/1.2/people/589/?format=api", "name": "Gerd Hoffmann", "email": "kraxel@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913093215.10043-2-kraxel@redhat.com/mbox/", "series": [ { "id": 2851, "url": "http://patchwork.ozlabs.org/api/1.2/series/2851/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2851", "date": "2017-09-13T09:32:15", "name": "[PULL,1/4] xhci: Avoid DMA when ERSTBA is set to zero", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2851/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813256/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813256/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kraxel@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsc0J52LSz9sMN\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 19:33:04 +1000 (AEST)", "from localhost ([::1]:41183 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds42Y-00068x-PG\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 05:33:02 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:49256)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <kraxel@redhat.com>) id 1ds41v-00068F-6K\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 05:32:24 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <kraxel@redhat.com>) id 1ds41s-0004L4-6h\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 05:32:23 -0400", "from mx1.redhat.com ([209.132.183.28]:50740)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <kraxel@redhat.com>) id 1ds41r-0004Jz-VU\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 05:32:20 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1212A356CE;\n\tWed, 13 Sep 2017 09:32:19 +0000 (UTC)", "from sirius.home.kraxel.org (ovpn-117-51.ams2.redhat.com\n\t[10.36.117.51])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id BDDE561989;\n\tWed, 13 Sep 2017 09:32:16 +0000 (UTC)", "by sirius.home.kraxel.org (Postfix, from userid 1000)\n\tid 54BF13F105; Wed, 13 Sep 2017 11:32:15 +0200 (CEST)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 1212A356CE", "From": "Gerd Hoffmann <kraxel@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 13 Sep 2017 11:32:12 +0200", "Message-Id": "<20170913093215.10043-2-kraxel@redhat.com>", "In-Reply-To": "<20170913093215.10043-1-kraxel@redhat.com>", "References": "<20170913093215.10043-1-kraxel@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 13 Sep 2017 09:32:19 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PULL 1/4] xhci: Avoid DMA when ERSTBA is set to zero", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Alexey Kardashevskiy <aik@ozlabs.ru>, Gerd Hoffmann <kraxel@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Alexey Kardashevskiy <aik@ozlabs.ru>\n\nThe existing XHCI code reads the Event Ring Segment Table Base Address\nRegister (ERSTBA) every time when it is changed. However zero is its\ndefault state so one would think that zero there means it is not in use.\n\nThis adds a check for ERSTBA in addition to the existing check for\nthe Event Ring Segment Table Size Register (ERSTSZ).\n\nSigned-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>\nMessage-id: 20170911065606.40600-1-aik@ozlabs.ru\nSigned-off-by: Gerd Hoffmann <kraxel@redhat.com>\n---\n hw/usb/hcd-xhci.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c\nindex 204ea69d3f..d75c085d94 100644\n--- a/hw/usb/hcd-xhci.c\n+++ b/hw/usb/hcd-xhci.c\n@@ -811,8 +811,9 @@ static void xhci_er_reset(XHCIState *xhci, int v)\n {\n XHCIInterrupter *intr = &xhci->intr[v];\n XHCIEvRingSeg seg;\n+ dma_addr_t erstba = xhci_addr64(intr->erstba_low, intr->erstba_high);\n \n- if (intr->erstsz == 0) {\n+ if (intr->erstsz == 0 || erstba == 0) {\n /* disabled */\n intr->er_start = 0;\n intr->er_size = 0;\n@@ -824,7 +825,6 @@ static void xhci_er_reset(XHCIState *xhci, int v)\n xhci_die(xhci);\n return;\n }\n- dma_addr_t erstba = xhci_addr64(intr->erstba_low, intr->erstba_high);\n pci_dma_read(PCI_DEVICE(xhci), erstba, &seg, sizeof(seg));\n le32_to_cpus(&seg.addr_low);\n le32_to_cpus(&seg.addr_high);\n", "prefixes": [ "PULL", "1/4" ] }