Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/812258/?format=api
{ "id": 812258, "url": "http://patchwork.ozlabs.org/api/1.2/patches/812258/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/20170911085533.4340-1-aleksander@aleksander.es/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/1.2/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170911085533.4340-1-aleksander@aleksander.es>", "list_archive_url": null, "date": "2017-09-11T08:55:33", "name": "[v2] libmbim: fix build with musl libc", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a85f6041c3d6f960ef55e8e8abbc310919b41859", "submitter": { "id": 48681, "url": "http://patchwork.ozlabs.org/api/1.2/people/48681/?format=api", "name": "Aleksander Morgado", "email": "aleksander@aleksander.es" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/20170911085533.4340-1-aleksander@aleksander.es/mbox/", "series": [ { "id": 2460, "url": "http://patchwork.ozlabs.org/api/1.2/series/2460/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/list/?series=2460", "date": "2017-09-11T08:55:33", "name": "[v2] libmbim: fix build with musl libc", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/2460/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812258/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812258/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@busybox.net>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "buildroot@lists.busybox.net" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "buildroot@osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aleksander-es.20150623.gappssmtp.com\n\theader.i=@aleksander-es.20150623.gappssmtp.com\n\theader.b=\"sbiCfiTe\"; dkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrMGG4GH7z9s7g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 11 Sep 2017 18:55:49 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id ACA1287ED0;\n\tMon, 11 Sep 2017 08:55:44 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YsHyovkRxCSn; Mon, 11 Sep 2017 08:55:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id EFB2487EA7;\n\tMon, 11 Sep 2017 08:55:42 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id B9A111C2D90\n\tfor <buildroot@lists.busybox.net>;\n\tMon, 11 Sep 2017 08:55:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B2EE886723\n\tfor <buildroot@lists.busybox.net>;\n\tMon, 11 Sep 2017 08:55:40 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FVML3q6vR+UO for <buildroot@lists.busybox.net>;\n\tMon, 11 Sep 2017 08:55:39 +0000 (UTC)", "from mail-wr0-f194.google.com (mail-wr0-f194.google.com\n\t[209.85.128.194])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 4861C823E7\n\tfor <buildroot@buildroot.org>; Mon, 11 Sep 2017 08:55:38 +0000 (UTC)", "by mail-wr0-f194.google.com with SMTP id b9so4083349wra.0\n\tfor <buildroot@buildroot.org>; Mon, 11 Sep 2017 01:55:38 -0700 (PDT)", "from localhost.localdomain\n\t(116.red-83-40-186.dynamicip.rima-tde.net. [83.40.186.116])\n\tby smtp.gmail.com with ESMTPSA id\n\te14sm7331662wra.55.2017.09.11.01.55.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Sep 2017 01:55:36 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=aleksander-es.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=EYZk4Q2W47Bw1XR+JCdtIsKemHI+h9dfoelN/Fd3Nkc=;\n\tb=sbiCfiTez4lYtX98Fm0JqiLrtW3C+Umjy+xtWspmfUvbL7H6AWMLLbfjQD1N2dq1IR\n\tAxbk1A3A368dk3mYQi6SrqpU66VwmmQ9fx5nIj7qGHYGkmwPGsYRO9A/m0d8QGdACTc0\n\tfKQ7lv2+UDqUoakdzRBg0w4rWeJVy4fnRygVlPjrTHATIlsP5P0Tqyde2l19iBnNWoXH\n\t1L29Ap8qc28iJuIXCFVGGpUOsPyhSjSVsEQVINWGs501jZAku9XjKhMKQKlwOwwh0QTe\n\tybKMEamKk/FY82i0C/oM5h3Savk0+LKIQ0tklL1TmKRS0Wzr1AC4wHyhYih97IQzJKOj\n\tMdLw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=EYZk4Q2W47Bw1XR+JCdtIsKemHI+h9dfoelN/Fd3Nkc=;\n\tb=JsYtWuuKq0J9HaTiBqe23+jPli0LRdQHo8ZvcUqqAi8YnM/jWvLbM5HhPKcFLm+omp\n\tJaPkrAlt1ZRXLXsq+vvpnuMlcjQwvmxbDeo4XpmZlemZO74N2VBOBQpMTlymFJt/GJBf\n\tdiVhGgCa/+T95byQbdT0Yh2fCXVSHTFdc8IOemjg3PTzuSAdC+JZX1xJAOipPRoqJcn+\n\t/u9iS1aSPeP8OhBo8mrQGtWN7vwMQGgWSc6u/kzC3KOinOy1NB4G8KJ2sDePNNsbuf2s\n\tsNHbhbE2UjTABkudicnPgEcivxwkDMsINcDN4QI+LSu04UxAre5bCSt04uM822nOI+wj\n\tGIdQ==", "X-Gm-Message-State": "AHPjjUi7SIksGOlFGehi5NDlV1rnm8G96jtOKyseBRM7UlJ6KdIgWO3i\n\tkcXqzYWw54fVoaDqVxaQTQ==", "X-Google-Smtp-Source": "ADKCNb5nveu6Cftqz05XSy61/FwUiSpjiXVDzGFnRS4BLz4hCEvgVfS45nYkEvNzgHLYyx0hm1nblQ==", "X-Received": "by 10.223.132.67 with SMTP id 61mr7889747wrf.152.1505120137255; \n\tMon, 11 Sep 2017 01:55:37 -0700 (PDT)", "From": "Aleksander Morgado <aleksander@aleksander.es>", "To": "buildroot@buildroot.org", "Date": "Mon, 11 Sep 2017 10:55:33 +0200", "Message-Id": "<20170911085533.4340-1-aleksander@aleksander.es>", "X-Mailer": "git-send-email 2.13.1", "In-Reply-To": "<20170911075426.514-1-aleksander@aleksander.es>", "References": "<20170911075426.514-1-aleksander@aleksander.es>", "Cc": "Aleksander Morgado <aleksander@aleksander.es>", "Subject": "[Buildroot] [PATCH v2] libmbim: fix build with musl libc", "X-BeenThere": "buildroot@busybox.net", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.busybox.net>", "List-Unsubscribe": "<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>", "List-Archive": "<http://lists.busybox.net/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@busybox.net>", "List-Help": "<mailto:buildroot-request@busybox.net?subject=help>", "List-Subscribe": "<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "buildroot-bounces@busybox.net", "Sender": "\"buildroot\" <buildroot-bounces@busybox.net>" }, "content": "This is now failing because the libgudev dependency is optional and\nthe build will only use if it's found during the configure checks.\n\nImported the same patch that has been applied in the upstream libmbim\ngit repository:\n https://cgit.freedesktop.org/libmbim/libmbim/commit/?id=417b0b80023dc30d61c111ec0a54da2884d3a541\n\nSigned-off-by: Aleksander Morgado <aleksander@aleksander.es>\n---\n\nv2 with Signed-off-by in the patch itself.\n\n---\n ...-prefer-realpath-to-canonicalize_file_nam.patch | 37 ++++++++++++++++++++++\n 1 file changed, 37 insertions(+)\n create mode 100644 package/libmbim/0001-mbim-device-prefer-realpath-to-canonicalize_file_nam.patch\n\n--\n2.13.1", "diff": "diff --git a/package/libmbim/0001-mbim-device-prefer-realpath-to-canonicalize_file_nam.patch b/package/libmbim/0001-mbim-device-prefer-realpath-to-canonicalize_file_nam.patch\nnew file mode 100644\nindex 000000000..ff178dd61\n--- /dev/null\n+++ b/package/libmbim/0001-mbim-device-prefer-realpath-to-canonicalize_file_nam.patch\n@@ -0,0 +1,37 @@\n+From 6b043b9b676e88a80e3d4013863c5e970fdde1df Mon Sep 17 00:00:00 2001\n+From: Aleksander Morgado <aleksander@aleksander.es>\n+Date: Mon, 11 Sep 2017 09:31:03 +0200\n+Subject: [PATCH] mbim-device: prefer realpath() to canonicalize_file_name()\n+\n+Usually the canonicalize_file_name() GNU extension is preferred to the\n+POSIX realpath(), as it covers some of the limitations the latter has.\n+But this extension isn't available in lots of platforms or in other\n+c library implementations (e.g. musl), so just default to the POSIX\n+method to improve portability.\n+\n+Note that the check for canonicalize_file_name() availability during\n+configure isn't as trivial as adding a new AC_CHECK_FUNCS(), and\n+importing a gnulib module seems overkill just for this one liner.\n+\n+(cherry picked from commit 417b0b80023dc30d61c111ec0a54da2884d3a541)\n+Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>\n+---\n+ src/libmbim-glib/mbim-device.c | 2 +-\n+ 1 file changed, 1 insertion(+), 1 deletion(-)\n+\n+diff --git a/src/libmbim-glib/mbim-device.c b/src/libmbim-glib/mbim-device.c\n+index e1f32a6..20e64af 100644\n+--- a/src/libmbim-glib/mbim-device.c\n++++ b/src/libmbim-glib/mbim-device.c\n+@@ -867,7 +867,7 @@ get_descriptors_filepath (MbimDevice *self)\n+ * /sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.5/2-1.5:2.0\n+ */\n+ tmp = g_strdup_printf (\"/sys/class/%s/%s/device\", subsystems[i], device_basename);\n+- path = canonicalize_file_name (tmp);\n++ path = realpath (tmp, NULL);\n+ g_free (tmp);\n+\n+ if (g_file_test (path, G_FILE_TEST_EXISTS)) {\n+--\n+2.13.1\n+\n", "prefixes": [ "v2" ] }