Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/812223/?format=api
{ "id": 812223, "url": "http://patchwork.ozlabs.org/api/1.2/patches/812223/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911044157.15403-2-haozhong.zhang@intel.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170911044157.15403-2-haozhong.zhang@intel.com>", "list_archive_url": null, "date": "2017-09-11T04:41:48", "name": "[RFC,QEMU,v3,01/10] nvdimm: do not intiailize nvdimm->label_data if label size is zero", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d692012b4f538324c2ac845b46af62421f008179", "submitter": { "id": 67323, "url": "http://patchwork.ozlabs.org/api/1.2/people/67323/?format=api", "name": "Haozhong Zhang", "email": "haozhong.zhang@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911044157.15403-2-haozhong.zhang@intel.com/mbox/", "series": [ { "id": 2435, "url": "http://patchwork.ozlabs.org/api/1.2/series/2435/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2435", "date": "2017-09-11T04:41:48", "name": "[RFC,QEMU,v3,01/10] nvdimm: do not intiailize nvdimm->label_data if label size is zero", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/2435/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812223/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812223/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrFfp5gpkz9sBd\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 11 Sep 2017 14:43:09 +1000 (AEST)", "from localhost ([::1]:55351 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1drGYs-0000sS-On\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 00:43:06 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:56196)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <haozhong.zhang@intel.com>) id 1drGY5-0000ry-1o\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 00:42:18 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <haozhong.zhang@intel.com>) id 1drGY1-0004VC-3k\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 00:42:17 -0400", "from mga04.intel.com ([192.55.52.120]:52456)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <haozhong.zhang@intel.com>)\n\tid 1drGY0-0004Si-QQ\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 00:42:13 -0400", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t10 Sep 2017 21:42:07 -0700", "from hz-desktop.sh.intel.com (HELO localhost) ([10.239.159.142])\n\tby fmsmga002.fm.intel.com with ESMTP; 10 Sep 2017 21:42:06 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.42,376,1500966000\"; d=\"scan'208\";\n\ta=\"1217079070\"", "From": "Haozhong Zhang <haozhong.zhang@intel.com>", "To": "qemu-devel@nongnu.org,\n\txen-devel@lists.xen.org", "Date": "Mon, 11 Sep 2017 12:41:48 +0800", "Message-Id": "<20170911044157.15403-2-haozhong.zhang@intel.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170911044157.15403-1-haozhong.zhang@intel.com>", "References": "<20170911044157.15403-1-haozhong.zhang@intel.com>", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "192.55.52.120", "Subject": "[Qemu-devel] [RFC QEMU PATCH v3 01/10] nvdimm: do not intiailize\n\tnvdimm->label_data if label size is zero", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Haozhong Zhang <haozhong.zhang@intel.com>,\n\tXiao Guangrong <xiaoguangrong.eric@gmail.com>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>,\n\tKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>,\n\tIgor Mammedov <imammedo@redhat.com>,\n\tChao Peng <chao.p.peng@linux.intel.com>,\n\tDan Williams <dan.j.williams@intel.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The memory region of vNVDIMM on Xen is a RAM memory region, so\nmemory_region_get_ram_ptr() cannot be used in nvdimm_realize() to get\na pointer to the label data area in that region. To be worse, it may\nabort QEMU. As Xen currently does not support labels (i.e. label size\nis 0) and every access in QEMU to labels is led by a label size check,\nlet's not intiailize nvdimm->label_data if the label size is 0.\n\nSigned-off-by: Haozhong Zhang <haozhong.zhang@intel.com>\n---\nCc: Xiao Guangrong <xiaoguangrong.eric@gmail.com>\nCc: \"Michael S. Tsirkin\" <mst@redhat.com>\nCc: Igor Mammedov <imammedo@redhat.com>\n---\n hw/mem/nvdimm.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c\nindex 952fce5ec8..3e58538b99 100644\n--- a/hw/mem/nvdimm.c\n+++ b/hw/mem/nvdimm.c\n@@ -87,7 +87,15 @@ static void nvdimm_realize(PCDIMMDevice *dimm, Error **errp)\n align = memory_region_get_alignment(mr);\n \n pmem_size = size - nvdimm->label_size;\n- nvdimm->label_data = memory_region_get_ram_ptr(mr) + pmem_size;\n+ /*\n+ * The memory region of vNVDIMM on Xen is not a RAM memory region,\n+ * so memory_region_get_ram_ptr() below will abort QEMU. In\n+ * addition that Xen currently does not support vNVDIMM labels\n+ * (i.e. label_size is zero here), let's not initialize of the\n+ * pointer to label data if the label size is zero.\n+ */\n+ if (nvdimm->label_size)\n+ nvdimm->label_data = memory_region_get_ram_ptr(mr) + pmem_size;\n pmem_size = QEMU_ALIGN_DOWN(pmem_size, align);\n \n if (size <= nvdimm->label_size || !pmem_size) {\n", "prefixes": [ "RFC", "QEMU", "v3", "01/10" ] }