Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/811848/?format=api
{ "id": 811848, "url": "http://patchwork.ozlabs.org/api/1.2/patches/811848/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/1504908038-26285-1-git-send-email-khoroshilov@ispras.ru/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/1.2/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504908038-26285-1-git-send-email-khoroshilov@ispras.ru>", "list_archive_url": null, "date": "2017-09-08T22:00:38", "name": "mtd: oxnas_nand: Fix error handling in oxnas_nand_probe()", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "310ef4d3542eaa63600785c8e42381168524168a", "submitter": { "id": 8131, "url": "http://patchwork.ozlabs.org/api/1.2/people/8131/?format=api", "name": "Alexey Khoroshilov", "email": "khoroshilov@ispras.ru" }, "delegate": { "id": 58324, "url": "http://patchwork.ozlabs.org/api/1.2/users/58324/?format=api", "username": "bbrezillon", "first_name": "Boris", "last_name": "Brezillon", "email": "boris.brezillon@free-electrons.com" }, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/1504908038-26285-1-git-send-email-khoroshilov@ispras.ru/mbox/", "series": [ { "id": 2297, "url": "http://patchwork.ozlabs.org/api/1.2/series/2297/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=2297", "date": "2017-09-08T22:00:38", "name": "mtd: oxnas_nand: Fix error handling in oxnas_nand_probe()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2297/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811848/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811848/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"jn+lSKKV\"; \n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xprrl60Cwz9s7h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 9 Sep 2017 08:01:59 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dqRLT-0004AW-TB; Fri, 08 Sep 2017 22:01:51 +0000", "from mail.ispras.ru ([83.149.199.45])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dqRKw-0003qF-An; Fri, 08 Sep 2017 22:01:20 +0000", "from localhost.localdomain (unknown [85.140.191.248])\n\tby mail.ispras.ru (Postfix) with ESMTPSA id 6A32054006E;\n\tSat, 9 Sep 2017 01:00:46 +0300 (MSK)" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:\n\tSubject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:\n\tReferences:List-Owner; bh=1SUmVCYnpvdH+w/SXVh4NWPCEmE4qml23UqFRRu0+Bw=;\n\tb=jn+\n\tlSKKVRhJRLLEqI+4KA71zHX91bXyFpjxTfF8PcC3JF/rMPKMs9xckIw4IONGrjjhyzxbzSFDXtd5N\n\tCJH3A8lM+v2/0GBerCjc5Wbm2iLk1HCfhn3mCf3lGo7CGxXbEw/RnnVnSijeddStsswSEXOxsailK\n\t5DpaLlwWOs/IsmjLdHWEa1cAwsY90HugJPXwIBtUhau2YrEqE2HXVWmwvcnpy+R2BjK3bSjKa213f\n\t9D32B1ktbJvy0AkSa+8nDG4TeLJognquDJ9XHpB+q9/5UonmyL/Q5fI2USB/vy1CRddTh6fRqcwI+\n\ttzzpKmQ3ObUzbigWxgmWizGzmj+MkMA==;", "From": "Alexey Khoroshilov <khoroshilov@ispras.ru>", "To": "Boris Brezillon <boris.brezillon@free-electrons.com>,\n\tBrian Norris <computersforpeace@gmail.com>,\n\tNeil Armstrong <narmstrong@baylibre.com>", "Subject": "[PATCH] mtd: oxnas_nand: Fix error handling in oxnas_nand_probe()", "Date": "Sat, 9 Sep 2017 01:00:38 +0300", "Message-Id": "<1504908038-26285-1-git-send-email-khoroshilov@ispras.ru>", "X-Mailer": "git-send-email 2.7.4", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20170908_150118_573723_7223E6F3 ", "X-CRM114-Status": "UNSURE ( 9.33 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-1.9 (-)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Cc": "ldv-project@linuxtesting.org, linux-oxnas@lists.tuxfamily.org,\n\tlinux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tAlexey Khoroshilov <khoroshilov@ispras.ru>,\n\tlinux-arm-kernel@lists.infradead.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "oxnas_nand_probe() does not disable clock on error paths.\nThe patch adds disabling using devm interface.\n\nFound by Linux Driver Verification project (linuxtesting.org).\n\nSigned-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>\n---\n drivers/mtd/nand/oxnas_nand.c | 22 +++++++++++++++-------\n 1 file changed, 15 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/mtd/nand/oxnas_nand.c b/drivers/mtd/nand/oxnas_nand.c\nindex 1b207aac840c..8abc69a285dd 100644\n--- a/drivers/mtd/nand/oxnas_nand.c\n+++ b/drivers/mtd/nand/oxnas_nand.c\n@@ -103,16 +103,26 @@ static int oxnas_nand_probe(struct platform_device *pdev)\n \tif (IS_ERR(oxnas->io_base))\n \t\treturn PTR_ERR(oxnas->io_base);\n \n-\toxnas->clk = devm_clk_get(&pdev->dev, NULL);\n-\tif (IS_ERR(oxnas->clk))\n-\t\toxnas->clk = NULL;\n-\n \t/* Only a single chip node is supported */\n \tcount = of_get_child_count(np);\n \tif (count > 1)\n \t\treturn -EINVAL;\n \n-\tclk_prepare_enable(oxnas->clk);\n+\toxnas->clk = devm_clk_get(&pdev->dev, NULL);\n+\tif (IS_ERR(oxnas->clk)) {\n+\t\toxnas->clk = NULL;\n+\t} else {\n+\t\terr = clk_prepare_enable(oxnas->clk);\n+\t\tif (err)\n+\t\t\treturn err;\n+\n+\t\terr = devm_add_action_or_reset(&pdev->dev,\n+\t\t\t\t(void(*)(void *))clk_disable_unprepare,\n+\t\t\t\toxnas->clk);\n+\t\tif (err)\n+\t\t\treturn err;\n+\t}\n+\n \tdevice_reset_optional(&pdev->dev);\n \n \tfor_each_child_of_node(np, nand_np) {\n@@ -167,8 +177,6 @@ static int oxnas_nand_remove(struct platform_device *pdev)\n \tif (oxnas->chips[0])\n \t\tnand_release(nand_to_mtd(oxnas->chips[0]));\n \n-\tclk_disable_unprepare(oxnas->clk);\n-\n \treturn 0;\n }\n \n", "prefixes": [] }