Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/811748/?format=api
{ "id": 811748, "url": "http://patchwork.ozlabs.org/api/1.2/patches/811748/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/1504892748-1605-2-git-send-email-pablo@netfilter.org/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/1.2/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504892748-1605-2-git-send-email-pablo@netfilter.org>", "list_archive_url": null, "date": "2017-09-08T17:45:40", "name": "[1/9] netfilter: ipvs: fix the issue that sctp_conn_schedule drops non-INIT packet", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3d794b9eec08418a2a1e093675569757b30d0674", "submitter": { "id": 1315, "url": "http://patchwork.ozlabs.org/api/1.2/people/1315/?format=api", "name": "Pablo Neira Ayuso", "email": "pablo@netfilter.org" }, "delegate": { "id": 6139, "url": "http://patchwork.ozlabs.org/api/1.2/users/6139/?format=api", "username": "pablo", "first_name": "Pablo", "last_name": "Neira", "email": "pablo@netfilter.org" }, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/1504892748-1605-2-git-send-email-pablo@netfilter.org/mbox/", "series": [ { "id": 2261, "url": "http://patchwork.ozlabs.org/api/1.2/series/2261/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=2261", "date": "2017-09-08T17:45:46", "name": "[1/9] netfilter: ipvs: fix the issue that sctp_conn_schedule drops non-INIT packet", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2261/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811748/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811748/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netfilter-devel-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xplBw6fn4z9s8J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 9 Sep 2017 03:47:20 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932329AbdIHRrP (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tFri, 8 Sep 2017 13:47:15 -0400", "from mail.us.es ([193.147.175.20]:54468 \"EHLO mail.us.es\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1756703AbdIHRp7 (ORCPT <rfc822; netfilter-devel@vger.kernel.org>);\n\tFri, 8 Sep 2017 13:45:59 -0400", "from antivirus1-rhel7.int (unknown [192.168.2.11])\n\tby mail.us.es (Postfix) with ESMTP id A0C5C8D050D\n\tfor <netfilter-devel@vger.kernel.org>;\n\tFri, 8 Sep 2017 19:45:28 +0200 (CEST)", "from antivirus1-rhel7.int (localhost [127.0.0.1])\n\tby antivirus1-rhel7.int (Postfix) with ESMTP id 92528B503F\n\tfor <netfilter-devel@vger.kernel.org>;\n\tFri, 8 Sep 2017 19:45:28 +0200 (CEST)", "by antivirus1-rhel7.int (Postfix, from userid 99)\n\tid 87E12B5024; Fri, 8 Sep 2017 19:45:28 +0200 (CEST)", "from antivirus1-rhel7.int (localhost [127.0.0.1])\n\tby antivirus1-rhel7.int (Postfix) with ESMTP id 6614EDA56C;\n\tFri, 8 Sep 2017 19:45:26 +0200 (CEST)", "from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int\n\t(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); \n\tFri, 08 Sep 2017 19:45:26 +0200 (CEST)", "from salvia.here (129.166.216.87.static.jazztel.es\n\t[87.216.166.129]) (Authenticated sender: pneira@us.es)\n\tby entrada.int (Postfix) with ESMTPA id 1805544581E0;\n\tFri, 8 Sep 2017 19:45:26 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.1 (2015-04-28) on\n\tantivirus1-rhel7.int", "X-Spam-Level": "", "X-Spam-Status": "No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50,\n\tSMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1", "X-Virus-Status": "clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int)", "X-SMTPAUTHUS": "auth mail.us.es", "From": "Pablo Neira Ayuso <pablo@netfilter.org>", "To": "netfilter-devel@vger.kernel.org", "Cc": "davem@davemloft.net, netdev@vger.kernel.org", "Subject": "[PATCH 1/9] netfilter: ipvs: fix the issue that sctp_conn_schedule\n\tdrops non-INIT packet", "Date": "Fri, 8 Sep 2017 19:45:40 +0200", "Message-Id": "<1504892748-1605-2-git-send-email-pablo@netfilter.org>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1504892748-1605-1-git-send-email-pablo@netfilter.org>", "References": "<1504892748-1605-1-git-send-email-pablo@netfilter.org>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Sender": "netfilter-devel-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netfilter-devel.vger.kernel.org>", "X-Mailing-List": "netfilter-devel@vger.kernel.org" }, "content": "From: Xin Long <lucien.xin@gmail.com>\n\nCommit 5e26b1b3abce (\"ipvs: support scheduling inverse and icmp SCTP\npackets\") changed to check packet type early. It introduced a side\neffect: if it's not a INIT packet, ports will be set as NULL, and\nthe packet will be dropped later.\n\nIt caused that sctp couldn't create connection when ipvs module is\nloaded and any scheduler is registered on server.\n\nLi Shuang reproduced it by running the cmds on sctp server:\n # ipvsadm -A -t 1.1.1.1:80 -s rr\n # ipvsadm -D -t 1.1.1.1:80\nthen the server could't work any more.\n\nThis patch is to return 1 when it's not an INIT packet. It means ipvs\nwill accept it without creating a conn for it, just like what it does\nfor tcp.\n\nFixes: 5e26b1b3abce (\"ipvs: support scheduling inverse and icmp SCTP packets\")\nReported-by: Li Shuang <shuali@redhat.com>\nSigned-off-by: Xin Long <lucien.xin@gmail.com>\nSigned-off-by: Simon Horman <horms@verge.net.au>\nSigned-off-by: Pablo Neira Ayuso <pablo@netfilter.org>\n---\n net/netfilter/ipvs/ip_vs_proto_sctp.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/net/netfilter/ipvs/ip_vs_proto_sctp.c b/net/netfilter/ipvs/ip_vs_proto_sctp.c\nindex e1efa446b305..81f08198b125 100644\n--- a/net/netfilter/ipvs/ip_vs_proto_sctp.c\n+++ b/net/netfilter/ipvs/ip_vs_proto_sctp.c\n@@ -24,9 +24,12 @@ sctp_conn_schedule(struct netns_ipvs *ipvs, int af, struct sk_buff *skb,\n \t\tif (sh) {\n \t\t\tsch = skb_header_pointer(skb, iph->len + sizeof(_sctph),\n \t\t\t\t\t\t sizeof(_schunkh), &_schunkh);\n-\t\t\tif (sch && (sch->type == SCTP_CID_INIT ||\n-\t\t\t\t sysctl_sloppy_sctp(ipvs)))\n+\t\t\tif (sch) {\n+\t\t\t\tif (!(sysctl_sloppy_sctp(ipvs) ||\n+\t\t\t\t sch->type == SCTP_CID_INIT))\n+\t\t\t\t\treturn 1;\n \t\t\t\tports = &sh->source;\n+\t\t\t}\n \t\t}\n \t} else {\n \t\tports = skb_header_pointer(\n", "prefixes": [ "1/9" ] }