Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/811638/?format=api
{ "id": 811638, "url": "http://patchwork.ozlabs.org/api/1.2/patches/811638/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/202d7b2e172746c0bed742255bc1583beca45fce.1504880548.git.marcelo.leitner@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<202d7b2e172746c0bed742255bc1583beca45fce.1504880548.git.marcelo.leitner@gmail.com>", "list_archive_url": null, "date": "2017-09-08T14:35:21", "name": "[net] sctp: fix missing wake ups in some situations", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b5420c820fc1897775674ca4d057f38d7407d59e", "submitter": { "id": 65333, "url": "http://patchwork.ozlabs.org/api/1.2/people/65333/?format=api", "name": "Marcelo Ricardo Leitner", "email": "marcelo.leitner@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/202d7b2e172746c0bed742255bc1583beca45fce.1504880548.git.marcelo.leitner@gmail.com/mbox/", "series": [ { "id": 2229, "url": "http://patchwork.ozlabs.org/api/1.2/series/2229/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=2229", "date": "2017-09-08T14:35:21", "name": "[net] sctp: fix missing wake ups in some situations", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2229/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811638/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811638/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"s261Up/S\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpfy44QgGz9s7G\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Sep 2017 00:35:56 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756171AbdIHOfn (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 8 Sep 2017 10:35:43 -0400", "from mail-qk0-f169.google.com ([209.85.220.169]:34586 \"EHLO\n\tmail-qk0-f169.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754978AbdIHOfl (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 8 Sep 2017 10:35:41 -0400", "by mail-qk0-f169.google.com with SMTP id b23so6747538qkg.1;\n\tFri, 08 Sep 2017 07:35:40 -0700 (PDT)", "from localhost.localdomain.com\n\t([2001:1284:f016:8579:5ee0:c5ff:fe34:bf34])\n\tby smtp.gmail.com with ESMTPSA id\n\t20sm1390722qtr.1.2017.09.08.07.35.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 08 Sep 2017 07:35:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=l4DF1g2duA/qzOt4AAWpmtCeH6YjuAdZddMGm4mIqI0=;\n\tb=s261Up/S6ripfDu3EwMTgol+zAOaCnGXONilZeYWjVnUyqu7Iv78RYlSvS749agB9/\n\tiTbBOjaW92xzJibamI73Ox651lXBpwnOFx5QJMfZI9lobI4qlOzTgjzL9p2qA+qxQjLc\n\tSyN5ORn3Wze+iFNOUq3SAoTJQqYSwiSNOvFpK3d3HX+rYmGf9Wh/LxCfZ53xoFOKXHCo\n\t73hwB0Lya7klPuud/kyXWtmz8oMuWUKTUn/ZVGFwq/wRs9zwEWstUPQ0MLsF7U5xq1Tp\n\t3edK6wDKxnBY/6lZNL3vx5fgElqWkTtKyjpwRIJlTHTLS/N09BmR/D3TsC1NVfb66GPs\n\toMJQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=l4DF1g2duA/qzOt4AAWpmtCeH6YjuAdZddMGm4mIqI0=;\n\tb=pv0ZlInYl7Toh71eFyNDBVDha8B7NWLaCAgqGj44E+ACeNA8+fIXyXeiEcf6fmVddq\n\tbKVtPreqTp+lEhWcxcGz7611at9bVL5tb/6NahAGgefVIb0AkTYAnkMwbKkbHHPGjJ8B\n\tTn5LmfQ9CyRZFPRt80yKDNve+WwPOIQfGFbM2pRz1eMXFv5DDxsA3Wzd5zz0hso4lObr\n\tkSbD41bRm3ck4ICfTuzioEXlY8blov+9lEceU+3bzUwZC1JCU0bQ8HwEZHgnPnV804Tz\n\t+N/Q17ojM97eZOTFBuY+DGYGCmNEvm2OjwTWJsclmB04fhBwyIwtjp1n2DpNKWrAZ3A8\n\t3sTQ==", "X-Gm-Message-State": "AHPjjUjHgnxMjjagu4xf4OZtvH10AuPXNTND7zhWvnWsnd4ay3oau9YF\n\ti7glnXdhw7A6J/1O", "X-Google-Smtp-Source": "AOwi7QAxOGXTtXUJSvjD8ZNlwJrnF/H8bVTMIPZBk4b7mC6Tf6OQ8KFm1FtNXxM2cnXmwMHD1CF1dg==", "X-Received": "by 10.55.16.4 with SMTP id a4mr4216445qkh.115.1504881340063;\n\tFri, 08 Sep 2017 07:35:40 -0700 (PDT)", "From": "Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>", "To": "netdev@vger.kernel.org", "Cc": "linux-sctp@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,\n\tVlad Yasevich <vyasevich@gmail.com>, Harald Welte <laforge@gnumonks.org>", "Subject": "[PATCH net] sctp: fix missing wake ups in some situations", "Date": "Fri, 8 Sep 2017 11:35:21 -0300", "Message-Id": "<202d7b2e172746c0bed742255bc1583beca45fce.1504880548.git.marcelo.leitner@gmail.com>", "X-Mailer": "git-send-email 2.13.5", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Commit fb586f25300f (\"sctp: delay calls to sk_data_ready() as much as\npossible\") minimized the number of wake ups that are triggered in case\nthe association receives a packet with multiple data chunks on it and/or\nwhen io_events are enabled and then commit 0970f5b36659 (\"sctp: signal\nsk_data_ready earlier on data chunks reception\") moved the wake up to as\nsoon as possible. It thus relies on the state machine running later to\nclean the flag that the event was already generated.\n\nThe issue is that there are 2 call paths that calls\nsctp_ulpq_tail_event() outside of the state machine, causing the flag to\nlinger and possibly omitting a needed wake up in the sequence.\n\nOne of the call paths is when enabling SCTP_SENDER_DRY_EVENTS via\nsetsockopt(SCTP_EVENTS), as noticed by Harald Welte. The other is when\npartial reliability triggers removal of chunks from the send queue when\nthe application calls sendmsg().\n\nThis commit fixes it by not setting the flag in case the socket is not\nowned by the user, as it won't be cleaned later. This works for\nuser-initiated calls and also for rx path processing.\n\nFixes: fb586f25300f (\"sctp: delay calls to sk_data_ready() as much as possible\")\nReported-by: Harald Welte <laforge@gnumonks.org>\nSigned-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>\n---\n\nHi. Please consider this one for -stable. Thanks\n\n net/sctp/ulpqueue.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/net/sctp/ulpqueue.c b/net/sctp/ulpqueue.c\nindex 0225d62a869f8deff10565c4625df0a10464ce87..a71be33f3afeb0aaaef174ee082c4c547aab1e2d 100644\n--- a/net/sctp/ulpqueue.c\n+++ b/net/sctp/ulpqueue.c\n@@ -265,7 +265,8 @@ int sctp_ulpq_tail_event(struct sctp_ulpq *ulpq, struct sctp_ulpevent *event)\n \t\tsctp_ulpq_clear_pd(ulpq);\n \n \tif (queue == &sk->sk_receive_queue && !sp->data_ready_signalled) {\n-\t\tsp->data_ready_signalled = 1;\n+\t\tif (!sock_owned_by_user(sk))\n+\t\t\tsp->data_ready_signalled = 1;\n \t\tsk->sk_data_ready(sk);\n \t}\n \treturn 1;\n", "prefixes": [ "net" ] }