Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/811627/?format=api
{ "id": 811627, "url": "http://patchwork.ozlabs.org/api/1.2/patches/811627/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1504880304-12069-8-git-send-email-mst@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504880304-12069-8-git-send-email-mst@redhat.com>", "list_archive_url": null, "date": "2017-09-08T14:19:13", "name": "[PULL,07/17] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5531a7bb4db17f7e94860155cb5cff7f47d49136", "submitter": { "id": 2235, "url": "http://patchwork.ozlabs.org/api/1.2/people/2235/?format=api", "name": "Michael S. Tsirkin", "email": "mst@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1504880304-12069-8-git-send-email-mst@redhat.com/mbox/", "series": [ { "id": 2227, "url": "http://patchwork.ozlabs.org/api/1.2/series/2227/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2227", "date": "2017-09-08T14:18:52", "name": "[PULL,01/17] vhost: Release memory references on cleanup", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2227/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811627/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811627/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mst@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpfj60Bhpz9s7G\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 9 Sep 2017 00:24:42 +1000 (AEST)", "from localhost ([::1]:45691 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dqKD2-0002ex-2w\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 10:24:40 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:49080)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mst@redhat.com>) id 1dqK7u-0006fP-DS\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 10:19:28 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mst@redhat.com>) id 1dqK7q-0004xx-EF\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 10:19:22 -0400", "from mx1.redhat.com ([209.132.183.28]:41712)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mst@redhat.com>) id 1dqK7q-0004xD-5v\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 10:19:18 -0400", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 470354E049;\n\tFri, 8 Sep 2017 14:19:17 +0000 (UTC)", "from redhat.com (ovpn-120-144.rdu2.redhat.com [10.10.120.144])\n\tby smtp.corp.redhat.com (Postfix) with SMTP id 0D3D9600C0;\n\tFri, 8 Sep 2017 14:19:13 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 470354E049", "Date": "Fri, 8 Sep 2017 17:19:13 +0300", "From": "\"Michael S. Tsirkin\" <mst@redhat.com>", "To": "qemu-devel@nongnu.org", "Message-ID": "<1504880304-12069-8-git-send-email-mst@redhat.com>", "References": "<1504880304-12069-1-git-send-email-mst@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<1504880304-12069-1-git-send-email-mst@redhat.com>", "X-Mutt-Fcc": "=sent", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tFri, 08 Sep 2017 14:19:17 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PULL 07/17] hw/pci: introduce bridge-only\n\tvendor-specific capability to provide some hints to firmware", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Marcel Apfelbaum <marcel@redhat.com>,\n\tPeter Maydell <peter.maydell@linaro.org>,\n\tAleksandr Bezzubikov <zuban32s@gmail.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Aleksandr Bezzubikov <zuban32s@gmail.com>\n\nOn PCI init PCI bridges may need some extra info about bus number,\nIO, memory and prefetchable memory to reserve. QEMU can provide this\nwith a special vendor-specific PCI capability.\n\nSigned-off-by: Aleksandr Bezzubikov <zuban32s@gmail.com>\nReviewed-by: Marcel Apfelbaum <marcel@redhat.com>\nTested-by: Marcel Apfelbaum <marcel@redhat.com>\nReviewed-by: Michael S. Tsirkin <mst@redhat.com>\nSigned-off-by: Michael S. Tsirkin <mst@redhat.com>\n---\n include/hw/pci/pci_bridge.h | 25 ++++++++++++++++++++++++\n hw/pci/pci_bridge.c | 46 +++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 71 insertions(+)", "diff": "diff --git a/include/hw/pci/pci_bridge.h b/include/hw/pci/pci_bridge.h\nindex ff7cbaa..1acadc2 100644\n--- a/include/hw/pci/pci_bridge.h\n+++ b/include/hw/pci/pci_bridge.h\n@@ -67,4 +67,29 @@ void pci_bridge_map_irq(PCIBridge *br, const char* bus_name,\n #define PCI_BRIDGE_CTL_DISCARD_STATUS\t0x400\t/* Discard timer status */\n #define PCI_BRIDGE_CTL_DISCARD_SERR\t0x800\t/* Discard timer SERR# enable */\n \n+typedef struct PCIBridgeQemuCap {\n+ uint8_t id; /* Standard PCI capability header field */\n+ uint8_t next; /* Standard PCI capability header field */\n+ uint8_t len; /* Standard PCI vendor-specific capability header field */\n+ uint8_t type; /* Red Hat vendor-specific capability type.\n+ Types are defined with REDHAT_PCI_CAP_ prefix */\n+\n+ uint32_t bus_res; /* Minimum number of buses to reserve */\n+ uint64_t io; /* IO space to reserve */\n+ uint32_t mem; /* Non-prefetchable memory to reserve */\n+ /* At most one of the following two fields may be set to a value\n+ * different from -1 */\n+ uint32_t mem_pref_32; /* Prefetchable memory to reserve (32-bit MMIO) */\n+ uint64_t mem_pref_64; /* Prefetchable memory to reserve (64-bit MMIO) */\n+} PCIBridgeQemuCap;\n+\n+#define REDHAT_PCI_CAP_RESOURCE_RESERVE 1\n+\n+int pci_bridge_qemu_reserve_cap_init(PCIDevice *dev, int cap_offset,\n+ uint32_t bus_reserve, uint64_t io_reserve,\n+ uint32_t mem_non_pref_reserve,\n+ uint32_t mem_pref_32_reserve,\n+ uint64_t mem_pref_64_reserve,\n+ Error **errp);\n+\n #endif /* QEMU_PCI_BRIDGE_H */\ndiff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c\nindex 720119b..17feae5 100644\n--- a/hw/pci/pci_bridge.c\n+++ b/hw/pci/pci_bridge.c\n@@ -408,6 +408,52 @@ void pci_bridge_map_irq(PCIBridge *br, const char* bus_name,\n br->bus_name = bus_name;\n }\n \n+\n+int pci_bridge_qemu_reserve_cap_init(PCIDevice *dev, int cap_offset,\n+ uint32_t bus_reserve, uint64_t io_reserve,\n+ uint32_t mem_non_pref_reserve,\n+ uint32_t mem_pref_32_reserve,\n+ uint64_t mem_pref_64_reserve,\n+ Error **errp)\n+{\n+ if (mem_pref_32_reserve != (uint32_t)-1 &&\n+ mem_pref_64_reserve != (uint64_t)-1) {\n+ error_setg(errp,\n+ \"PCI resource reserve cap: PREF32 and PREF64 conflict\");\n+ return -EINVAL;\n+ }\n+\n+ if (bus_reserve == (uint32_t)-1 &&\n+ io_reserve == (uint64_t)-1 &&\n+ mem_non_pref_reserve == (uint32_t)-1 &&\n+ mem_pref_32_reserve == (uint32_t)-1 &&\n+ mem_pref_64_reserve == (uint64_t)-1) {\n+ return 0;\n+ }\n+\n+ size_t cap_len = sizeof(PCIBridgeQemuCap);\n+ PCIBridgeQemuCap cap = {\n+ .len = cap_len,\n+ .type = REDHAT_PCI_CAP_RESOURCE_RESERVE,\n+ .bus_res = bus_reserve,\n+ .io = io_reserve,\n+ .mem = mem_non_pref_reserve,\n+ .mem_pref_32 = mem_pref_32_reserve,\n+ .mem_pref_64 = mem_pref_64_reserve\n+ };\n+\n+ int offset = pci_add_capability(dev, PCI_CAP_ID_VNDR,\n+ cap_offset, cap_len, errp);\n+ if (offset < 0) {\n+ return offset;\n+ }\n+\n+ memcpy(dev->config + offset + PCI_CAP_FLAGS,\n+ (char *)&cap + PCI_CAP_FLAGS,\n+ cap_len - PCI_CAP_FLAGS);\n+ return 0;\n+}\n+\n static const TypeInfo pci_bridge_type_info = {\n .name = TYPE_PCI_BRIDGE,\n .parent = TYPE_PCI_DEVICE,\n", "prefixes": [ "PULL", "07/17" ] }