Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/811491/?format=api
{ "id": 811491, "url": "http://patchwork.ozlabs.org/api/1.2/patches/811491/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170908103137.zck6bw66sge4fhua@mwanda/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170908103137.zck6bw66sge4fhua@mwanda>", "list_archive_url": null, "date": "2017-09-08T10:31:37", "name": "[net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": true, "hash": "51381adc0207b5d29d834f2bee380c8bff10921d", "submitter": { "id": 9327, "url": "http://patchwork.ozlabs.org/api/1.2/people/9327/?format=api", "name": "Dan Carpenter", "email": "dan.carpenter@oracle.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170908103137.zck6bw66sge4fhua@mwanda/mbox/", "series": [ { "id": 2178, "url": "http://patchwork.ozlabs.org/api/1.2/series/2178/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=2178", "date": "2017-09-08T10:31:37", "name": "[net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2178/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811491/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811491/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpYY11MFGz9s7h\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 8 Sep 2017 20:32:21 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753715AbdIHKcF (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 8 Sep 2017 06:32:05 -0400", "from aserp1040.oracle.com ([141.146.126.69]:29283 \"EHLO\n\taserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752387AbdIHKcE (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 8 Sep 2017 06:32:04 -0400", "from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v88AVtAK007421\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Fri, 8 Sep 2017 10:31:56 GMT", "from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])\n\tby userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v88AVt04022603\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Fri, 8 Sep 2017 10:31:55 GMT", "from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16])\n\tby userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv88AVssG020583; Fri, 8 Sep 2017 10:31:55 GMT", "from mwanda (/41.210.145.102)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Fri, 08 Sep 2017 03:31:54 -0700" ], "Date": "Fri, 8 Sep 2017 13:31:37 +0300", "From": "Dan Carpenter <dan.carpenter@oracle.com>", "To": "Kishon Vijay Abraham I <kishon@ti.com>,\n\tAntoine Tenart <antoine.tenart@free-electrons.com>", "Cc": "netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, \"David S. Miller\" <davem@davemloft.net>", "Subject": "[PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()", "Message-ID": "<20170908103137.zck6bw66sge4fhua@mwanda>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "X-Mailer": "git-send-email haha only kidding", "User-Agent": "NeoMutt/20170609 (1.8.3)", "X-Source-IP": "userv0021.oracle.com [156.151.31.71]", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "devm_ioremap_resource() never returns NULL, it only returns error\npointers so this test needs to be changed.\n\nFixes: d0438bd6aa09 (\"phy: add the mvebu cp110 comphy driver\")\nSigned-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n---\nThis driver apparently is going through the net tree, but netdev isn't\nlisted as handling it in MAINTAINERS. Kishon, do you know what's up\nwith that?", "diff": "diff --git a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c b/drivers/phy/marvell/phy-mvebu-cp110-comphy.c\nindex 73ebad6634a7..24578bd68ddc 100644\n--- a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c\n+++ b/drivers/phy/marvell/phy-mvebu-cp110-comphy.c\n@@ -576,8 +576,8 @@ static int mvebu_comphy_probe(struct platform_device *pdev)\n \t\treturn PTR_ERR(priv->regmap);\n \tres = platform_get_resource(pdev, IORESOURCE_MEM, 0);\n \tpriv->base = devm_ioremap_resource(&pdev->dev, res);\n-\tif (!priv->base)\n-\t\treturn -ENOMEM;\n+\tif (IS_ERR(priv->base))\n+\t\treturn PTR_ERR(priv->base);\n \n \tfor_each_available_child_of_node(pdev->dev.of_node, child) {\n \t\tstruct mvebu_comphy_lane *lane;\n", "prefixes": [ "net" ] }