Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/810996/?format=api
{ "id": 810996, "url": "http://patchwork.ozlabs.org/api/1.2/patches/810996/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170907121346.22011-1-vaibhav@linux.vnet.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/1.2/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20170907121346.22011-1-vaibhav@linux.vnet.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20170907121346.22011-1-vaibhav@linux.vnet.ibm.com/", "date": "2017-09-07T12:13:46", "name": "cxl: Dump PSL_FIR1/2 registers on PSL9 error irq", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "8d7fce65838788268fcb9be0f3ba160a4712b53a", "submitter": { "id": 66174, "url": "http://patchwork.ozlabs.org/api/1.2/people/66174/?format=api", "name": "Vaibhav Jain", "email": "vaibhav@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170907121346.22011-1-vaibhav@linux.vnet.ibm.com/mbox/", "series": [ { "id": 1992, "url": "http://patchwork.ozlabs.org/api/1.2/series/1992/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=1992", "date": "2017-09-07T12:13:46", "name": "cxl: Dump PSL_FIR1/2 registers on PSL9 error irq", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1992/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810996/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810996/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnzv46L07z9s7C\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 7 Sep 2017 22:16:00 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xnzv45VKRzDrX8\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 7 Sep 2017 22:16:00 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xnzsT2NrDzDrW5\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tThu, 7 Sep 2017 22:14:36 +1000 (AEST)", "from pps.filterd (m0098393.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv87CE8v2015360\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 7 Sep 2017 08:14:34 -0400", "from e23smtp07.au.ibm.com (e23smtp07.au.ibm.com [202.81.31.140])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cu1p0cw8b-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 07 Sep 2017 08:14:34 -0400", "from localhost\n\tby e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <linuxppc-dev@lists.ozlabs.org> from <vaibhav@linux.vnet.ibm.com>;\n\tThu, 7 Sep 2017 22:14:31 +1000", "from d23relay09.au.ibm.com (202.81.31.228)\n\tby e23smtp07.au.ibm.com (202.81.31.204) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 7 Sep 2017 22:14:28 +1000", "from d23av06.au.ibm.com (d23av06.au.ibm.com [9.190.235.151])\n\tby d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv87CES1R38535254\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 7 Sep 2017 22:14:28 +1000", "from d23av06.au.ibm.com (localhost [127.0.0.1])\n\tby d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv87CERWA031011\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 7 Sep 2017 22:14:28 +1000", "from vajain21.in.ibm.com (vajain21.in.ibm.com [9.124.35.21] (may be\n\tforged))\n\tby d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv87CEODi030896; Thu, 7 Sep 2017 22:14:25 +1000" ], "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=vaibhav@linux.vnet.ibm.com; receiver=<UNKNOWN>)", "From": "Vaibhav Jain <vaibhav@linux.vnet.ibm.com>", "To": "linuxppc-dev@lists.ozlabs.org,\n\tFrederic Barrat <fbarrat@linux.vnet.ibm.com>,\n\tChristophe Lombard <christophe_lombard@fr.ibm.com>", "Subject": "[PATCH] cxl: Dump PSL_FIR1/2 registers on PSL9 error irq", "Date": "Thu, 7 Sep 2017 17:43:46 +0530", "X-Mailer": "git-send-email 2.13.5", "X-TM-AS-MML": "disable", "x-cbid": "17090712-0044-0000-0000-000002863068", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17090712-0045-0000-0000-0000071B335C", "Message-Id": "<20170907121346.22011-1-vaibhav@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-07_08:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709070180", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Philippe Bergheaud <philippe.bergheaud@fr.ibm.com>,\n\tVaibhav Jain <vaibhav@linux.vnet.ibm.com>,\n\tAndrew Donnellan <andrew.donnellan@au1.ibm.com>,\n\tAlastair D'Silva <alastair@au1.ibm.com>", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "For PSL9 currently we aren't dumping the PSL FIR1/2 registers when a\nPSL error interrupt is triggered. Contents of these registers are\nuseful in debugging AFU issues.\n\nThis patch fixes issue by updating the cxl_native_err_irq_dump_regs()\nto dump these regs on PSL error interrupt thereby bringing the\nbehavior in line with PSL on POWER-8.\n\nSigned-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>\n---\n drivers/misc/cxl/native.c | 13 +++++++++++--\n drivers/misc/cxl/pci.c | 1 +\n 2 files changed, 12 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/misc/cxl/native.c b/drivers/misc/cxl/native.c\nindex 4a82c313cf71..60b91e95821d 100644\n--- a/drivers/misc/cxl/native.c\n+++ b/drivers/misc/cxl/native.c\n@@ -1261,8 +1261,17 @@ void cxl_native_err_irq_dump_regs(struct cxl *adapter)\n {\n \tu64 fir1, fir2;\n \n-\tfir1 = cxl_p1_read(adapter, CXL_PSL_FIR1);\n-\tfir2 = cxl_p1_read(adapter, CXL_PSL_FIR2);\n+\tif (cxl_is_power8()) {\n+\t\tfir1 = cxl_p1_read(adapter, CXL_PSL_FIR1);\n+\t\tfir2 = cxl_p1_read(adapter, CXL_PSL_FIR2);\n+\t} else if (cxl_is_power9()) {\n+\t\tfir1 = cxl_p1_read(adapter, CXL_PSL9_FIR1);\n+\t\tfir2 = cxl_p1_read(adapter, CXL_PSL9_FIR2);\n+\t} else {\n+\t\t/* Dont report garbage */\n+\t\tfir1 = fir2 = 0;\n+\t\tWARN_ON(1);\n+\t}\n \n \tdev_crit(&adapter->dev, \"PSL_FIR1: 0x%016llx\\nPSL_FIR2: 0x%016llx\\n\", fir1, fir2);\n }\ndiff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c\nindex d18b3d9292fd..597e145f38e3 100644\n--- a/drivers/misc/cxl/pci.c\n+++ b/drivers/misc/cxl/pci.c\n@@ -1762,6 +1762,7 @@ static const struct cxl_service_layer_ops psl9_ops = {\n \t.debugfs_add_adapter_regs = cxl_debugfs_add_adapter_regs_psl9,\n \t.debugfs_add_afu_regs = cxl_debugfs_add_afu_regs_psl9,\n \t.psl_irq_dump_registers = cxl_native_irq_dump_regs_psl9,\n+\t.err_irq_dump_registers = cxl_native_err_irq_dump_regs,\n \t.debugfs_stop_trace = cxl_stop_trace_psl9,\n \t.write_timebase_ctrl = write_timebase_ctrl_psl9,\n \t.timebase_read = timebase_read_psl9,\n", "prefixes": [] }