Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/810823/?format=api
{ "id": 810823, "url": "http://patchwork.ozlabs.org/api/1.2/patches/810823/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/17EC94B0A072C34B8DCF0D30AD16044A02985CB5@BPXM09GP.gisp.nec.co.jp/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<17EC94B0A072C34B8DCF0D30AD16044A02985CB5@BPXM09GP.gisp.nec.co.jp>", "list_archive_url": null, "date": "2017-09-06T22:47:59", "name": "net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "87248c8572ed30b4e52cef17609ef570bb3b80bd", "submitter": { "id": 67390, "url": "http://patchwork.ozlabs.org/api/1.2/people/67390/?format=api", "name": "Kosuke Tatsukawa", "email": "tatsu@ab.jp.nec.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/17EC94B0A072C34B8DCF0D30AD16044A02985CB5@BPXM09GP.gisp.nec.co.jp/mbox/", "series": [ { "id": 1895, "url": "http://patchwork.ozlabs.org/api/1.2/series/1895/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1895", "date": "2017-09-06T22:47:59", "name": "net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1895/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810823/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810823/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnfBB2CFlz9t2R\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 7 Sep 2017 08:57:54 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753838AbdIFW5i convert rfc822-to-8bit (ORCPT\n\t<rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 6 Sep 2017 18:57:38 -0400", "from tyo161.gate.nec.co.jp ([114.179.232.161]:43309 \"EHLO\n\ttyo161.gate.nec.co.jp\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752687AbdIFW52 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 6 Sep 2017 18:57:28 -0400", "from mailgate02.nec.co.jp ([114.179.233.122])\n\tby tyo161.gate.nec.co.jp (8.15.1/8.15.1) with ESMTPS id\n\tv86MmdlE008545\n\t(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n\tThu, 7 Sep 2017 07:48:39 +0900", "from mailsv01.nec.co.jp (mailgate-v.nec.co.jp [10.204.236.94])\n\tby mailgate02.nec.co.jp (8.15.1/8.15.1) with ESMTP id v86MmdqT032167; \n\tThu, 7 Sep 2017 07:48:39 +0900", "from mail02.kamome.nec.co.jp (mail02.kamome.nec.co.jp [10.25.43.5])\n\tby mailsv01.nec.co.jp (8.15.1/8.15.1) with ESMTP id v86Mlck1020557;\n\tThu, 7 Sep 2017 07:48:39 +0900", "from bpxc99gp.gisp.nec.co.jp ([10.38.151.135] [10.38.151.135]) by\n\tmail03.kamome.nec.co.jp with ESMTP id BT-MMP-2885886;\n\tThu, 7 Sep 2017 07:48:00 +0900", "from BPXM09GP.gisp.nec.co.jp ([10.38.151.201]) by\n\tBPXC07GP.gisp.nec.co.jp ([10.38.151.135]) with mapi id 14.03.0319.002;\n\tThu, 7 Sep 2017 07:47:59 +0900" ], "X-Greylist": "delayed 567 seconds by postgrey-1.27 at vger.kernel.org;\n\tWed, 06 Sep 2017 18:57:26 EDT", "From": "Kosuke Tatsukawa <tatsu@ab.jp.nec.com>", "To": "Jay Vosburgh <j.vosburgh@gmail.com>,\n\tVeaceslav Falico <vfalico@gmail.com>,\n\tAndy Gospodarek <andy@greyhouse.net>", "CC": "\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n\t\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>,\n\tReinis Rozitis <r@roze.lv>", "Subject": "[PATCH] net: bonding: Fix transmit load balancing in balance-alb\n\tmode if specified by sysfs", "Thread-Topic": "[PATCH] net: bonding: Fix transmit load balancing in\n\tbalance-alb mode if specified by sysfs", "Thread-Index": "AdMnYjAbA4D4jtm8RXC4JQ/cT4z0NA==", "Date": "Wed, 6 Sep 2017 22:47:59 +0000", "Message-ID": "<17EC94B0A072C34B8DCF0D30AD16044A02985CB5@BPXM09GP.gisp.nec.co.jp>", "Accept-Language": "ja-JP, en-US", "Content-Language": "ja-JP", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.34.125.78]", "Content-Type": "text/plain; charset=\"iso-2022-jp\"", "Content-Transfer-Encoding": "8BIT", "MIME-Version": "1.0", "X-TM-AS-MML": "disable", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Commit cbf5ecb30560 (\"net: bonding: Fix transmit load balancing in\nbalance-alb mode\") tried to fix transmit dynamic load balancing in\nbalance-alb mode, which wasn't working after commit 8b426dc54cf4\n(\"bonding: remove hardcoded value\").\n\nIt turned out that my previous patch only fixed the case when\nbalance-alb was specified as bonding module parameter, and not when\nbalance-alb mode was set using /sys/class/net/*/bonding/mode (the most\ncommon usage). In the latter case, tlb_dynamic_lb was set up according\nto the default mode of the bonding interface, which happens to be\nbalance-rr.\n\nThis additional patch addresses this issue by setting up tlb_dynamic_lb\nto 1 if \"mode\" is set to balance-alb through the sysfs interface.\n\nI didn't add code to change tlb_balance_lb back to the default value for\nother modes, because \"mode\" is usually set up only once during\ninitialization, and it's not worthwhile to change the static variable\nbonding_defaults in bond_main.c to a global variable just for this\npurpose.\n\nCommit 8b426dc54cf4 also changes the value of tlb_dynamic_lb for\nbalance-tlb mode if it is set up using the sysfs interface. I didn't\nchange that behavior, because the value of tlb_balance_lb can be changed\nusing the sysfs interface for balance-tlb, and I didn't like changing\nthe default value back and forth for balance-tlb.\n\nAs for balance-alb, /sys/class/net/*/bonding/tlb_balance_lb cannot be\nwritten to. However, I think balance-alb with tlb_dynamic_lb set to 0\nis not an intended usage, so there is little use making it writable at\nthis moment.\n\nFixes: 8b426dc54cf4 (\"bonding: remove hardcoded value\")\nReported-by: Reinis Rozitis <r@roze.lv>\nSigned-off-by: Kosuke Tatsukawa <tatsu@ab.jp.nec.com>\nCc: stable@vger.kernel.org # v4.12+\n---\n drivers/net/bonding/bond_options.c | 3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)", "diff": "diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c\nindex a12d603..5931aa2 100644\n--- a/drivers/net/bonding/bond_options.c\n+++ b/drivers/net/bonding/bond_options.c\n@@ -754,6 +754,9 @@ static int bond_option_mode_set(struct bonding *bond,\n \t\t\t bond->params.miimon);\n \t}\n \n+\tif (newval->value == BOND_MODE_ALB)\n+\t\tbond->params.tlb_dynamic_lb = 1;\n+\n \t/* don't cache arp_validate between modes */\n \tbond->params.arp_validate = BOND_ARP_VALIDATE_NONE;\n \tbond->params.mode = newval->value;\n", "prefixes": [] }